[NO QA] Slice 2: untangle docs/code, adopt postCodeReviewResults.sh, use run-claude-action composite#91689
Draft
kacper-mikolajczak wants to merge 3 commits into
Draft
[NO QA] Slice 2: untangle docs/code, adopt postCodeReviewResults.sh, use run-claude-action composite#91689kacper-mikolajczak wants to merge 3 commits into
kacper-mikolajczak wants to merge 3 commits into
Conversation
Untangles the two review flows so the code-review path matches the single-claude-code-action shape used by Expensify/Auth and Expensify/Web-Expensify. The validate and checkCPlusApproval gate jobs are unchanged; both new jobs depend on them and share the existing concurrency group.
Replaces the inline jq+while-loop in the review-code job's Post code review results step with a single postCodeReviewResults.sh call. Bumps the claude-review-toolkit pin to the SHA that introduces the new script.
Rewires both claude-code-action invocations (code review + docs review) to go through the new run-claude-action composite, centralising the SHA pin. Drops display_report and allowed_non_write_users (composite defaults); keeps --model claude-opus-4-6 in claude_args because the composite no longer forces a model.
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Slice 2 of the Claude reviewer centralisation effort. Three independent changes to
.github/workflows/claude-review.yml, shipped as separate commits inside one PR:reviewjob becomesreview-codeandreview-docs, both gated by the unchangedvalidate+checkCPlusApprovaljobs. The code-review path now matches the single-claude-code-actionshape used by Expensify/Auth and Expensify/Web-Expensify.postCodeReviewResults.shfromclaude-review-toolkit. Replaces the inlinejq+ while-loop inreview-code'sPost code review resultsstep with one script call. Bumps the toolkit pin to the SHA introducing the script.run-claude-actioncomposite. Rewires bothclaude-code-actioninvocations (code review + docs review) through the new shared composite, centralising the SHA pin. App keeps--model claude-opus-4-6inclaude_args(composite is intentionally model-agnostic).No steady-state behaviour change: same triggers, same gating, same model (
claude-opus-4-6) for both flows, same allowedTools, same schema, same prompts, same comments posted on real PRs.The pins reference the consolidated Expensify/GitHub-Actions#68 branch and will be re-stamped to the merged-
mainSHA once that PR lands.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/635397
PROPOSAL:
Tests
N/A - CI infrastructure change with no user-facing runtime behaviour. End-to-end validation happens by running the workflow against real PRs after Expensify/GitHub-Actions#68 lands and the pins here are re-stamped.
Offline tests
N/A - CI infrastructure change; doesn't affect runtime offline behaviour.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
[No QA] - CI workflow change. After merge, @Julesssss and @kacper-mikolajczak will check a handful of AI Reviewer workflow runs on real PRs.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
cc @Julesssss