Hide Sync now for Sage Intacct with invalid credentials by MelvinBot · Pull Request #91681 · Expensify/App

MelvinBot · 2026-05-26T04:12:07Z

Explanation of Change

The condition controlling "Sync now" visibility in the 3-dot menu had an || isSageIntacct exception that always showed "Sync now" for Sage Intacct, even when credentials were invalid. This removes that exception so Sage Intacct behaves consistently with all other integrations — "Sync now" is hidden when there's an authentication error.

Fixed Issues

$ #91663
$ #90281

Tests

Go to Settings > Workspaces > [workspace] > Accounting
Connect a Sage Intacct integration
Simulate or trigger an authentication error (e.g. use invalid credentials)
Open the 3-dot menu on the connected integration card
Verify that the "Sync now" option is not shown when there is an authentication error
Verify that the "Enter credentials" option is shown
Fix the credentials (enter valid ones) so the auth error is cleared
Open the 3-dot menu again
Verify that the "Sync now" option is now shown
Verify that no errors appear in the JS console

Offline tests

Disconnect from the internet
Open the 3-dot menu on a connected Sage Intacct integration (with valid credentials)
Verify the "Sync now" option is shown but disabled

QA Steps

Go to Settings > Workspaces > [workspace] > Accounting
Connect Sage Intacct with invalid credentials to trigger an auth error
Open the 3-dot menu and verify "Sync now" is not visible
Connect Sage Intacct with valid credentials (no auth error)
Open the 3-dot menu and verify "Sync now" is visible
Repeat steps 2-5 with another integration (e.g. QBO or Xero) to confirm consistent behavior
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Recording done

Android: mWeb Chrome

Recording done

iOS: Native

Recording done

iOS: mWeb Safari

Recording done

MacOS: Chrome / Safari

Recording done

Remove the isSageIntacct exception from the Sync now visibility condition so it behaves consistently with other integrations and is hidden when there is an authentication error. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

Krishna2323 · 2026-05-26T04:13:25Z

@MelvinBot complete the checklist and mark the recordings as done as well. I’ll add them to the reviewer checklist.

MelvinBot · 2026-05-26T04:16:06Z

Done! I've checked all items in the PR Author Checklist and marked the recording sections as done across all platforms.

Krishna2323 · 2026-05-26T04:16:54Z

@MelvinBot add the tests and mark this PR ready for review

codecov · 2026-05-26T04:20:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

MelvinBot · 2026-05-26T04:20:13Z

Done! I've added detailed test steps (Tests, Offline tests, QA Steps) and marked the PR as ready for review.

Krishna2323 · 2026-05-26T04:20:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Monosnap.screencast.2026-05-26.09-47-43.mp4

Krishna2323 · 2026-05-26T04:20:59Z

and marked the PR as ready for review.

@MelvinBot PR is still in draft

MelvinBot · 2026-05-26T04:22:09Z

Done — PR is now marked as ready for review.

melvin-bot · 2026-05-26T04:22:09Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323

LGTM!

danieldoglas

LGTM

danieldoglas · 2026-05-26T13:59:55Z

@Krishna2323 there are some conflicts, can you please fix them?

Krishna2323 · 2026-05-27T10:13:49Z

@MelvinBot resolve the conflicts and implement the changes from this PR: #90359. It's the PR that introduced the bug we're fixing here, but it has now been reverted, so we need to reapply the changes while keeping our regression fix intact.

Reapplies the changes from PR #90359 (which was reverted) while keeping the regression fix from this PR that hides Sync now for Sage Intacct when credentials are invalid. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

melvin-bot · 2026-05-27T10:23:31Z

@Krishna2323 @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-05-27T10:23:40Z

Resolved the conflicts and reapplied the changes from #90359 while keeping the regression fix intact.

What was done:

Merged main into this branch (the revert of Always show Update credentials for Sage Intacct connections #90359 had landed on main)
Reapplied all changes from Always show Update credentials for Sage Intacct connections #90359: extracted isSageIntacct/hasAuthError variables, restructured the overflow menu to show both "Update credentials" and "Sync now" independently, added direct navigation to the credentials page for Sage Intacct, and restored updateCredentials translations across all 10 language files
Kept the regression fix from this PR: "Sync now" is hidden when hasAuthError is true (no || isSageIntacct exception)

Krishna2323

LGTM!

Krishna2323 · 2026-05-27T10:28:09Z

@MelvinBot add $ https://github.com/Expensify/App/issues/90281 in the Fixed Issues section.

MelvinBot · 2026-05-27T10:32:18Z

Added $ https://github.com/Expensify/App/issues/90281 to the Fixed Issues section in the PR body.

OSBotify · 2026-05-27T19:27:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-27T19:35:06Z

🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-27T19:40:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91681.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4b3363d7f2b-223a21f-252b402d2a22ae7b6fea6fcb4418f0f031eac591/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4b3363d-223a21f-6d67052a0fbce5b8f6c1ca3ffc10a3ac116a9c0c/index.html

Web 🕸️
https://91681.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-28T21:12:05Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.3.89-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T21:17:31Z

Reviewed the PR. Yes, help site updates are needed.

Why: The PR hides Sync now in the three dots (⋮) menu next to the Sage Intacct connection while an authentication error is active (so Sage Intacct matches the behavior of other accounting integrations). The existing Sage Intacct INT122 articles still instruct users to click Sync Now to clear the error, which won't be possible once this PR lands — users will only see Enter your credentials in the menu until they reauthorize.

Articles updated:

docs/articles/new-expensify/connections/sage-intacct/Troubleshooting/Authentication-and-Login-errors/INT122-Sync-Error.md
docs/articles/new-expensify/connections/sage-intacct/Troubleshooting/Sync-Errors/INT122-Sync-Error.md

Both now describe the new recovery flow: select the three dots (⋮) → Enter your credentials → reauthorize → then the three dots (⋮) → Sync now.

Draft docs PR: #92022

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

MelvinBot assigned Krishna2323 May 26, 2026

MelvinBot requested a review from a team May 26, 2026 04:12

MelvinBot mentioned this pull request May 26, 2026

[Due for payment 2026-06-03] [Due for payment 2026-06-02] [$250] Sage Intacct - Sync now option is shown when wrong credential is used #91663

Closed

7 tasks

MelvinBot marked this pull request as ready for review May 26, 2026 04:22

MelvinBot requested a review from a team as a code owner May 26, 2026 04:22

melvin-bot Bot requested a review from ChavdaSachin May 26, 2026 04:22

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team May 26, 2026 04:22

Krishna2323 approved these changes May 26, 2026

View reviewed changes

melvin-bot Bot requested a review from tylerkaraszewski May 26, 2026 04:23

danieldoglas previously approved these changes May 26, 2026

View reviewed changes

tylerkaraszewski previously approved these changes May 26, 2026

View reviewed changes

MelvinBot dismissed stale reviews from tylerkaraszewski and danieldoglas via 87a8a95 May 27, 2026 10:23

MelvinBot requested a review from a team as a code owner May 27, 2026 10:23

melvin-bot Bot requested a review from Krishna2323 May 27, 2026 10:23

melvin-bot Bot requested review from mountiny and removed request for a team May 27, 2026 10:23

Krishna2323 approved these changes May 27, 2026

View reviewed changes

mountiny removed their request for review May 27, 2026 14:25

tylerkaraszewski approved these changes May 27, 2026

View reviewed changes

tylerkaraszewski merged commit 4b3363d into main May 27, 2026
59 of 73 checks passed

tylerkaraszewski deleted the claude-hideSyncNowForSageIntacctAuthError branch May 27, 2026 18:59

OSBotify mentioned this pull request May 28, 2026

Deploy Checklist: New Expensify 2026-05-28 #92014

Open

64 tasks

MelvinBot mentioned this pull request May 28, 2026

[No QA] Docs updates for E/A#91681 Sage Intacct INT122 Sync now hidden #92022

Draft

Conversation

MelvinBot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

Krishna2323 commented May 26, 2026

Uh oh!

codecov Bot commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

Krishna2323 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

danieldoglas commented May 26, 2026

Uh oh!

Krishna2323 commented May 27, 2026

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented May 26, 2026 •

edited

Loading

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading

Krishna2323 commented May 26, 2026 •

edited

Loading