Skip to content

[No QA] Update help docs for Gusto HR integration in New Expensify#91754

Merged
yuwenmemon merged 10 commits into
mainfrom
claude-gustoHelpDocs
May 27, 2026
Merged

[No QA] Update help docs for Gusto HR integration in New Expensify#91754
yuwenmemon merged 10 commits into
mainfrom
claude-gustoHelpDocs

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented May 26, 2026

Explanation of Change

Adds help site documentation for the Gusto HR integration in New Expensify, covering all three releases scoped in Expensify/Expensify#615695:

New article: docs/articles/new-expensify/connections/Gusto.md

  • Release 1: How to enable the HR feature in More Features, connect Gusto via OAuth, and understand sync results
  • Release 1: How to configure the approval mode (Basic Approval vs Manager Approval) and set a final approver
  • Release 2: How to view synced employee count on the Members page and trigger a manual re-sync
  • Release 3: How Gusto manager relationships feed into the Workflows page, why the Approvals toggle is locked on, and how to disconnect

Updated article: docs/articles/new-expensify/workspaces/Add-Approvals.md

  • Release 3: Added a note explaining that when Gusto is connected, the Approvals toggle is locked on and approval chains are managed from the HR page

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/615695

- New article: Connect Gusto to Expensify (new-expensify/connections/Gusto.md)
  covering HR feature enablement, OAuth connection, approval mode configuration,
  sync results, Members page sync status, manual re-sync, and disconnection.
- Update Add-Approvals.md with a callout explaining that when Gusto is connected,
  the Approvals toggle is locked on and managed from the HR page.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team May 26, 2026 19:49
@github-actions github-actions Bot changed the title Update help docs for Gusto HR integration in New Expensify [No QA] Update help docs for Gusto HR integration in New Expensify May 26, 2026
@OSBotify

This comment has been minimized.

Comment thread docs/articles/new-expensify/connections/Gusto.md Outdated
Comment thread docs/articles/new-expensify/connections/Gusto.md Outdated
Comment thread docs/articles/new-expensify/connections/Gusto.md Outdated
@MelvinBot
Copy link
Copy Markdown
Contributor Author

The build check failure is not related to this PR's changes — it's a transient Cloudflare Pages deployment error.

The Cloudflare asset upload API returned a 502 Bad Gateway during the Deploy to Cloudflare Pages step:

POST /pages/assets/upload -> 502 Bad Gateway

The files were successfully uploaded (1523/1523), but the API returned a malformed response afterward, causing wrangler to throw a FatalError.

Fix: Re-run the failed build workflow. No code changes are needed.

@stephanieelliott stephanieelliott marked this pull request as ready for review May 26, 2026 23:04
@stephanieelliott stephanieelliott self-requested a review as a code owner May 26, 2026 23:04
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 26, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot Bot requested a review from greg-schroeder May 26, 2026 23:04
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 26, 2026

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 26, 2026 23:04
@stephanieelliott stephanieelliott removed the request for review from greg-schroeder May 26, 2026 23:05
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Both failing checks are unrelated to this PR's code changes — no fix is needed.

  1. build: Cloudflare Pages deploy returned a 502 Bad Gateway during asset upload (POST /pages/assets/upload -> 502 Bad Gateway). This is a transient Cloudflare infrastructure error that has now occurred on two consecutive runs.

  2. review: This job was cancelled, not failed — likely a dependency cascade from the build failure.

Fix: Re-run the failed build workflow. If the Cloudflare 502 persists, it may indicate a broader Cloudflare Pages outage — check Cloudflare status and try again later.

@stephanieelliott
Copy link
Copy Markdown
Contributor

I'm still working on this @yuwenmemon - I will tap you when it's ready for your review!

@OSBotify

This comment has been minimized.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The spellcheck failure was caused by a typo (workdpaceworkspace) which was already fixed in commit a41054bed. New checks are now running against the latest commit and should pass.

The previous build failure (Cloudflare 502 Bad Gateway) was a transient infrastructure issue — the new build run should also resolve on its own.

@OSBotify

This comment has been minimized.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

All checks are now passing ✅ — the build failure was a transient Cloudflare 502 and succeeded on re-run.

@stephanieelliott
Copy link
Copy Markdown
Contributor

All set @yuwenmemon!

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a comprehensive new article for the Gusto integration and a well-placed cross-reference in the existing Approvals article. The new article is well-structured, covers the full lifecycle (connect, configure, view, disconnect), and follows governance rules closely. A few minor phrasing issues were identified.

Scores Summary

  • Readability: 9/10 - Clear structure, logical flow, scannable sections. Steps are sequential and action-oriented. Bullet lists effectively summarize outcomes. The article is easy to follow from start to finish.
  • AI Readiness: 10/10 - All YAML metadata fields present and well-formed, including internalScope. Multiple task-based "How to" headings with full feature names. Only # and ## headings used (plus # FAQ). Keywords cover realistic search phrases.
  • Style Compliance: 8/10 - UI elements are consistently bolded, no quotation marks used, FAQ structure follows conventions. Two issues: (1) the navigation phrasing in step 1 uses "and at the bottom" instead of the exact governance wording "on the bottom on mobile", and (2) subsequent procedures use "In the left menu" which is not an exact UI label and edges toward the prohibited vague phrasing pattern.

Key Findings

  • The article correctly follows the one-workflow-per-article principle while covering the full Gusto connection lifecycle (connect, configure, sync, disconnect), which logically belongs together.
  • All headings are task-based with action verbs or question words -- fully compliant with heading rules.
  • The cross-link added to Add-Approvals.md is correctly placed outside of numbered steps, uses a relative link, and has descriptive anchor text ("Learn about connecting Gusto to Expensify").
  • The FAQ section addresses practical user questions with direct answers -- well done.
  • Navigation instruction in step 1 deviates slightly from the mandated phrasing. Governance specifies: "In the navigation tabs (on the left on web, on the bottom on mobile)" but the article uses "on the left on web, and at the bottom on mobile" (extra "and" and "at the" instead of "on the").
  • Steps in later sections (approval mode configuration, disconnect) use "In the left menu, click HR" -- while understandable, "left menu" is not an exact UI label and could be replaced with more precise terminology consistent with the navigation conventions.

Recommendations

  1. Fix navigation phrasing in step 1 of "How to connect Gusto to Expensify": change "and at the bottom on mobile" to "on the bottom on mobile" to match the exact governance wording.
  2. Consider refining "In the left menu" references in subsequent procedures to use more precise UI terminology consistent with how the workspace sidebar is labeled in the product.

Files Reviewed

  • docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md (new) - Strong new article with minor navigation phrasing issues.
  • docs/articles/new-expensify/workspaces/Add-Approvals.md (modified) - Clean cross-reference addition, fully compliant with governance rules.

@yuwenmemon
Copy link
Copy Markdown
Contributor

@MelvinBot can you update your PR to incorporate the review here: #91754 (comment)

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Thanks for the review feedback! I've looked at the two recommendations from the HelpDot review:

  1. Fix navigation phrasing in step 1: change "and at the bottom on mobile" → "on the bottom on mobile"
  2. Refine "In the left menu" references to use more precise UI terminology

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. To have me implement this, the PR assignee or author should reply with a request tagging me.

@stephanieelliott
Copy link
Copy Markdown
Contributor

@MelvinBot can you update your PR to incorporate the review here: #91754 (comment)

Change "and at the bottom on mobile" to "on the bottom on mobile"
to match the standard help site navigation instruction format.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Addressed the HelpDot review feedback:

Fixed: Navigation phrasing in step 1 — changed "and at the bottom on mobile" → "on the bottom on mobile" to match the standard governance wording used across all other help articles.

Not changed: "In the left menu" phrasing — this is already the established convention used in other articles (e.g., Add-Approvals.md, Enable-Travel-on-a-Workspace.md, Set-Up-Traveler-Messaging.md), so changing it only in this article would create inconsistency. If this should be updated site-wide, that would be a separate effort.

@OSBotify

This comment has been minimized.

Comment thread docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md Outdated
Comment thread docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md Outdated
Comment thread docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md Outdated
Comment thread docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md Outdated
Comment thread docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new Gusto integration article and adds a cross-reference note to the existing Add-Approvals article. The new article is well-structured, follows governance standards closely, and provides clear procedural guidance. The cross-link addition to Add-Approvals is minimal and well-placed. Overall, this is a strong submission with only minor items to consider.

Scores Summary

  • Readability: 9/10 - The article is well-organized with clear sequential steps, scannable bullet lists, and concise explanations. The FAQ section provides practical answers. One minor note: the "How to view synced employees and refresh the Gusto sync" section combines two tasks in one heading, which slightly reduces scannability.
  • AI Readiness: 9/10 - YAML metadata is complete and well-crafted, including a thorough internalScope field with explicit exclusions. All ## headings are task-based with action verbs or question words. The article includes multiple "How to" headings with the feature name "Gusto." Keywords are comprehensive and reflect realistic search queries. A few FAQ headings could benefit from explicitly including "Gusto" (e.g., "Will my employees receive a notification when synced?" could be "Will employees receive a notification when synced from Gusto?").
  • Style Compliance: 8/10 - UI elements are consistently bolded. Navigation follows the unified format correctly in step 1. However, there are a few items to address: (1) The phrase "In the left menu" is used for workspace sub-navigation in multiple sections -- this pattern is not explicitly defined in the naming conventions and could benefit from consistency with the established navigation phrasing. (2) Some FAQ headings use first-person "I" (e.g., "Can I sync..." and "Can I change...") while the governance docs favor describing what "you" or roles can do. (3) The cross-link added to Add-Approvals uses the anchor text "Learn about connecting Gusto to Expensify" -- the guidelines prefer formats like "Learn how to connect Gusto to Expensify" (action-oriented).

Key Findings

  • The article correctly adheres to the single-workflow-per-article principle, focusing exclusively on the Gusto connection lifecycle (connect, configure, sync, disconnect).
  • YAML frontmatter is thorough and includes all required fields with meaningful content, including a well-defined internalScope.
  • Heading hierarchy is correct: one # title, one # FAQ, and all content sections use ## only.
  • All ## headings are task-based and include the feature name "Gusto" -- this is a strong point for retrieval.
  • The cross-link in Add-Approvals is placed correctly after an explanatory sentence and outside of numbered steps, using a relative link path.
  • No prohibited language patterns were detected (no vague navigation phrases, no generic headings).

Recommendations

  1. Consider adding "Gusto" to FAQ headings that currently lack it, to improve search retrieval (e.g., "Will employees receive a notification when synced from Gusto?" and "Can I sync Gusto employees to different Expensify workspaces?").
  2. Review the "In the left menu" phrasing used for workspace sub-navigation. If this is an established pattern across HelpDot articles for workspace settings navigation, it is fine to keep. If not, consider aligning with the navigation conventions more explicitly.
  3. Update the cross-link anchor text in Add-Approvals from "Learn about connecting Gusto to Expensify" to "Learn how to connect Gusto to Expensify" to better match the action-oriented anchor text guidance.
  4. The heading "How to view synced employees and refresh the Gusto sync" covers two related but distinct tasks. Consider whether splitting into two ## sections would improve clarity, though keeping them together is acceptable given their close relationship.

Files Reviewed

  • docs/articles/new-expensify/connections/Connect-Gusto-to-Expensify.md (new file) - Well-structured new article covering the full Gusto integration lifecycle. Minor improvements recommended for FAQ headings and navigation phrasing.
  • docs/articles/new-expensify/workspaces/Add-Approvals.md (modified) - Small, well-placed cross-reference addition. Anchor text could be more action-oriented.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

…sify.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OSBotify

This comment has been minimized.

@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://4568537e.helpdot.pages.dev ⚡️

Updated articles:

@yuwenmemon yuwenmemon merged commit 7001b0d into main May 27, 2026
16 checks passed
@yuwenmemon yuwenmemon deleted the claude-gustoHelpDocs branch May 27, 2026 20:53
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 27, 2026

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label May 27, 2026
@yuwenmemon
Copy link
Copy Markdown
Contributor

yuwenmemon commented May 27, 2026

Tests were passing from what I saw. And the latest commit confirms that.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.89-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants