[CP Staging] Revert "86223 update cta and workspace chat copy"#91817
Conversation
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (83KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
Straight revert |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
…A-and-Workspace-Chat-Copy [CP Staging] Revert "86223 update cta and workspace chat copy" (cherry picked from commit 015e7d2) (cherry-picked to staging by mountiny)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.83-1 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are required. This revert removes the "Mark as done" feature, but 3 help site articles still reference it. I've created a draft PR to remove all "Mark as done" references: #91826 Files updated:
@mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
Help site changes are required. This PR reverts the "Mark as done" feature, but 3 help site articles still reference it. Draft PR created: #91872 Changes made — removed "Mark as done" references from:
@mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are required. This PR reverts the "Mark as done" feature (from #88455), but three help site articles still reference it. I created a draft PR to remove these references: #91945 Changes made:
@mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are required. This PR reverts the "Mark as done" feature, but 3 help site articles still reference it. Draft PR created: #91971 Changes:
@mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
Reverts #88455
Fixed issues
$ #91769
$ #91782
$ #91784
$ #91807
$ #91815
$ #91767
$ #91763
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.