Perf: Defer Search/Reports list mount via NavigationDeferredMount by dariusz-biela · Pull Request #91848 · Expensify/App

dariusz-biela · 2026-05-27T14:15:22Z

Explanation of Change

Warm start of the Reports/Search page (first render in a session, data already cached) takes ~550ms (Mac M4 Pro) because we wait for the full list to render before showing anything to the user. This PR applies NavigationDeferredMount to that path so the warm start behaves like a cold start visually:

On first mount of SearchPage, a SearchRowSkeleton placeholder paints immediately and ends ManualNavigateToReports with is_warm: true.
The heavy Search subtree mounts inside startTransition after the navigation transition completes, so the list does not compete with the navigation animation frame budget.
Subsequent navigations to the same tab (react-freeze cache hit) re-use the already-mounted Search, do not show the skeleton, and end the span via the existing useFocusEffect — that path still measures to list visible.

Implementation:

New src/components/Search/SearchWithNavigationDeferredMount.tsx. Accepts ComponentProps<typeof Search>, picks the placeholder container style from useResponsiveLayout() + props.hasFilterBars, and spreads props to Search.
SearchPageWide and SearchPageNarrow (non-static branch) render SearchWithNavigationDeferredMount instead of Search directly. The static-rendering branch in SearchPageNarrow (post-submit overlay path) is left untouched.

Results:

Warm full - this is the time it takes for the first warm render to display the full list, rather than just the skeleton.

Fixed Issues

$ #91731
PROPOSAL:

Tests

Log in.
Cold start — In Troubleshoot, run "Reset Onyx", refresh the page, then navigate to the Reports page. Verify the page-level skeleton is shown until data arrives, then the list renders.
Warm start, first render — Go to Home, refresh the page, then navigate to the Reports page. Verify a skeleton briefly paints before the list appears.
Warm start, cached render — Go to Home, then back to the Reports page. Verify the list shows immediately without a skeleton.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-05-27.at.16.46.29.mp4

iOS: Native

Screen.Recording.2026-05-27.at.16.42.14.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-05-27.at.16.36.52.mp4

Introduce SearchWithNavigationDeferredMount that wraps Search in NavigationDeferredMount with a SearchRowSkeleton placeholder. The placeholder ends the ManualNavigateToReports span with is_warm=true at first layout, so warm first mount measures to skeleton visible while the heavy list hydrates after the navigation transition completes. Refocus through react-freeze still ends the span via Search's existing useFocusEffect, so cached navigations keep measuring to list visible without showing a skeleton. Used by SearchPageWide and SearchPageNarrow (non-static branch) in place of the previous inline render so the spread-props wrapper handles narrow vs wide container styling internally via useResponsiveLayout.

codecov · 2026-05-27T14:25:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/SearchPageNarrow/index.tsx	`73.33% <ø> (ø)`
src/pages/Search/SearchPageWide.tsx	`0.00% <ø> (ø)`
...nents/Search/SearchWithNavigationDeferredMount.tsx	`7.69% <7.69%> (ø)`
... and 179 files with indirect coverage changes

melvin-bot · 2026-05-27T14:58:22Z

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-27T14:58:30Z

@mananjadhav @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM

luacmartins · 2026-05-27T19:25:42Z

Unassigning @mananjadhav since melvin double assigned C+. @marufsharifi can you please prioritize this review?

marufsharifi · 2026-05-28T06:37:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.1405-03-07.at.5.08.09.PM.mp4

Android: mWeb Chrome

Screen.Recording.1405-03-07.at.4.22.35.PM.mp4

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.1405-03-07.at.4.54.33.PM.mov

MacOS: Chrome / Safari

Screen.Recording.1405-03-07.at.3.13.59.PM.mov

JakubKorytko

Two points, overall lookin good.

JakubKorytko · 2026-05-28T11:02:31Z

+            placeholder={
+                <SearchRowSkeleton
+                    shouldAnimate
+                    onLayout={() => endSpanWithAttributes(CONST.TELEMETRY.SPAN_NAVIGATE_TO_REPORTS, {[CONST.TELEMETRY.ATTRIBUTE_IS_WARM]: true})}


Would this not end the span prematurely, without the need for focus, when pre-inserted under RHP without need for the screen to be visible? It may already not require already focus, but it's worth checking.

Should we not also end ManualSubmitToDestinationVisible in this component? The destination (the search page) is undoubtedly visible, so I think the answer is yes.

Would this not end the span prematurely, without the need for focus, when pre-inserted under RHP without need for the screen to be visible? It may already not require already focus, but it's worth checking.

SPAN_NAVIGATE_TO_REPORTS only starts on tab press in SearchTabButton, so it will not be measured while RHP is open, since you cannot click the button in the navigation menu at that time.

Should we not also end ManualSubmitToDestinationVisible in this component? The destination (the search page) is undoubtedly visible, so I think the answer is yes.

I added this in the commit: b1afdea

marufsharifi · 2026-05-28T18:52:38Z

I’ve tried several times, but I’m currently unable to run the Hybrid app on iOS native. I’ve tested it on all other platforms, and everything is working perfectly there. I’ll re-test the iOS native setup tomorrow and share an update.

Screen.Recording.1405-03-07.at.11.15.48.PM.mov

addressed

github-actions · 2026-05-28T19:05:38Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-28T19:11:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91848.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1a2d167416a-10aa8c0-3ccce22b565b6d9a6965b444cd58fc14bf82d62d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1a2d167-10aa8c0-17d369343955a2e037fcb15e99dffb44ccc6b374/index.html

Web 🕸️
https://91848.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-28T19:15:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-28T21:12:29Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.89-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T21:13:56Z

Help site review

No help site changes are required for this PR.

This change is a purely internal performance optimization — it wraps the Search/Reports list in NavigationDeferredMount so a SearchRowSkeleton placeholder paints briefly on the first warm render before the full list mounts. There are no user-facing changes to:

Feature names, tabs, or buttons
Settings, workflows, or behaviors documented on the help site
Anything a customer would interact with differently

The skeleton/loading state is an implementation detail of how the page renders and isn't documented in any current help articles under App/docs/articles.

@dariusz-biela, please confirm — if you believe this still warrants a docs update, let me know what behavior should be documented and I'll open a draft PR.

melvin-bot Bot assigned dariusz-biela May 27, 2026

dariusz-biela marked this pull request as ready for review May 27, 2026 14:58

dariusz-biela requested review from a team as code owners May 27, 2026 14:58

melvin-bot Bot requested review from a team, JmillsExpensify and marufsharifi and removed request for a team May 27, 2026 14:58

melvin-bot Bot requested review from luacmartins and mananjadhav and removed request for a team May 27, 2026 14:58

luacmartins previously approved these changes May 27, 2026

View reviewed changes

luacmartins removed the request for review from mananjadhav May 27, 2026 19:25

JakubKorytko previously requested changes May 28, 2026

View reviewed changes

End ManualSubmitToDestinationVisible on skeleton paint

b1afdea

dariusz-biela dismissed luacmartins’s stale review via b1afdea May 28, 2026 14:48

luacmartins approved these changes May 28, 2026

View reviewed changes

marufsharifi approved these changes May 28, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins May 28, 2026 18:56

luacmartins approved these changes May 28, 2026

View reviewed changes

luacmartins merged commit 1a2d167 into Expensify:main May 28, 2026
42 of 45 checks passed

OSBotify mentioned this pull request May 28, 2026

Deploy Checklist: New Expensify 2026-05-28 #92014

Open

65 tasks

Conversation

dariusz-biela commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 27, 2026

Uh oh!

marufsharifi commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

JakubKorytko May 28, 2026

Choose a reason for hiding this comment

Uh oh!

dariusz-biela May 28, 2026

Choose a reason for hiding this comment

Uh oh!

dariusz-biela May 28, 2026

Choose a reason for hiding this comment

Uh oh!

marufsharifi commented May 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Help site review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dariusz-biela commented May 27, 2026 •

edited

Loading

codecov Bot commented May 27, 2026 •

edited by github-actions Bot

Loading

marufsharifi commented May 28, 2026 •

edited

Loading