[Payment due @ShridharGoel] Remove gustoNewDot beta gate now that Gusto on New Expensify is launching to all users#91877
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b99d6b4d4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (provider.beta && !isBetaEnabled(provider.beta)) { | ||
| continue; |
There was a problem hiding this comment.
Preserve connected beta HR providers
When a workspace already has Zenefits connected and the current admin is not in the Zenefits beta, this check hides that connected provider, but this PR now makes the HR page reachable for everyone through public Gusto. WorkspaceHRPage then builds connectedCards from this filtered list, so connectedCards.length is 0 and the user can start the Gusto connection flow instead of getting the existing “already connected” warning, even though isAnyHRConnected(policy) elsewhere still treats the workspace as connected. Please include already-connected providers regardless of the viewer’s beta, or base the connect guard on the unfiltered HR connection state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
(Yuwen's Agent) Good catch — fixed in 699b4f3. getHRCards now skips a beta-gated provider only when it is not connected, so an already-connected Zenefits card still appears (and the "already connected" warning fires correctly) for admins without the Zenefits beta. Added a unit test for the case.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🎯 @ShridharGoel, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-05-28.at.3.28.00.AM.mov |
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.89-1 🚀
Bundle Size Analysis (Sentry): |
Help site review — no doc changes requiredThe user-facing impact of this PR is simply the removal of the
The PR doesn't introduce new pages, flows, or UI labels — it only removes the beta gate around existing functionality that's already documented. No help site PR needed for this change. cc |
@Gonals please review
Explanation of Change
Gusto on New Expensify is rolling out to all users, so the
gustoNewDotbeta flag no longer gates anything. This PR removes every reference to it: theBETAS.GUSTOconstant, the OR-conditions on the workspace HR feature panel, the page-level beta blocks onWorkspaceHRPage,GustoApprovalModePage, andGustoFinalApproverPage, theSTATIC_HR_PROVIDERSentry'sbetafield for Gusto, and the corresponding unit test setup.betais now optional on the HR base page configs so Zenefits and Merge HR keep their gating.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/591910
PROPOSAL: N/A (internal cleanup; tracking issue is the Gusto rollout itself)
Tests
mainwith a non-beta account.Offline tests
Same as above with the network disabled — the HR card and Gusto pages remain visible (no extra network call introduced).
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.