[No QA] Update VAT-IT.md#91909
Conversation
updating references from "Global VaTax" to "VAT IT"
|
A preview of your ExpensifyHelp changes have been deployed to https://1bc64085.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR corrects the product name from "Global VaTax" to "VAT IT" in three places within the VAT IT integration article. The change is a straightforward terminology fix that brings the article into consistency -- the file title, YAML metadata, and several other references already used "VAT IT," while three instances still used the old "Global VaTax" name. Scores Summary
Key Findings
Recommendations
Files Reviewed
This review assessed only the proposed changes in the diff, not pre-existing content. |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
| # How VAT Refunds Work | ||
|
|
||
| VAT refund regulations vary by country and expense type, making the process complex. Global VaTax simplifies this by handling: | ||
| VAT refund regulations vary by country and expense type, making the process complex. VAT IT simplifies this by handling: |
There was a problem hiding this comment.
Pre-existing structural issue (not introduced by this PR): The heading above this line (# How VAT Refunds Work, line 28) uses a # heading, but per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading is allowed per article (the article title), plus an optional # FAQ. All content sections must use ##. This file has four # content headings that should be demoted to ##.
Additionally, several headings in this file are not task-based (e.g., "VAT-Recoverable Expenses", "Tracking Your VAT Reclaim") — headings must start with an action verb or question word per Section 2.
The naming fix on this line is correct. Consider addressing the structural issues in a follow-up.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a straightforward terminology correction, replacing three instances of "Global VaTax" with "VAT IT" in the VAT IT integration article. The change ensures the partner name is consistent throughout the document, matching the article title and other existing references that already used "VAT IT." Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on governance rules in docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. |
|
very simple update, no QA needed |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.89-1 🚀
Bundle Size Analysis (Sentry): |
updating references from "Global VaTax" to "VAT IT"
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari