[hold] [No QA] Docs updates for E/A#92009 document spend rule step in card issuing#92316
[hold] [No QA] Docs updates for E/A#92009 document spend rule step in card issuing#92316MelvinBot wants to merge 1 commit into
Conversation
…ng flow Adds the Set card rules step (Add spend rule, Copy existing / Create new, Allow/Block restrictions) and the Restrictions confirmation summary to the issue card flow in Set Up and Manage the Expensify Card. Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://03e21327.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
Bot
requested review from
brianlee-expensify
and removed request for
a team
|
@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Agree the docs look fine, but this is currently locked behind staging, so lets not ship these docs yet |
JS00001
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d78d921778
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - To restrict where and how the card can be used, toggle **Add spend rule** on, then choose: | ||
| - **Copy existing**: Reuse an existing spend rule. Click **Choose a rule** and select one from the list. | ||
| - **Create new**: Build a new rule. Set the restriction type to **Allow** or **Block**, then add any combination of **Merchant**, **Spend category**, and **Max amount**. |
There was a problem hiding this comment.
For production users, this spend-rule control is not shown even when workspace Rules is enabled; I checked SetSpendRulesStep and the UI is gated by !isProduction && isPolicyFeatureEnabled(...). Publishing these steps in the help article will send admins looking for an Add spend rule toggle they cannot access until the feature ships, so this section should be gated/removed from the live docs or explicitly held until production rollout.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR updates Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Review is based solely on the proposed diff, not unchanged portions of the file. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 7. On the **Set card rules** step, apply a spend rule and set an expiration date: | ||
| - To restrict where and how the card can be used, toggle **Add spend rule** on, then choose: | ||
| - **Copy existing**: Reuse an existing spend rule. Click **Choose a rule** and select one from the list. | ||
| - **Create new**: Build a new rule. Set the restriction type to **Allow** or **Block**, then add any combination of **Merchant**, **Spend category**, and **Max amount**. |
There was a problem hiding this comment.
Readability / structure: This triple-nested bullet packs three distinct actions into one line (set restriction type, choose Allow/Block, add Merchant/Spend category/Max amount). Per Section 5 of HELP_AUTHORING_GUIDELINES.md, step instructions must be clear and action-oriented. Consider breaking this into separate sub-bullets:
| - **Create new**: Build a new rule. Set the restriction type to **Allow** or **Block**, then add any combination of **Merchant**, **Spend category**, and **Max amount**. | |
| - **Create new**: Build a new rule. | |
| 1. Set the restriction type to **Allow** or **Block**. | |
| 2. Add any combination of **Merchant**, **Spend category**, and **Max amount**. |
| - **When disabled:** The card does not expire automatically. | ||
| 8. Name the card for easier tracking | ||
| 9. Click **Issue card** to confirm | ||
| 9. On the confirmation screen, review the details — including the **Restrictions** summary if you applied a spend rule — then click **Issue card** to confirm |
There was a problem hiding this comment.
Readability / structure: This step combines a review action and a confirm action into one long sentence with an em-dash parenthetical, which hurts scannability. Per Section 5 of HELP_AUTHORING_GUIDELINES.md, steps must be clear and action-oriented. Consider splitting into two steps:
9. On the confirmation screen, review the details. If you applied a spend rule, verify the **Restrictions** summary.
10. Click **Issue card** to confirm.
|
|
||
| ## Can I restrict where an Expensify Card can be used when I issue it? | ||
|
|
||
| Yes. When **Rules** is enabled for the workspace, the **Set card rules** step lets you toggle **Add spend rule** on and either **Copy existing** to reuse an existing spend rule or **Create new** to build one. A spend rule can **Allow** or **Block** spend based on **Merchant**, **Spend category**, and **Max amount**. Any restrictions you apply appear under **Restrictions** on the confirmation screen before you click **Issue card**. |
There was a problem hiding this comment.
Readability / structure: This FAQ answer is a single dense sentence that covers multiple concepts (enabling Rules, toggling Add spend rule, Copy existing vs. Create new, Allow/Block, three field types, and the confirmation screen). For scannability, consider restructuring as a short intro sentence followed by a bullet list summarizing the key options, similar to how the procedural steps above break this down.
|
Im actually handling docs as a whole for this project, in this PR: #92580 Gonna close this one, and will merge the suggested changes here into the other PR! |
4 participants
Explanation of Change
Expensify/App#92009 fixes deploy blockers for applying a spend rule when issuing an Expensify Card, including showing a Restrictions summary on the confirmation screen. This help-site update documents that step in the issue card flow in
Set-Up-and-Manage-the-Expensify-Card.md:All feature, tab, and button names were verified against
src/languages/en.tsfor exact casing.Important
The spend rule step in the issue card flow is currently gated to non-production environments (it is hidden when the app is running in production). These docs describe behavior that is not yet live in production, so please keep this PR in draft and publish it only once the feature ships to production.
Related
@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.