[No QA] [Hold for feature] Update help docs for Releases 1-4: Expensify Card Spend Rules#92580
[No QA] [Hold for feature] Update help docs for Releases 1-4: Expensify Card Spend Rules#92580MelvinBot wants to merge 5 commits into
Conversation
Add a new Spend Rules article covering default protections, Block rules, Allow rules, evaluation order, rule management, and search. Cross-reference Spend Rules from the card setup, cardholder, troubleshooting, and notifications articles. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
stephanieelliott
changed the title
|
Copy is good, just need to test the UI steps to confirm they're right - will just before release when it is on staging. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| --- | ||
|
|
||
| # View Spend Rules on Your Card |
There was a problem hiding this comment.
Structure violation: Articles must have exactly one # heading (the article title), plus an optional # FAQ. This adds a second #-level heading. Demote to ## View Spend Rules on your card or ## How to view Spend Rules on your Expensify Card.
Per HELP_AUTHORING_GUIDELINES.md Section 4: "Exactly one # heading (the article title). No other # headings are allowed except # FAQ."
| 5. Customize your alert style based on your preferences. | ||
|
|
||
| See this guide for more information on [setting up Expensify Card notifications](https://help.expensify.com/articles/new-expensify/expensify-card/Expensify-Card-Notifications). | ||
| [Learn hpw to set up Expensify Card notifications](/articles/new-expensify/expensify-card/Expensify-Card-Notifications). |
There was a problem hiding this comment.
Typo: "hpw" should be "how".
| [Learn hpw to set up Expensify Card notifications](/articles/new-expensify/expensify-card/Expensify-Card-Notifications). | |
| [Learn how to set up Expensify Card notifications](/articles/new-expensify/expensify-card/Expensify-Card-Notifications). |
| - **Incorrect details**: Double-check the CVC, ZIP code, and expiration date. | ||
| - **Suspicious activity**: You may need to manually approve flagged transactions from your Home page. | ||
| - **Restricted country**: Transactions are blocked in specific regions due to US sanctions. | ||
| - **Spend Rule restriction**: Your workspace admin may have set a Spend Rule on your card that blocks certain merchants, spend categories, or amounts. When a Spend Rule declines a transaction, you'll receive a notification from Concierge in your workspace chat explaining the reason. [Learn about Expensify Card Spend Rules](https://help.expensify.com/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules). |
There was a problem hiding this comment.
Link formatting violation: Use relative links only. Do not use full URLs.
Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting): "Use relative links only. Do not use full URLs."
| - **Spend Rule restriction**: Your workspace admin may have set a Spend Rule on your card that blocks certain merchants, spend categories, or amounts. When a Spend Rule declines a transaction, you'll receive a notification from Concierge in your workspace chat explaining the reason. [Learn about Expensify Card Spend Rules](https://help.expensify.com/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules). | |
| - **Spend Rule restriction**: Your workspace admin may have set a Spend Rule on your card that blocks certain merchants, spend categories, or amounts. When a Spend Rule declines a transaction, you'll receive a notification from Concierge in your workspace chat explaining the reason. [Learn about Expensify Card Spend Rules](/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules). |
|
|
||
| Once both settings are enabled, you'll start receiving instant updates for your Expensify Card activity. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Structure violation: Articles must have exactly one # heading (the article title), plus an optional # FAQ. This file already uses # headings for sections. Demote this to ## — e.g., ## How to understand Spend Rule decline notifications.
Also, as a ## heading, it must be task-based per HELP_AUTHORING_GUIDELINES.md Section 2 (start with an action verb or question word).
| internalScope: Audience is Workspace Admins. Covers creating and managing Expensify Card Spend Rules and understanding default protections. Does not cover post-submission expense rules, card limits, or cardholder-side card management. | ||
| --- | ||
|
|
||
| # Expensify Card Spend Rules |
There was a problem hiding this comment.
Structure violation: This article uses multiple #-level headings throughout (lines 8, 15, 22, 57, 79, 95, 108, 122, 132, 140, 150). Per HELP_AUTHORING_GUIDELINES.md Section 4, articles must have "Exactly one # heading (the article title). No other # headings are allowed except # FAQ."
Only this line (the article title) and # FAQ (line 150) should be #. All other # headings in this file should be demoted to ##.
|
|
||
| When you create a Spend Rule, it is applied in addition to these default protections rather than replacing them. | ||
|
|
||
| - Default protections apply to all Expensify Cards. |
There was a problem hiding this comment.
Typo: Double period at end of sentence ("..").
| - Default protections apply to all Expensify Cards. | |
| These protections act as baseline rules for all cards and are evaluated before any Spend Rule. |
| 3. If no rule declines the transaction, the transaction is approved. | ||
|
|
||
| Cards without an admin-defined Spend Rule are governed only by default protections and any applicable card limits. | ||
|
|
There was a problem hiding this comment.
Typo: Double period at end of line ("..").
| - In **Allow mode**, a transaction is approved only when it matches an allowed merchant or spend category and remains within the maximum amount. |
| Examples include: | ||
|
|
||
| - Restricting subscription services | ||
| - Blocking specific a merchant |
There was a problem hiding this comment.
Grammar issue: "Blocking specific a merchant" should be "Blocking a specific merchant".
| - Blocking specific a merchant | |
| - Blocking a specific merchant |
|
|
||
| --- | ||
|
|
||
| ## How to edit or delete an Expensify Card Spend Rule |
There was a problem hiding this comment.
Formatting: Missing period at end of step instruction.
| ## How to edit or delete an Expensify Card Spend Rule | |
| 2. On the **Set card rules** step, enable **Add a spend rule**. |
| 8. Name the card for easier tracking | ||
| 9. Click **Issue card** to confirm | ||
|
|
||
| When issuing a card, you can also apply an existing Spend Rule or create a new one so the card has real-time spending controls from its first use. To learn more, [learn how to set up Expensify Card Spend Rules](/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules). |
There was a problem hiding this comment.
Cross-linking violation: Links should not be placed inside or immediately after numbered step instructions. Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting): "Do not place links inside numbered step instructions. Do not interrupt procedural flow with inline links."
Move this link to after the procedural block or into a separate explanatory paragraph with a clear break from the steps.
|
|
||
| Workspace Admins can check the available limit by going to **Workspaces > [Workspace Name] > Expensify Card**. From there, Workspace Admins can view the current balance, remaining limit, and any warnings related to settlement. | ||
|
|
||
| ## Transaction declined by a Spend Rule |
There was a problem hiding this comment.
Heading violation: ## Transaction declined by a Spend Rule is a noun-phrase heading, not task-based. Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must start with an action verb or question word (How, What, Where, Who, Why, When).
Suggested fix: ## What to do when a Spend Rule declines your transaction
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a well-structured new article for Expensify Card Spend Rules and adds cross-references to four existing card articles. The new article covers a clear single workflow (admin Spend Rule management) and follows governance structure closely. There are several issues that should be addressed before merge, including a typo, heading compliance gaps, a full URL that should be relative, and minor formatting errors. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes (diff), not unchanged portions of the files. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d012537df9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # View Spend Rules on Your Card | ||
|
|
||
| Your workspace admin may set a Spend Rule on your card that approves or declines transactions in real time based on the merchant, spend category, or amount. You can view the rule on your card, but only your admin can change it. |
There was a problem hiding this comment.
In the current wallet card details implementation, the Spend Rules summary is only rendered when isWorkspaceAdmin is true (shouldShowSpendRulesSummary = !isProduction && isWorkspaceAdmin && ...), so regular cardholders who follow this new section will not see the rule summary described here. Unless the product change also exposes this row to cardholders, this cardholder-facing article should avoid saying they can view the rule on their card.
Useful? React with 👍 / 👎.
stephanieelliott
added
the
HelpDot
3 participants
Explanation of Change
This PR adds the help site documentation for the Expensify Card Spend Rules feature, consolidating the resource updates for all four releases (Releases 1–4) into a single set of article changes.
Spend Rules let Workspace Admins approve or decline Expensify Card transactions in real time at the point of sale, before any expense is created. Because the feature is conceptually distinct from both card setup (limits/issuance) and post-submission expense rules, it gets a dedicated article, with light cross-references added to the existing card articles for discoverability.
New article
docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md— covers default protections, Block rules, Allow rules, evaluation order, editing/deleting rules, applying a rule at card issuance, and the search filter (admin workflow).Updated articles
Set-Up-and-Manage-the-Expensify-Card.md— notes that a Spend Rule can be applied when issuing a card, and that default protections + Spend Rules exist, with a link to the new article.Cardholder-Settings-and-Features.md— adds a "View Spend Rules on Your Card" section and adds Spend Rule restrictions (with Concierge decline notifications) as a decline reason.Troubleshoot-Expensify-Card-issues.md— adds a "Transaction declined by a Spend Rule" troubleshooting subsection.Expensify-Card-Notifications.md— documents the Concierge notification a cardholder receives when a Spend Rule declines a transaction.Note
This feature is being built across Releases 1–4 and the docs describe its end state. UI labels (e.g., the Spend section, Add card rule, Contains/Exact match, the Workspace > Rules and Wallet > Card Details entry points) are taken from the design doc and should be verified against the shipped product before merge.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/641928
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate the help docs render correctly and the content is accurate.
Offline tests
N/A — help site documentation change only.
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review", or add "[No QA]" to the title if appropriate for a docs-only change.