[cp staging] Fix workspace blockers#92366
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ZhenjaHorbach sorry for the bump, I'm reviewing the PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51dfb7ef97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| maintainVisibleContentPosition={{disabled: true}} | ||
| ListEmptyComponent={isEmptyResult ? EmptyResultComponent : ListEmptyComponent} | ||
| contentContainerStyle={[filteredAndSortedData.length === 0 && styles.flex1, listContentContainerStyle, tableBodyContentContainerStyle, contentContainerStyle]} | ||
| contentContainerStyle={[filteredAndSortedData.length === 0 && styles.flexGrow1, listContentContainerStyle, tableBodyContentContainerStyle, contentContainerStyle]} |
There was a problem hiding this comment.
Avoid unsupported FlashList content styles
When a workspace/domain table is empty, this still passes flexGrow through contentContainerStyle. The app uses @shopify/flash-list 2.3.0, whose ContentStyle only includes padding and backgroundColor fields, so flexGrow is unsupported/ignored and can still produce the console warning this change is trying to remove. Use a supported prop such as ListEmptyComponentStyle or wrap the empty state instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think the claim is incorrect.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariandorid_1.mp4andorid_2.mp4 |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…ockers [cp staging] Fix workspace blockers (cherry picked from commit c09467e) (cherry-picked to staging by lakchote)
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.91-4 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no documentation changes required. I reviewed the changes in this PR against the help site articles under Why: All three changes are purely visual/layout bug fixes with no impact on documented behavior, feature names, settings, buttons, or workflows:
The help site documents what features do and how to use them — not pixel-level layout or CSS. These fixes restore expected visual behavior (scrollability, indicator placement, illustration sizing) without introducing, removing, or renaming any feature, setting, tab, or button. There is nothing for a help article to describe differently as a result of this PR. Since no changes are required, I did not create a docs draft PR. |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.94-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: No changes are required to the help site files under Why: This PR is a set of purely cosmetic/layout bug fixes. It changes no feature behavior, workflow, setting label, tab name, or button — nothing that the help site documents. What the PR actually changesThe PR fixes two layout blockers on the Workspaces/Domains screens (#92353, #92358):
These are styling/layout adjustments (scroll behavior, safe-area padding, an illustration's pixel height). They don't introduce, rename, or change how any documented feature works, so there's nothing to update in the help articles. No draft help site PR was created since no documentation changes are warranted. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.94-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.97-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no documentation changes required. I reviewed the changes in this PR against the help site articles under What the changes doThe PR fixes two layout blockers on the Workspaces/Domains screens (issues
All three are rendering/layout adjustments (scrollability, illustration height, safe-area padding). None introduce, rename, or alter a feature, tab, setting, or button that the help site documents. The help articles describe how to use Domains/Workspaces, not pixel-level layout behavior, so no draft docs PR was created. |
Explanation of Change
Fixes blockers with the workspaces/domains table
Fixed Issues
$ #92353
$ #92358
Tests
Test each of the issues above to ensure they are fixed
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari