[Payment due @dmkt9] Allow manual reimbursement workspaces to set and use a preferred payer#92787
Conversation
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bac69bd50
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Let's have a C+ review this too, I'll ask in the room |
d71ac35 to
3768f72
Compare
|
conflicts resolved! This oxfmt check failing appears to be due to a style change, applied the fix in a single comment, so it's easy to review |
|
@mjasikowski once more please 🙇 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.29-0 🚀
|
📝 Help site review — changes requiredThis PR lets manual/indirect payment ( The existing help article Draft PR: #95525 What the docs PR changesUpdated
UI labels verified against the current App UI / language files, following @NikkiWines, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #95535 was identified to be related to this PR. |
|
Deploy Blocker #95561 was identified to be related to this PR. |
|
Deploy Blocker #95626 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.31-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #95678 |
Explanation of Change
Updates the UI so that manual/indirect payment workspaces (
reimburseManual) can now use a preferred payer, the same way direct payment workspaces (reimburseYes) already could.Fixed Issues
$ Part 2 of 2 for https://github.com/Expensify/Expensify/issues/637864
PROPOSAL: N/A internal
Tests
Setup
Test 1: Payer picker in manual mode
Test 2: Only the designated payer sees Pay GBR
Paybutton next to the workspace chatPaybutton next to the workspace chat(Payer left, Non-Payer right)

Waiting for you to pay expenses.and the option to pay the reportWaiting for <Admin B> to pay expenses.and confirm they do see the option to pay the report(Payer left, Non-Payer right)

Test 3: Home Action Items
For younotifying you to pay the reportFor youto pay the report(Payer left, Non-Payer right)

Test 4: Spend Page Action Items
Ready to Paynotifying you to pay the reportReady to payto pay the report(Payer left, Non-Payer right)

Test 5: Switching payers with bank account requires sharing
Offline tests
Offline behaviors are unchanged from current behaviors
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-06-17.at.18.30.07.mov