Skip to content

[No QA] Docs updates for E/A#93751 sentence-case agent rules naming - #93869

Open
MelvinBot wants to merge 2 commits into
mainfrom
melvin-docs-agent-rules-copy
Open

[No QA] Docs updates for E/A#93751 sentence-case agent rules naming#93869
MelvinBot wants to merge 2 commits into
mainfrom
melvin-docs-agent-rules-copy

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Help site updates triggered by #93751, which revised the in-app Agent rules titles, subtitles, and button copy in NewDot.

This PR aligns the help articles with the updated UI labels per docs/HELPSITE_NAMING_CONVENTIONS.md ("use the exact text shown in the product UI" / "match capitalization exactly"):

  • Sentence-cased the feature name: Agent RulesAgent rules and Agent Ruleagent rule, matching the new UI title (Agent rules) and the lowercase mid-phrase usage in Add agent rule / Find agent rule.
  • Fixed the create-rule button reference from Add AI Rule to the actual UI label Add agent rule.
  • Replaced remaining AI rule / AI Rule terminology with agent rule.

Files changed

  • docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md
  • docs/articles/new-expensify/ai-agents/How-to-Write-Agent-Rules.md
  • docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md
  • docs/articles/new-expensify/workspaces/Workspace-Rules.md

Labels verified against the merged src/languages/en.ts strings from #93751 (title: 'Agent rules', addRule: 'Add agent rule', findRule: 'Find agent rule').


@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Sentence-case the "Agent rules" feature name and fix the button
reference to "Add agent rule" to match the updated NewDot UI labels
from #93751.

Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 17, 2026
@MelvinBot MelvinBot self-assigned this Jun 17, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#93751 sentence-case agent rules naming [No QA] Docs updates for E/A#93751 sentence-case agent rules naming Jun 17, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review June 22, 2026 18:51
@stephanieelliott
stephanieelliott self-requested a review as a code owner June 22, 2026 18:51
@OSBotify

Copy link
Copy Markdown
Contributor

Comment thread docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md
Comment thread docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a focused terminology/casing alignment triggered by #93751. It sentence-cases the feature name (Agent RulesAgent rules / agent rule), corrects the create-rule button reference (Add AI RuleAdd agent rule), and replaces leftover AI rule / AI Rule terminology with agent rule across four articles. The changes are well-scoped, consistent with the merged en.ts UI strings, and align the docs with the governance rule to "use the exact text shown in the product UI" and "match capitalization exactly."

Scores Summary

  • Readability: 9/10 - No structural or prose changes; substitutions read naturally and step formatting is preserved.
  • AI Readiness: 8/10 - Headings remain task-based with full feature names, and internalScope metadata was updated consistently. Minor deduction for a frontmatter title vs. H1 casing mismatch introduced in Create-Agent-Rules.md.
  • Style Compliance: 9/10 - Strong adherence to UI-exact terminology. The button label fix and bolding of Add agent rule are correct. Same minor title/H1 inconsistency keeps this from a perfect score.

Key Findings

  • Positive: Casing is now consistent with the real UI labels (title: 'Agent rules', addRule: 'Add agent rule', findRule: 'Find agent rule'), and mid-phrase lowercase usage (agent rule) is applied uniformly across body copy, headings, FAQ, and cross-links.
  • Positive: The Add AI RuleAdd agent rule correction fixes a real UI mismatch and properly bolds the button per the Button Naming Standards.
  • Positive: Cross-link anchor text was updated in lockstep (e.g., "learn how to create agent rules"), preserving descriptive, search-aligned anchors.
  • Issue (minor): In Create-Agent-Rules.md, the H1 was changed to # Create agent rules but the frontmatter title: Create Agent Rules was left in title case. TEMPLATE.md requires the H1 to match the article title exactly. How-to-Write-Agent-Rules.md correctly updated both — apply the same to this file (and confirm the intended convention for these title: fields).
  • Note (out of scope): The diff context near ## How to create an agent rule in Create-Agent-Rules.md shows a stray/duplicated navigation step that predates this PR. Not introduced here, so not scored — but worth a follow-up cleanup.

Recommendations

  • Align the frontmatter title and H1 in Create-Agent-Rules.md (either both sentence case or both title case) to satisfy the title/H1 match rule and keep the two AI-agents articles consistent with each other.
  • Confirm the desired casing convention for title: fields across the AI-agents hub so future articles stay uniform.

Files Reviewed

  • docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md - Approved with one minor title/H1 casing mismatch to fix.
  • docs/articles/new-expensify/ai-agents/How-to-Write-Agent-Rules.md - Approved; title and H1 both updated consistently.
  • docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md - Approved; body and cross-link references updated correctly.
  • docs/articles/new-expensify/workspaces/Workspace-Rules.md - Approved; cross-link and inline references updated correctly.

Note: Detailed line-by-line feedback has been provided as inline comments.

Comment thread docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md
@stephanieelliott
stephanieelliott requested a review from a team June 22, 2026 19:00
@melvin-bot

melvin-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot
melvin-bot Bot requested review from jliexpensify and removed request for a team June 22, 2026 19:00
@melvin-bot

melvin-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jliexpensify jliexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants