Fix: Circle icon showing behind back button on workspace pages in landscape mode by samranahm · Pull Request #94218 · Expensify/App

samranahm · 2026-06-22T21:40:17Z

Explanation of Change

On native, split navigator central screens and their header/list areas are transparent, so the workspace sidebar show through the back button on landscape mode in workspace pages after we move header buttons inline. This PR adds opaque appBG backgrounds to split navigator native screens, headerBar, and BaseSelectionList so the central pane fully covers the sidebar underneath.

Fixed Issues

$ #90374
PROPOSAL: #90374 (comment)

Tests

Open Expensify in landscape mode.
Navigate to the "Workspaces" tab.
Select a workspace and open following pages one by one
- Members
- Categories
- Taxes
- Company Cards
- Distance Rates
Verify that no circle icon is visible behind the Back button in the upper-left corner.

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.mp4

Android.Native.landscape.mp4

Android: mWeb Chrome

Android.mWeb.mp4

iOS: Native

IOS.Native.mp4

IOS.Native.landscape.mp4

iOS: mWeb Safari

IOS.mWeb.mp4

MacOS: Chrome / Safari

macOS.Chrome.mp4

…gator screens

…rent layering on native

melvin-bot · 2026-06-22T21:40:23Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2026-06-23T02:11:27Z

Videos looking good on my end 👍

github-actions · 2026-06-23T17:57:31Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

samranahm · 2026-07-01T00:36:43Z

@truph01 Gentle bump.

truph01 · 2026-07-01T03:10:14Z

@samranahm Could you merge main?

Copilot

Pull request overview

This PR addresses a native (landscape) workspace-settings UI layering issue where the split navigator’s central pane can be visually transparent, allowing the workspace sidebar (including a circular icon) to show behind the Back button. It does so by making key containers/screens explicitly render an opaque appBG background.

Changes:

Adds theme.appBG background to the headerBar style so the header area is no longer transparent.
Sets native split-navigator screen contentStyle to themeStyles.appBG so split navigator panes render opaquely on native.
Applies styles.appBG to BaseSelectionList container and list to prevent see-through areas in list-based workspace settings pages.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`src/styles/index.ts`	Makes `headerBar` opaque via `backgroundColor: theme.appBG`.
`src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts`	Sets native split navigator `contentStyle` to `appBG` for opaque split panes.
`src/components/SelectionList/BaseSelectionList.tsx`	Forces selection list containers/lists to use `appBG` to avoid transparency bleed-through.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-07-01T09:23:44Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ion/AppNavigator/useSplitNavigatorScreenOptions.ts	`100.00% <100.00%> (ø)`
src/styles/index.ts	`60.30% <ø> (ø)`
... and 536 files with indirect coverage changes

samranahm · 2026-07-01T09:37:52Z

Done.

truph01 · 2026-07-06T09:13:03Z

@samranahm Could you check all AI' comments above?

…dscape-mode

samranahm · 2026-07-06T11:51:55Z

@truph01 I added the comments, please take a look.

truph01 · 2026-07-09T10:25:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-07-09.at.17.20.44.mov

Screen.Recording.2026-07-09.at.17.22.18.mov

Screen.Recording.2026-07-09.at.17.22.50.mov

Screen.Recording.2026-07-09.at.17.23.31.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

truph01 · 2026-07-09T10:29:53Z


    return (
-        <View style={[styles.flex1, addBottomSafeAreaPadding && !hasFooter && paddingBottomStyle, style?.containerStyle]}>
+        <View style={[styles.flex1, styles.appBG, addBottomSafeAreaPadding && !hasFooter && paddingBottomStyle, style?.containerStyle]}>


appBG on BaseSelectionList may be redundant with the screen-level fix

The contentStyle: themeStyles.appBG on native screen options already gives every screen a solid background. Adding appBG directly to the selection list container and scroll view extends the change to all ~343 consumers, including web where this bug doesn't occur, and would need overriding if a future caller expects a different background (e.g. inside a highlightBG bottom sheet). Could you confirm whether the contentStyle fix alone resolves the issue?

@truph01 Yes, after removing appBG change from BaseSelectionList, the circle didn't appear on any page. I'll remove these changes and keep only the contentStyle and headerBar fix.

mountiny

Lets give it a go

OSBotify · 2026-07-10T05:27:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-10T05:30:26Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-10T05:38:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94218.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-88a0e4adb85-aa76580-671fc1a80dee71e301dbf1f1b1c36f338be7ffd6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-88a0e4a-aa76580-13162d9fcb35b0ead3337c4373f61c8541f819bf/index.html

Web 🕸️
https://94218.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:17:47Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:20:48Z

🤖 I reviewed the changes in this PR against Expensify's help site content under App/docs/articles.

No help site changes are required.

This PR is a purely visual/rendering fix. It adds opaque appBG backgrounds to:

Split navigator native screens (useSplitNavigatorScreenOptions.ts)
The headerBar style (styles/index.ts)

so the workspace sidebar no longer shows through behind the Back button in landscape mode on native.

There is no change to feature behavior, user-facing workflows, settings labels, tab names, or button copy — nothing that the public help articles document. Help site articles cover how features work and how to use them, and a background-color/z-order fix has no documentable user-facing behavior change. Accordingly, I did not create a draft docs PR.

@samranahm, since no help site changes are needed here, there's no linked help site PR to review. If you believe there's a user-facing behavior change I missed that should be documented, let me know and I'll create the docs PR.

lanitochka17 · 2026-07-10T18:13:20Z

Deploy Blocker #95863 was identified to be related to this PR

samranahm added 2 commits June 23, 2026 02:13

Fix sidebar bleed-through by setting opaque backgrounds on split navi…

de550e8

…gator screens

Add solid appBG to headerBar and BaseSelectionList to prevent transpa…

3e89c1d

…rent layering on native

samranahm requested review from a team as code owners June 22, 2026 21:40

melvin-bot Bot assigned samranahm Jun 22, 2026

melvin-bot Bot requested review from trjExpensify and truph01 and removed request for a team June 22, 2026 21:40

melvin-bot Bot removed the request for review from a team June 22, 2026 21:40

samranahm mentioned this pull request Jun 22, 2026

[$250] iOS - Workspace - Circle icon is shown on top left of Members, Categories, Taxes, Distance rates #90374

Closed

7 tasks

This comment has been minimized.

Sign in to view

Merge branch 'Expensify:main' into 90374/circle-icon-in-landscape-mode

912b871

Copilot AI review requested due to automatic review settings July 1, 2026 09:17

Copilot started reviewing on behalf of samranahm July 1, 2026 09:17 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts

Comment thread src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts

Merge remote-tracking branch 'upstream' into 90374/circle-icon-in-lan…

871dc29

…dscape-mode

truph01 reviewed Jul 9, 2026

View reviewed changes

remove appBG from BaseSelectionList

fa4030b

samranahm requested a review from truph01 July 10, 2026 01:25

truph01 approved these changes Jul 10, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 10, 2026 02:51

mountiny approved these changes Jul 10, 2026

View reviewed changes

mountiny merged commit 88a0e4a into Expensify:main Jul 10, 2026
36 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

82 tasks

applause-bot Bot mentioned this pull request Jul 10, 2026

Public room - Login RHP header is white when opened from public room #95863

Closed

7 tasks

jasperhuangg mentioned this pull request Jul 13, 2026

[CP Staging] Revert "Fix: Circle icon showing behind back button on workspace pages in landscape mode" #95999

Merged

Uh oh!

Conversation

samranahm commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

dubielzyk-expensify commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

This comment has been minimized.

samranahm commented Jul 1, 2026

Uh oh!

truph01 commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samranahm commented Jul 1, 2026

Uh oh!

truph01 commented Jul 6, 2026

Uh oh!

samranahm commented Jul 6, 2026

Uh oh!

truph01 commented Jul 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

samranahm Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

lanitochka17 commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

samranahm commented Jun 22, 2026 •

edited

Loading

codecov Bot commented Jul 1, 2026 •

edited by github-actions Bot

Loading