[No QA] Update help docs for Release 1: Date-based mileage rates#94257
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Content was drafted based on the design doc - will test this and take off hold once the feature hits staging. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Nice, thank you! Both look great to me.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| --- | ||
|
|
||
| # How Expensify Selects a Rate When Multiple Rates Exist |
There was a problem hiding this comment.
Structure violation (multiple # headings): Per HELP_AUTHORING_GUIDELINES.md Section 4, an article may have exactly one # heading (the title), plus an optional # FAQ — no other # headings. This adds a second # section heading. Demote it to ## (e.g. ## How Expensify selects a rate when multiple rates exist).
Heading case/task-based violation: Headings must use sentence case and be task-based. Use ## How Expensify selects a rate when multiple rates exist instead of Title Case.
HelpDot Documentation ReviewOverall AssessmentThis PR documents Release 1 of date-based mileage rates across two New Expensify articles: Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 665fa80d7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Correct typo in 'distance' and update heading format.
|
A preview of your ExpensifyHelp changes have been deployed to https://08b1de25.helpdot.pages.dev ⚡️ Updated articles: |
|
✅ All checks are now passing — the failure was transient and unrelated to this PR's changes. What happened: The only failing check was That's an environmental/network flake in the schema download step, not a problem with any file in the branch. Resolution: A subsequent commit on the branch ( |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.32-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site updates for Release 1: Date-based mileage rates of the Date-bound mileage rates project. Release 1 lets admins set optional start/end dates on distance rates so Expensify automatically applies the rate matching an expense's date, and flags a violation when a manually selected rate doesn't match.
This PR documents that behavior in the two relevant New Expensify help articles:
docs/articles/new-expensify/workspaces/Set-distance-rates.md(admin-facing)docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md(member-facing)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/639702
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This is a docs-only change. Please review the rendered help articles for accuracy against the current Expensify UI (exact field/label names, start/end date behavior, and violation wording).
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionmainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — documentation-only change.