perf: Stop amount field re-rendering on background Onyx writes by OlimpiaZurek · Pull Request #94295 · Expensify/App

OlimpiaZurek · 2026-06-23T10:53:08Z

Explanation of Change

This PR moves the submit-only subscriptions into a new renderless component, AmountSubmitDataSync. It owns those subscriptions and writes the latest values into a ref that the screen's submit handler reads at click time. The form no longer subscribes to the noisy keys, so background writes don't ripple through the input while the user is typing.

Results from profiling:
Total render duration: 128.6ms -> 96.6ms (-24.9%)

Fixed Issues

$ #92411
PROPOSAL:

Tests

Open an existing expense.
Tap the amount.
Change it to a new value.
Tap Save.
Verify the amount updates in the report.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-06-23T10:58:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...rc/pages/iou/request/step/AmountSubmitDataSync.tsx	`100.00% <100.00%> (ø)`
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	`84.04% <80.00%> (-2.50%)`	⬇️
src/libs/IOUAmountSubmission.ts	`75.16% <0.00%> (ø)`
... and 22 files with indirect coverage changes

OlimpiaZurek · 2026-06-23T11:03:35Z

@codex

chatgpt-codex-connector · 2026-06-23T11:08:33Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 90fb681c1e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-24T10:48:22Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2026-06-24T19:13:11Z

No product review needed

OlimpiaZurek · 2026-06-26T13:16:51Z

@Pujan92 Can you review it when you have a chance? Thanks!

# Conflicts: # src/pages/iou/request/step/IOURequestStepAmount.tsx

Pujan92 · 2026-06-30T05:10:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-01.at.12.09.30.mov

Pujan92

Alternative approach of shifting from Onyx.ConnectWithoutView to renderless component looks good to me. I've suggested a minor change.

VickyStash · 2026-07-01T08:47:58Z

@OlimpiaZurek is out sick today, she will handle the feedback when she is back 🙏

tgolen

Thank you! This looks correct from an Onyx standpoint now 😍

Co-authored-by: Pujan Shah <shahpujan1992@gmail.com>

Resolves typecheck (Cannot find name 'Log'), ESLint (unsafe call/member access), and Prettier (missing semicolon) failures on the submit-data guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

elirangoshen · 2026-07-02T13:55:10Z

Hi can you check now please

Pujan92

LGTM!

cristipaval · 2026-07-03T09:16:08Z

@VickyStash @OlimpiaZurek could you please resolve conflicts? 🙏

OlimpiaZurek · 2026-07-03T09:32:58Z

could you please resolve conflicts?

I'm on it!

# Conflicts: # src/libs/IOUAmountSubmission.ts # src/pages/iou/request/step/IOURequestStepAmount.tsx # tests/unit/IOUAmountSubmissionTest.ts

OlimpiaZurek · 2026-07-03T10:46:44Z

Conflicts resolved

cristipaval

Thanks!

On you now, @Julesssss

# Conflicts: # src/pages/iou/request/step/IOURequestStepAmount.tsx

github-actions · 2026-07-06T19:37:45Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-06T20:10:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94295.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b327916ae75-163e75a-09c9c5b4ef34a5e22121d06788e6c9a4035d3ec2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b327916-163e75a-13b87723a63404f874decf6c092a99976786c786/index.html

Web 🕸️
https://94295.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-06T20:12:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-07T18:17:11Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.29-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-09T10:22:32Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.31-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T10:24:07Z

🤖 Help site review: no changes required

I reviewed the changes in this PR and no updates to Expensify's help site files under App/docs/articles are required — so I did not create a draft docs PR.

Why: This is a pure performance refactor with no user-facing change. It moves the submit-only Onyx subscriptions off the render path into a new renderless component (AmountSubmitDataSync) plus a helper module (IOUAmountSubmission.ts), so the amount input no longer re-renders on background Onyx writes. The end-to-end flow — open an expense, edit the amount, and Save — behaves exactly as before. No feature, UI label, tab, setting, or button was added or renamed, so there is nothing new to document or correct in the help site.

If you believe a specific help article is affected, let me know which one and I'll take another look.

OSBotify · 2026-07-09T10:42:34Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

perf: Stop amount field re-rendering on background Onyx writes

3c9849e

melvin-bot Bot assigned OlimpiaZurek Jun 23, 2026

fix spell check

90fb681

OlimpiaZurek mentioned this pull request Jun 23, 2026

[Due for payment 2026-07-16] [Refactor] Decompose IOURequestStepAmount and narrow its Onyx subscriptions #92411

Open

Remove connectWithoutView from AmountSubmission

1ab3ea1

OlimpiaZurek force-pushed the refactor/amount-submit-data-renderless branch from 2c221f0 to 1ab3ea1 Compare June 24, 2026 10:26

OlimpiaZurek marked this pull request as ready for review June 24, 2026 10:48

OlimpiaZurek requested review from a team as code owners June 24, 2026 10:48

melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team June 24, 2026 10:48

github-actions Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/AmountSubmitDataSync.tsx Outdated

github-actions Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/AmountSubmitDataSync.tsx

remove redundant useMemo and address rule linter feedback

761e340

OlimpiaZurek mentioned this pull request Jun 24, 2026

Refactor: cache submit-only collections in AmountSubmission #93814

Closed

52 tasks

cristipaval self-requested a review June 24, 2026 19:03

joekaufmanexpensify removed their request for review June 24, 2026 19:13

Julesssss self-requested a review June 25, 2026 00:55

Merge branch 'main' into refactor/amount-submit-data-renderless

e2b9202

OlimpiaZurek added 3 commits June 29, 2026 09:54

Merge branch 'main' into refactor/amount-submit-data-renderless

1c3e45a

# Conflicts: # src/pages/iou/request/step/IOURequestStepAmount.tsx

undo submodule

46e07df

Move AmountSubmission to src/libs and drop helper export

50e14f3

Julesssss requested a review from tgolen June 29, 2026 23:03

Pujan92 suggested changes Jul 1, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepAmount.tsx Outdated

tgolen previously approved these changes Jul 2, 2026

View reviewed changes

Update src/pages/iou/request/step/IOURequestStepAmount.tsx

5a336a7

Co-authored-by: Pujan Shah <shahpujan1992@gmail.com>

elirangoshen dismissed tgolen’s stale review via 5a336a7 July 2, 2026 10:37

fix: import Log and complete placeholder log in handleSubmit guard

dd83de2

Resolves typecheck (Cannot find name 'Log'), ESLint (unsafe call/member access), and Prettier (missing semicolon) failures on the submit-data guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pujan92 approved these changes Jul 2, 2026

View reviewed changes

OlimpiaZurek added 3 commits July 3, 2026 12:21

Merge branch 'main' into refactor/amount-submit-data-renderless

3461d01

# Conflicts: # src/libs/IOUAmountSubmission.ts # src/pages/iou/request/step/IOURequestStepAmount.tsx # tests/unit/IOUAmountSubmissionTest.ts

revert submodule

b645fab

fix oxfmt

71f3220

cristipaval previously approved these changes Jul 3, 2026

View reviewed changes

Merge branch 'main' into refactor/amount-submit-data-renderless

94a5bce

# Conflicts: # src/pages/iou/request/step/IOURequestStepAmount.tsx

OlimpiaZurek dismissed cristipaval’s stale review via 94a5bce July 6, 2026 14:29

Julesssss approved these changes Jul 6, 2026

View reviewed changes

Julesssss merged commit b327916 into Expensify:main Jul 6, 2026
35 checks passed

OSBotify mentioned this pull request Jul 7, 2026

Deploy Checklist: New Expensify 2026-07-07 #95520

Closed

77 tasks

This comment was marked as low quality.

Sign in to view

Uh oh!

Conversation

OlimpiaZurek commented Jun 23, 2026

Explanation of Change

Fixed Issues

Tests

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OlimpiaZurek commented Jun 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 23, 2026

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Jun 24, 2026

Uh oh!

OlimpiaZurek commented Jun 26, 2026

Uh oh!

Pujan92 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VickyStash commented Jul 1, 2026

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

elirangoshen commented Jul 2, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented Jul 3, 2026

Uh oh!

OlimpiaZurek commented Jul 3, 2026

Uh oh!

OlimpiaZurek commented Jul 3, 2026

Uh oh!

cristipaval left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

This comment was marked as low quality.

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov Bot commented Jun 23, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Jun 30, 2026 •

edited

Loading