Audit react-navigation patches: remove redundant emoji patch, fix stale docs by elirangoshen · Pull Request #94419 · Expensify/App

elirangoshen · 2026-06-24T07:18:38Z

Explanation of Change

This addresses the internal callstack audit callstack-internal/expensify-issues#2632 — "Verify and update react-navigation's patches". A react-navigation maintainer (Satya164) flagged several of our custom patches in patches/react-navigation/ as possibly outdated. We audited every patch against upstream react-navigation. This PR lands the low-risk cleanup only; the v8-dependent migrations are documented inline as follow-ups and are intentionally not done here.

Changes (2 files, +3/-30):

Removed @react-navigation+core+7.16.1+002+fix-crash-when-parsing-emoji.patch. The emoji crash fix (upstream react-navigation PR #12679) is already shipped in the installed @react-navigation/core@7.16.1. The local patch's "before" line was already the fixed code; all the patch actually did was strip the String() wrapper (Array.from(String(value)) → Array.from(value)), which is not the upstream fix and is a mild regression for non-string values. Removing it restores upstream's emoji-safe behavior on the next install.
patches/react-navigation/details.md:
- Removed the stale getStateFromPath.patch entry — that patch file was deleted back in June 2025; only the doc entry survived.
- Fixed the incorrect upstream link on the browser-history patch (@react-navigation+native+7.1.33+001+initial.patch). It pointed to PR Web -Chat - Error message displayed when sending message from corrupted accounts #11887 (which is actually the InteractionManager PR — a copy-paste error); now corrected to PR #12751 (route.history + pushParams, which Satya added upstream for this exact use case) plus the originating issue #12460.
- Annotated the native-stack InteractionManager patch: its Web -Chat - Error message displayed when sending message from corrupted accounts #11887 link is correct (that PR was closed/declined upstream, so we re-implement it); still required on v7 (runAfterInteractions is widely used); v8 removes InteractionManager support, so consumers will move to navigation.addListener('transitionEnd', ...).
- Annotated the dontDetachScreen patch with the v8 inactiveBehavior follow-up.

Follow-ups intentionally NOT in this PR (all require the React Navigation v8 upgrade, which is alpha-only and blocked on a react-native-screens rewrite):

Adopt pushParams to shrink the browser-history patch.
Migrate InteractionManager consumers to transitionEnd.
Replace dontDetachScreen with inactiveBehavior.

Fixed Issues

$#94997
PROPOSAL:

Tests

On a clean checkout of this branch, run npm install and verify patch-package applies the remaining react-navigation patches with no errors and without the removed emoji patch.
Verify patches/react-navigation/@react-navigation+core+7.16.1+002+fix-crash-when-parsing-emoji.patch no longer exists and is not referenced anywhere.
Open patches/react-navigation/details.md and verify: no getStateFromPath.patch entry; the browser-history patch links to PR Update version to 1.2.28-0 on main #12751 / issue Add errors object back to menu item, remove unused isPolicy #12460; the InteractionManager and dontDetachScreen entries carry the v8 follow-up annotations.
Smoke-test navigation (push/pop screens, deep links, browser back/forward on web) and confirm behavior is unchanged — this is a documentation + dead-patch removal change with no runtime behavior change on v7 (the emoji fix is already in the installed package).

Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior is affected. This PR only removes a redundant build-time patch and updates patch documentation; there is no runtime, network, or data-layer change.

QA Steps

Verify the emoji-parsing crash from #65709 has not regressed after removing the patch. The real fix is upstream in the installed @react-navigation/core@7.16.1 (it encodes each path segment per code point via Array.from, so emoji surrogate pairs are no longer split); the removed patch only stripped a redundant String() wrapper and did not provide the fix itself.

Open a workspace → More features → enable Taxes.
Open Taxes → a tax rate → Tax code.
Replace the tax code with an emoji (e.g. 👍) and save.
Expected: the app does not crash and navigation continues to work normally.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-24.at.15.30.53.mov

Screen.Recording.2026-06-24.at.15.32.23.mov

…le docs - Remove fix-crash-when-parsing-emoji patch (Expensify#12679 already in core@7.16.1; patch only stripped String() coercion, not the upstream fix) - Remove stale getStateFromPath entry from details.md (file deleted Jun 2025) - Fix wrong Expensify#11887 upstream link on browser-history patch -> Expensify#12751/Expensify#12460 - Document v8 follow-ups (transitionEnd, inactiveBehavior, pushParams) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-06-24T07:18:53Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…ify#71913 Removal is gated on migrating runAfterInteractions consumers to transitionEnd (works on v7 today), tracked in Expensify#71913 — v8 only forces it via the RN 0.82+ InteractionManager deprecation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

# Conflicts: # patches/react-navigation/details.md

melvin-bot · 2026-07-03T11:39:38Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-07-03T14:52:23Z

@elirangoshen is it ready for c+ review?

elirangoshen · 2026-07-03T15:26:23Z

@elirangoshen is it ready for c+ review?

Yes

FitseTLT · 2026-07-06T16:12:19Z

I think the QA steps should be exactly the steps in #65709 WDYT?

FitseTLT · 2026-07-06T17:00:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-07.20-01-29.mp4

Android: mWeb Chrome

2026-07-06.19-55-03.mp4

iOS: HybridApp

iOS: mWeb Safari

2026-07-06.19-58-28.mp4

MacOS: Chrome / Safari

2026-07-06.19-49-42.mp4

elirangoshen · 2026-07-07T11:50:03Z

I think the QA steps should be exactly the steps in #65709 WDYT?

done

FitseTLT

LGTM

Julesssss · 2026-07-07T20:32:24Z

Tests LGTM

github-actions · 2026-07-07T20:40:13Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-07T20:41:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-07T20:47:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94419.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://94419.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:05:14Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-10T13:42:17Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned elirangoshen Jun 24, 2026

elirangoshen and others added 2 commits June 26, 2026 12:58

Merge branch 'main' into fix/2632-rn-patch-cleanup

9cac562

# Conflicts: # patches/react-navigation/details.md

elirangoshen marked this pull request as ready for review July 3, 2026 11:39

elirangoshen requested a review from a team as a code owner July 3, 2026 11:39

melvin-bot Bot requested review from FitseTLT and removed request for a team July 3, 2026 11:39

FitseTLT approved these changes Jul 7, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss July 7, 2026 17:03

Julesssss approved these changes Jul 7, 2026

View reviewed changes

Julesssss merged commit 8c3485b into Expensify:main Jul 7, 2026
30 of 32 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] Audit react-navigation patches against upstream and remove stale ones #94997

Open

Uh oh!

Conversation

elirangoshen commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

FitseTLT commented Jul 3, 2026

Uh oh!

elirangoshen commented Jul 3, 2026

Uh oh!

FitseTLT commented Jul 6, 2026

Uh oh!

FitseTLT commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

elirangoshen commented Jul 7, 2026

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Jul 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elirangoshen commented Jun 24, 2026 •

edited

Loading

FitseTLT commented Jul 6, 2026 •

edited

Loading