Skip to content

[Workspace Roles] Lock approval toggle from backend signal instead of card data - #94518

Draft
ShridharGoel wants to merge 3 commits into
Expensify:mainfrom
ShridharGoel:shridhar-workflows-approval-lock-signal
Draft

[Workspace Roles] Lock approval toggle from backend signal instead of card data#94518
ShridharGoel wants to merge 3 commits into
Expensify:mainfrom
ShridharGoel:shridhar-workflows-approval-lock-signal

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

The Workspace Workflows page locks the "Add approvals" toggle while the workspace uses Smart Limit Expensify Cards. It derived that lock client-side from the workspace's Expensify Card list (isSmartLimitEnabled), which forced the backend to ship Expensify Card data to everyone who can open the page — including roles that can edit approvals but cannot read the Expensify Card feature (e.g. People admins). That exposed card data they should not see.

The backend now sends a single boolean, policy.areApprovalsLockedByExpensifyCard, and stops shipping card data to roles without Expensify Card read access (see the Auth PR). This PR consumes that boolean to lock the approval toggle and removes the Expensify Card reads the page previously used to derive the lock client-side. The Auth PR deploys first, so the boolean is always present by the time this ships.

Auth counterpart: https://github.com/Expensify/Auth/pull/22489

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/644795
PROPOSAL:

Tests

  1. Open a Control workspace where you are an admin. Go to More features and enable Workflows and Expensify Card.
  2. In Workflows, ensure Add approvals is enabled.
  3. Issue an Expensify Card to a member with a Smart Limit.
  4. Go to Workspace → Workflows and verify:
    • The Add approvals toggle is on and locked (it cannot be turned off).
    • The approvals subtitle shows the "you can't disable approvals while Smart Limit is on" prompt.
  5. Change the member's card limit type away from Smart Limit (or remove the card). Reopen Workflows and verify the Add approvals toggle is no longer locked.
  6. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

  1. With a Smart Limit card present, load the Workflows page while online so policy data is cached.
  2. Go offline and reopen Workspace → Workflows.
  3. Verify the Add approvals toggle still shows as locked (it reads the cached policy.areApprovalsLockedByExpensifyCard).

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ShridharGoel @claude
Consume areApprovalsLockedByExpensifyCard to lock the approval toggle
0a4a0fc 
The Workflows page derived the approval-toggle lock (isSmartLimitEnabled) from
the workspace Expensify Card list, which required shipping card data to roles
without Expensify Card access. Consume the backend
areApprovalsLockedByExpensifyCard boolean instead, falling back to the card-list
derivation for older payloads.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ShridharGoel @claude
Drop card-list fallback now that Auth sends the lock signal first
5246bac 
Auth deploys before App, so policy.areApprovalsLockedByExpensifyCard is always
present. Consume it directly and remove the now-dead Expensify Card reads
(useCardFeeds, workspace cards list) the Workflows page used for the old
client-side derivation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
flodnv
flodnv requested changes Jul 1, 2026
View reviewed changes
Comment thread src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Outdated
const isSmartLimitEnabled = isSmartLimitEnabledUtil(workspaceCards);
// The backend sends areApprovalsLockedByExpensifyCard so the approval toggle can lock without the page
// loading any Expensify Card data.
const isSmartLimitEnabled = policy?.areApprovalsLockedByExpensifyCard ?? false;

@flodnv flodnv Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the Policy in Onyx? This isn't actually stored in the Policy in the DB, so I don't think it should be on the Policy object in Onyx.

@ShridharGoel
Read approval-lock from its own onyx key, not the policy object
7df2d38 
Backend returns policyApprovalsLockedByExpensifyCard_<policyID> as a separate
onyx entry, so read it via useOnyx and drop the field from the Policy type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flodnv flodnv flodnv requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ShridharGoel ShridharGoel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShridharGoel @flodnv