Refactor money report header secondary actions to use dynamic verify account#94594
Conversation
|
@codex review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…-actions-to-use-dynamic-verify-account
…-actions-to-use-dynamic-verify-account
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product review not required.
…-actions-to-use-dynamic-verify-account
|
@aimane-chnaif kind bump |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@codex review |
|
🤖 Review: LGTM — clean, behavior-preserving refactor. No blocking issues found. This migrates the unvalidated-account redirect in
One minor thing worth a sanity check (non-blocking)The redirect ordering changed slightly. Previously the unvalidated check ran inside This matches the ordering already used in |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.28-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and no updates to the help site files under Why: This is a purely internal code refactor with no user-facing behavior change. It migrates What I checked
@jmusial, since no user-facing behavior changed, there's no linked help site PR to review. If you believe a doc update is warranted, let me know what behavior it should cover and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
4th out fo 4 PR that are originating from #90171. Depends on #94177
This PR migrates MoneyReportHeaderSecondaryActionsInner to use dynamic verify path and cleans up after the migration.
Fixed Issues
$ #72980
PROPOSAL:
Tests
Remove holdshould be primary action andPayshould be in secondary dropdownOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-25.at.16.08.08.mov
Android: mWeb Chrome
Screen.Recording.2026-06-25.at.16.13.10.mov
iOS: Native
Screen.Recording.2026-06-25.at.16.02.06.mov
iOS: mWeb Safari
Screen.Recording.2026-06-25.at.16.13.49.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-25.at.15.24.35.mov