Skip to content

[Copy Workspace Settings] Gate copy settings currency by bank account compatibility#94608

Merged
yuwenmemon merged 18 commits into
Expensify:mainfrom
fedirjh:fix/copy-settings-currency-ba
Jul 22, 2026
Merged

[Copy Workspace Settings] Gate copy settings currency by bank account compatibility#94608
yuwenmemon merged 18 commits into
Expensify:mainfrom
fedirjh:fix/copy-settings-currency-ba

Conversation

@fedirjh

@fedirjh fedirjh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR makes workspace currency a standalone copy-settings part instead of bundling it under Overview. The select-settings UI now:

  • Shows Currency only when the source and any selected target workspace have different currencies.
  • Force-selects Currency when Workflows would copy a bank account to a target with no bank account and a different currency.
  • Disables Currency with explanatory copy when a selected target has a connected bank account using a different currency.
  • Hides Overview when it has no address or description to copy.

This pairs with the Auth change that adds a dedicated currency CopyPolicySettings part.

Fixed Issues

$ #92397
$ https://github.com/Expensify/Expensify/issues/642646
PROPOSAL:

Tests

  1. Go to a workspace and start the Copy settings flow.
  2. Select a target workspace with the same currency as the source.
  3. Verify Currency is not shown in the settings list.
  4. Verify Overview is hidden when the source has no address or description.
Screenshot 2026-07-16 at 10 05 24 PM
  1. Select a target workspace with a different currency and no connected bank account.
  2. Verify Currency appears and can be selected.
Screenshot 2026-07-16 at 10 04 56 PM
  1. Select Workflows when the source has a connected bank account and the target has a different currency with no connected bank account.
  2. Verify Currency is selected/disabled along with Workflows.
Screenshot 2026-07-16 at 10 08 00 PM
  1. Select a target workspace with a connected bank account and a different currency.
  2. Verify Currency appears disabled with the bank-account compatibility message.
Screenshot 2026-07-16 at 10 17 01 PM
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

fedirjh added 4 commits June 25, 2026 18:34
Expose currency as its own copy-settings part so outputCurrency is no longer bundled under overview.
Centralize currency conflict checks and row visibility so the select-features page can gate currency and overview consistently.
Show currency only when targets have a currency conflict, force-select it with workflows when needed, and disable it when a target bank account blocks the change.
Cover currency conflict detection, bank-account blocking, workflow currency requirements, and visibility for the new currency part.
@fedirjh fedirjh changed the title Gate copy settings currency by bank account compatibility [Copy Workspace Settings] Gate copy settings currency by bank account compatibility Jun 25, 2026
@fedirjh fedirjh self-assigned this Jun 25, 2026
@melvin-bot

melvin-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@fedirjh fedirjh changed the title [Copy Workspace Settings] Gate copy settings currency by bank account compatibility [Hold Auth/22507][Copy Workspace Settings] Gate copy settings currency by bank account compatibility Jun 25, 2026
@fedirjh
fedirjh requested a review from shubham1206agra July 1, 2026 16:24
@dylanexpensify

Copy link
Copy Markdown
Contributor

@fedirjh this is unblocked now, right?

@fedirjh

fedirjh commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@dylanexpensify Pending prod deploy of Web-E PR:

@fedirjh fedirjh changed the title [Hold Auth/22507][Copy Workspace Settings] Gate copy settings currency by bank account compatibility [Copy Workspace Settings] Gate copy settings currency by bank account compatibility Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
src/libs/ReportActionsUtils.ts 77.90% <ø> (ø)
src/libs/ReportUtils.ts 86.19% <100.00%> (+0.03%) ⬆️
src/libs/actions/Policy/CopyPolicySettings.ts 77.41% <ø> (ø)
...x/report/actionContents/PolicyChangeLogContent.tsx 100.00% <ø> (ø)
src/libs/CopyPolicySettingsUtils.ts 90.78% <95.23%> (+0.63%) ⬆️
...ySettings/CopyPolicySettingsSelectFeaturesPage.tsx 71.69% <76.47%> (+0.26%) ⬆️
... and 12 files with indirect coverage changes

@fedirjh
fedirjh requested a review from ishpaul777 July 16, 2026 21:30
@fedirjh
fedirjh marked this pull request as ready for review July 16, 2026 21:31
@fedirjh
fedirjh requested review from a team as code owners July 16, 2026 21:31
@melvin-bot
melvin-bot Bot requested a review from yuwenmemon July 16, 2026 21:32
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team July 16, 2026 21:32
Comment thread src/libs/CopyPolicySettingsUtils.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4887a9d965

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@yuwenmemon

Copy link
Copy Markdown
Contributor

@ishpaul777 or @shubham1206agra can you take a first pass?

Comment thread src/libs/CopyPolicySettingsUtils.ts
@fedirjh
fedirjh requested a review from shubham1206agra July 21, 2026 12:14
@shubham1206agra

Copy link
Copy Markdown
Contributor
Screenshot 2026-07-21 at 9 44 42 PM

@fedirjh Please add custom renderer report action for copying currency.

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-21.at.10.14.51.PM.mov
Screen.Recording.2026-07-21.at.10.15.35.PM.mov
Screen.Recording.2026-07-21.at.9.42.57.PM.mov
Screen.Recording.2026-07-21.at.9.43.18.PM.mov

@yuwenmemon
yuwenmemon merged commit 07fdbd4 into Expensify:main Jul 22, 2026
36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.42-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under docs/articles and no updates are required. I did not create a draft PR.

Why

This PR modifies the Copy settings flow (copyPolicySettings, titled "Copy settings" in the UI) — the flow that copies settings to existing workspaces. The changes are:

  • Currency is now a standalone copy-settings part instead of being bundled under Overview (CopyPolicySettingsUtils.ts).
  • The Currency row is shown only when a selected target has a different currency, is force-selected when Workflows would copy a bank account to a target with a different currency, and is disabled with an explanatory message when a target has a connected bank account on a different currency.
  • Overview is hidden when there's no address or description to copy.

None of this maps to existing help content:

  1. The "Copy settings" (copy-to-existing) flow is not documented on the help site. A search of docs/articles for copy-settings / overwrite-existing-workspace content returns nothing, so there's no article to update for the new currency behavior or the bank-account compatibility gating.
  2. The one adjacent article, Duplicate-Workspace.md, documents a different flowDuplicate workspace, which creates a brand-new workspace. That flow uses a separate feature-selection form that this PR does not touch, and it never listed currency as a copyable setting. Because the new Currency row only appears when there's a currency conflict with an existing target, it never surfaces in the duplicate-to-new flow, so that article's settings list remains accurate.

The remaining changes (new POLICYCHANGELOG_COPY_CURRENCY report action + change-log copy) are internal/system-message behavior with no help-site surface.


@fedirjh, please confirm this assessment matches the intended behavior. If you'd like the "Copy settings" flow (or the new currency/bank-account gating) documented on the help site, let me know and I'll draft an article — but as it stands, none of the existing articles need changes for this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #96715 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants