[Copy Workspace Settings] Gate copy settings currency by bank account compatibility#94608
Conversation
Expose currency as its own copy-settings part so outputCurrency is no longer bundled under overview.
Centralize currency conflict checks and row visibility so the select-features page can gate currency and overview consistently.
Show currency only when targets have a currency conflict, force-select it with workflows when needed, and disable it when a target bank account blocks the change.
Cover currency conflict detection, bank-account blocking, workflow currency requirements, and visibility for the new currency part.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
…or currency handling
|
@fedirjh this is unblocked now, right? |
|
@dylanexpensify Pending prod deploy of Web-E PR: |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4887a9d965
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@ishpaul777 or @shubham1206agra can you take a first pass? |
@fedirjh Please add custom renderer report action for copying currency. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-21.at.10.14.51.PM.movScreen.Recording.2026-07-21.at.10.15.35.PM.movScreen.Recording.2026-07-21.at.9.42.57.PM.movScreen.Recording.2026-07-21.at.9.43.18.PM.mov |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.42-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site articles under WhyThis PR modifies the Copy settings flow (
None of this maps to existing help content:
The remaining changes (new @fedirjh, please confirm this assessment matches the intended behavior. If you'd like the "Copy settings" flow (or the new currency/bank-account gating) documented on the help site, let me know and I'll draft an article — but as it stands, none of the existing articles need changes for this PR. |
|
Deploy Blocker #96715 was identified to be related to this PR. |

Explanation of Change
This PR makes workspace currency a standalone copy-settings part instead of bundling it under Overview. The select-settings UI now:
This pairs with the Auth change that adds a dedicated
currencyCopyPolicySettings part.Fixed Issues
$ #92397
$ https://github.com/Expensify/Expensify/issues/642646
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari