83861 migrate workspace tags part 3

[huult]

Explanation of Change

Fixed Issues

$ #83861
PROPOSAL:

Tests

Same QA step

• Verify that no errors appear in the JS console

Offline tests

QA Steps

WORKSPACE_TAGS_IMPORT

1. Go to Workspace → Tags.
2. Click Import and select either multiple-level or single-level tags.
3. Verify that the import page opens and you can navigate back normally.

WORKSPACE_TAGS_IMPORTED

1. Workspace → Tags → Import spreadsheet → single-level import
2. Upload a CSV on the import screen
3. Verify that the imported page opens and you can navigate back normally.

WORKSPACE_TAG_LIST_VIEW

Precondition:
Workspace has tags, including imported multi-level tags.

1. Go to Workspace → Tags.
2. Select any tag.
3. Verify that the tag details page opens and you can navigate back normally.

SETTINGS_TAGS_SETTINGS

1. Go to Workspace → Tags.
2. Update the URL from the workspace route to the settings route. For example:
   https://dev.new.expensify.com:8082/workspaces/D56D50B841F69B0E/tags
   → https://dev.new.expensify.com:8082/settings/D56D50B841F69B0E/tags
3. Click More → Settings.
4. Verify that the Tag Settings page opens and you can navigate back normally.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-26.at.09.16.14.mov

[melvin-bot]

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/OldRoutes.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
src/pages/workspace/tags/WorkspaceEditTagsPage.tsx	0.00% <ø> (ø)
src/ROUTES.ts	21.26% <0.00%> (+1.42%)	⬆️
...orkspace/tags/ImportMultiLevelTagsSettingsPage.tsx	0.00% <0.00%> (ø)
...orkspace/tags/DynamicWorkspaceTagsSettingsPage.tsx	0.00% <0.00%> (ø)
...es/workspace/tags/DynamicWorkspaceViewTagsPage.tsx	0.00% <0.00%> (ø)
src/pages/workspace/tags/WorkspaceTagsPage.tsx	48.88% <0.00%> (-0.28%)	⬇️
... and 4 more
... and 163 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13c6d5cdba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[trjExpensify]

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

[suneox]

Manual test cases base on current code change

1. DYNAMIC_ROUTES.WORKSPACE_TAG_LIST_VIEW — multi-level tag list view (workspace flow)

---

Case 1.1 — Entry: tap tag list row from Workspace Tags (multi-level)

• Target: src/pages/workspace/tags/WorkspaceTagsPage.tsx:308 — PR: createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_TAG_LIST_VIEW.getRoute(orderWeight), ROUTES.WORKSPACE_TAGS.getRoute(policyID)) (!isQuickSettingsFlow + orderWeight !== undefined).

• Precondition: Admin workspace <W> with multi-level tags (isMultiLevelTags === true); on workspace Tags page (WORKSPACE.TAGS, isQuickSettingsFlow === false). UI shows tag list rows (list name, not a single tag).

  const policyID = "<W>";
  // Enable Tags feature + corporate admin → AccessOrNotFoundWrapper for Tags page
  Onyx.merge(`policy_${policyID}`, {
    areTagsEnabled: true,
    type: "corporate",
    role: "admin",
  });
  // CANNOT set via Onyx: multi-level tags structure (`policyTags_<W>`) is DERIVED from import/backend —
  // test account must already have multi-level tags (multi-level CSV import or staging setup).

• Steps:

  1. Open app → log in as admin.
  2. LHN → Workspaces → select workspace <W> (multi-level tags).
  3. Tap Tags → verify Tags page opens (URL /workspaces/<W>/tags).
  4. Tap one tag list row (multi-level list name with orderWeight).
  5. Verify View Tags page opens (child tags in that list).
  6. Verify URL = /workspaces/<W>/tags/workspace-tag-list/<orderWeight>.
  7. Tap Back (header) → verify return to Tags list /workspaces/<W>/tags (suffix workspace-tag-list/... removed).
  8. No console errors.

• Expected: Dynamic tag list view opens correctly; new URL shape is correct; Back strips suffix to tags root.

Case 1.2 — Back from Edit Tags (multi-level) reconstructs tag list view

• Target: src/pages/workspace/tags/WorkspaceEditTagsPage.tsx:61 — PR: createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_TAG_LIST_VIEW.getRoute(orderWeight), ROUTES.WORKSPACE_TAGS.getRoute(policyID)) (isMultiLevelTagsEnabled branch).

• Precondition: Workspace <W> with multi-level tags; on Edit Tags page (opened from tag list view or tags settings).

  const policyID = "<W>";
  Onyx.merge(`policy_${policyID}`, {
    areTagsEnabled: true,
    type: "corporate",
    role: "admin",
  });
  // DERIVED: isMultiLevelTagsEnabled from policyTags structure — real multi-level workspace required.

• Steps:

  1. Complete Case 1.1 → on tag list view.
  2. Open Edit (edit tag list name / settings per UI).
  3. Change value → tap Back or Save.
  4. Verify return to tag list view at /workspaces/<W>/tags/workspace-tag-list/<orderWeight>, not straight to tags root.

• Expected: Back reconstructs workspace-tag-list suffix on WORKSPACE_TAGS base.

Case 1.3 — Guard: quick-settings flow still uses `SETTINGS_TAG_LIST_VIEW` (unchanged)

• Target: src/pages/workspace/tags/WorkspaceTagsPage.tsx:308 — isQuickSettingsFlow branch unchanged (SETTINGS_TAG_LIST_VIEW).

• Precondition: Tags opened via quick-settings (SETTINGS_TAGS_ROOT, isQuickSettingsFlow === true).

  // Quick-settings Tags opened from money request / expense flow — no simple Onyx inject.
  // Need: create expense → Tags step → open full tags list (SETTINGS_TAGS_ROOT).

• Steps:

  1. Create/edit money request → open Tags quick-settings (/settings/<W>/tags).
  2. Tap one multi-level tag list row.
  3. Verify URL built on settings base (…/tags/tag-list/<orderWeight>), not /workspaces/<W>/tags/workspace-tag-list/....

• Expected: Ternary picks correct branch — workspace migration does not affect quick-settings.

Case 1.4 — Legacy redirect: `/workspaces/<W>/tag-list/<orderWeight>`

• Target: src/libs/Navigation/linkingConfig/OldRoutes.ts — '/workspaces/*/tag-list/*': '/workspaces/$1/tags/workspace-tag-list/$2'.

• Precondition: Logged in as admin on workspace <W> with multi-level tags; valid orderWeight (usually 0 for first list).

• Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W>/tag-list/0 → Enter.
  2. Verify redirect to /workspaces/<W>/tags/workspace-tag-list/0 and View Tags page renders.
  3. Paste …/tag-list/0?backTo=/home → verify redirect preserves query param.

• Expected: Old bookmark/deeplink still resolves correctly. ✅

Case 1.5 — Refresh / deeplink restore on new URL

• Precondition: On tag list view (URL /workspaces/<W>/tags/workspace-tag-list/<orderWeight>).

• Steps:

  1. Reload page (Web) / reopen app via same deeplink (Mobile).
  2. Verify View Tags page restores (no 404/home).
  3. Tap Back → land at /workspaces/<W>/tags.

• Expected: Refresh + deeplink on new URL restores stack correctly.

---

2. DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORT — import tags spreadsheet (workspace flow)

---

Case 2.1 — Entry: Tags → Import → single-level import

• Target: src/pages/workspace/tags/ImportTagsOptionsPage.tsx:198 — PR: Navigation.navigate(workspaceTagsImportPath) with createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORT.path, ROUTES.WORKSPACE_TAGS.getRoute(policyID)).

• Precondition: Admin workspace <W2>, Tags enabled, no accounting connection (Uber/QBO sync blocks import). isQuickSettingsFlow === false.

  const policyID = "<W2>";
  Onyx.merge(`policy_${policyID}`, {
    areTagsEnabled: true,
    type: "corporate",
    role: "admin",
  });
  // CANNOT set via Onyx: hasAccountingConnections — workspace must NOT have accounting connected
  // (if connected → ImportTagsPage renders NotFoundPage).

• Steps:

  1. Open app → log in → workspace <W2> → Tags.
  2. Tap More (⋯) → Import.
  3. On Import options, choose single-level tags import (upload spreadsheet).
  4. Verify Import Tags page opens (upload CSV UI).
  5. Verify URL = /workspaces/<W2>/tags/workspace-tags-import.
  6. Tap Back → verify return to Tags list /workspaces/<W2>/tags.

• Expected: Import page is dynamic; new URL; Back strips suffix.

Case 2.2 — Entry: Import options → multi-level path (confirm modal flow)

• Target: src/pages/workspace/tags/ImportTagsOptionsPage.tsx:170, :258 — same workspaceTagsImportPath.

• Precondition: Workspace <W2> with visible tags (to trigger confirm modal on override) or no tags yet.

• Steps:

  1. Workspace Tags → More → Import.
  2. Choose multi-level tags import (or flow with confirm modal before navigate).
  3. Confirm modal (if shown) → verify land on Import page.
  4. Verify URL = /workspaces/<W2>/tags/workspace-tags-import.

• Expected: All navigate paths in ImportTagsOptionsPage (confirm / clean / direct) use dynamic import URL.

Case 2.3 — Back from Multi-level import settings

• Target: src/pages/workspace/tags/ImportMultiLevelTagsSettingsPage.tsx:97 — PR: Navigation.goBack(backTo ?? workspaceImportPath).

• Precondition: On Import Multi-level Tags Settings (after uploading multi-level CSV on Import page).

• Steps:

  1. Follow Case 2.1 but choose multi-level import + upload CSV.
  2. Verify navigation to Multi-level import settings page.
  3. Tap Back (header).
  4. Verify return to Import page at /workspaces/<W2>/tags/workspace-tags-import.

• Expected: Back reconstructs import dynamic path; does not use old static route.

Case 2.4 — Legacy redirect: `/workspaces/<W>/tags/import`

• Target: OldRoutes.ts — '/workspaces/*/tags/import': '/workspaces/$1/tags/workspace-tags-import'.

• Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W2>/tags/import → Enter.
  2. Verify redirect → /workspaces/<W2>/tags/workspace-tags-import + Import page renders.
  3. Test with ?backTo=/home → query preserved.

• Expected: Old URL redirects correctly. ✅

---

3. DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORTED — imported tags review (workspace flow)

---

Case 3.1 — Forward: Import CSV → Imported page (single-level)

• Target: src/pages/workspace/tags/ImportTagsPage.tsx:52 — PR (DynamicImportTagsPage): workspaceGoToImportedPath = createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORTED.path, ROUTES.WORKSPACE_TAGS.getRoute(policyID)).

• Precondition: Workspace <W2>, no accounting connection; valid tags CSV file (1 column tag names).

  const policyID = "<W2>";
  Onyx.merge(`policy_${policyID}`, {
    areTagsEnabled: true,
    type: "corporate",
    role: "admin",
  });

• Steps:

  1. Workspace Tags → Import → single-level → Import page (Case 2.1).
  2. Upload valid tags CSV → proceed.
  3. Verify Imported Tags page opens (column mapping / confirm import).
  4. Verify URL = /workspaces/<W2>/tags/workspace-tags-imported.
  5. Tap Back → verify return to Import page /workspaces/<W2>/tags/workspace-tags-import.

• Expected: Forward + back between import ↔ imported use dynamic URLs.

Case 3.2 — Legacy redirect: `/workspaces/<W>/tags/imported`

• Target: OldRoutes.ts — '/workspaces/*/tags/imported': '/workspaces/$1/tags/workspace-tags-imported'.

• Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W2>/tags/imported → Enter.
  2. Verify redirect → /workspaces/<W2>/tags/workspace-tags-imported.
  3. (Page may be empty without spreadsheet Onyx — verifying URL redirect is sufficient.)

• Expected: Old URL redirects correctly. ✅

Case 3.3 — Refresh / deeplink restore on new URL

• Precondition: On Imported page after upload (/workspaces/<W2>/tags/workspace-tags-imported).

• Steps:

  1. Reload / paste new URL.
  2. Verify page restores or graceful state (no crash / 404).
  3. Back → Import page.

• Expected: Deeplink on new URL does not break navigation stack.

---

4. DYNAMIC_ROUTES.SETTINGS_TAGS_SETTINGS — tags settings (quick-settings flow)

---

Case 4.1 — Entry: quick-settings Tags → More → Settings

• Target: src/pages/workspace/tags/WorkspaceTagsPage.tsx:436 — PR: createDynamicRoute(DYNAMIC_ROUTES.SETTINGS_TAGS_SETTINGS.path) (isQuickSettingsFlow branch). UI: onSelected: navigateToTagsSettings (~L481).

• Precondition: Tags opened via quick-settings (SETTINGS_TAGS_ROOT). Can reach by changing URL workspace → settings (per PR QA).

  const policyID = "<W>";
  Onyx.merge(`policy_${policyID}`, {
    areTagsEnabled: true,
    type: "corporate",
    role: "admin",
  });
  // UI entry: /settings/<W>/tags (SETTINGS_TAGS_ROOT) — from expense flow or paste URL.

• Steps:

  1. Open app → log in.
  2. Navigate to quick-settings Tags: /settings/<W>/tags (from expense flow or change URL from /workspaces/<W>/tags → /settings/<W>/tags per PR QA).
  3. Tap More (⋯) → Settings.
  4. Verify Tags Settings page opens (Requires tag / Track billable / Custom tag name…).
  5. Verify URL = /settings/<W>/tags/settings-tags-settings.
  6. Tap Back → verify return to Tags root /settings/<W>/tags.

• Expected: Quick-settings settings page is dynamic; no backTo query; Back strips suffix.

Case 4.2 — Nested: Edit tag list name from Tags Settings (`SETTINGS_TAGS_EDIT` collateral)

• Target: src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx:87 — createDynamicRoute(DYNAMIC_ROUTES.SETTINGS_TAGS_EDIT.getRoute(orderWeight)) (quick-settings).

• Precondition: On Tags Settings page (Case 4.1), single-level tags.

• Steps:

  1. Tap Custom tag name (or edit tag list menu).
  2. Verify Edit Tags page opens.
  3. Verify URL contains suffix settings-tags-edit/<orderWeight> (nested under settings-tags-settings or directly on tags root depending on stack).
  4. Tap Back → verify return to Tags Settings (settings-tags-settings).

• Expected: Collateral SETTINGS_TAGS_EDIT rename does not break nested navigation.

Case 4.3 — Guard: workspace flow Tags Settings still uses `WORKSPACE_TAGS_SETTINGS`

• Target: src/pages/workspace/tags/WorkspaceTagsPage.tsx:436 — !isQuickSettingsFlow branch unchanged (WORKSPACE_TAGS_SETTINGS from BT-138).

• Steps:

  1. Workspace <W> → Tags → More → Settings.
  2. Verify URL = /workspaces/<W>/tags/tags-settings (not settings-tags-settings).

• Expected: Workspace vs quick-settings use the correct separate dynamic routes.

Case 4.4 — Legacy redirect: `/settings/<W>/tags/settings`

• Target: OldRoutes.ts — '/settings/*/tags/settings': '/settings/$1/tags/settings-tags-settings'.

• Steps:

  1. Paste https://dev.new.expensify.com:8082/settings/<W>/tags/settings → Enter.
  2. Verify redirect → /settings/<W>/tags/settings-tags-settings + Tags Settings renders.

• Expected: Old quick-settings bookmark still works. ✅

---

5. Collateral — SETTINGS_TAGS_EDIT — suffix rename + backward-compat redirects

---

Case 5.1 — Legacy redirect: `/settings/<W>/tags/<orderWeight>/edit`

• Target: OldRoutes.ts — '/settings/*/tags/*/edit' → …/settings-tags-settings/settings-tags-edit/$2.

• Steps:

  1. Paste https://dev.new.expensify.com:8082/settings/<W>/tags/0/edit → Enter.
  2. Verify redirect → /settings/<W>/tags/settings-tags-settings/settings-tags-edit/0.
  3. Test ?backTo=/home preserved.

• Expected: Redirect chain is correct (unit test exists). ✅

Case 5.2 — ⚠️ Old URL `/settings/<W>/tags/edit/<orderWeight>` (P2 review)

• Target: Redirect '/settings/*/tags/edit/*' not yet in current PR.

• Precondition: Logged in; old URL valid on main with suffix edit/:orderWeight on tags root.

• Steps:

  1. Paste https://dev.new.expensify.com:8082/settings/<W>/tags/edit/0 → Enter.
  2. Verify behavior: if PR has not added redirect → may fall back / Not Found (old URL does not resolve).
  3. ⚠️ After author adds redirect (if P2 accepted): re-test → must redirect to /settings/<W>/tags/settings-tags-edit/0 (or equivalent nested path).

• Expected: May not PASS currently if bookmark uses tags/edit/<ow> shape. Capture as evidence; does not block merge if team confirms URL is internal-only.

[suneox]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

---

DYNAMIC_ROUTES.WORKSPACE_TAG_LIST_VIEW — multi-level tag list view (workspace flow)

---

Case 1.1 — Entry: tap tag list row from Workspace Tags (multi-level)

Case 1.2 — Back from Edit Tags (multi-level) reconstructs tag list view

Case 1.3 — Guard: quick-settings flow still uses `SETTINGS_TAG_LIST_VIEW` (unchanged)

Case 1.4 — Legacy redirect: `/workspaces/<W>/tag-list/<orderWeight>`

Case 1.5 — Refresh / deeplink restore on new URL

---

DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORT — import tags spreadsheet (workspace flow)

---

Case 2.1 — Entry: Tags → Import → single-level import

Case 2.2 — Entry: Import options → multi-level path (confirm modal flow)

Case 2.3 — Back from Multi-level import settings

Case 2.4 — Legacy redirect: `/workspaces/<W>/tags/import`

---

DYNAMIC_ROUTES.WORKSPACE_TAGS_IMPORTED — imported tags review (workspace flow)

---

Case 3.1 — Forward: Import CSV → Imported page (single-level)

Case 3.2 — Legacy redirect: `/workspaces/<W>/tags/imported`

---

DYNAMIC_ROUTES.SETTINGS_TAGS_SETTINGS — tags settings (quick-settings flow)

---

Case 4.1 — Entry: quick-settings Tags → More → Settings

Case 4.2 — Nested: Edit tag list name from Tags Settings (`SETTINGS_TAGS_EDIT` collateral)

Case 4.3 — Guard: workspace flow Tags Settings still uses `WORKSPACE_TAGS_SETTINGS`

Case 4.4 — Legacy redirect: `/settings/<W>/tags/settings`

---

Collateral — SETTINGS_TAGS_EDIT — suffix rename + backward-compat redirects

---

Case 5.1 — Legacy redirect: `/settings/<W>/tags/<orderWeight>/edit`

Case 5.2 — ⚠️ Old URL `/settings/<W>/tags/edit/<orderWeight>` (P2 review)

CleanShot.2026-07-01.at.20.32.52.1.mp4

[suneox]

Verified that all manual test cases passed

[mjasikowski]

@huult the previous tag PR was merged, so this needs resolving conflicts now

[huult]

OMG, so many conflicts 😂 Haha, I'll resolve them now.