[CP Staging] Revert "Update the policy expensify card table to the new style"#94807
Conversation
melvin-bot
Bot
requested review from
MonilBhavsar and
heyjennahay
and removed request for
a team
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5ada25631
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <Checkbox | ||
| accessibilityLabel={cardholderName} | ||
| isChecked={bulkSelection.isSelected} | ||
| onPress={bulkSelection.onToggle} | ||
| /> |
There was a problem hiding this comment.
When this row checkbox is rendered inside the row PressableWithFeedback in WorkspaceExpensifyCardListPage, web click/mouse events bubble to the row press handler, so selecting a card also opens the card details instead of leaving the user on the list for bulk export. The table implementation guarded checkbox targets/propagation; add the same stop/guard here so checkbox clicks only toggle selection.
Useful? React with 👍 / 👎.
| <ScrollView | ||
| addBottomSafeAreaPadding | ||
| showsVerticalScrollIndicator={false} | ||
| > | ||
| <FlatList |
There was a problem hiding this comment.
For policies with many Expensify Cards, this FlatList is inside the same vertical ScrollView, so React Native cannot virtualize/window the rows and will render the entire card list, producing the standard VirtualizedList nesting warning and hurting list performance. The previous table used the list as the scroll container; move the header/footer/safe-area padding onto the FlatList instead of wrapping it.
Useful? React with 👍 / 👎.
…able [CP Staging] Revert "Update the policy expensify card table to the new style" (cherry picked from commit f23fd81) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.21-6 🚀
|
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.22-1 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.24-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.24-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.24-0 🚀
|
3 participants
Reverts #93861
### Fixed issues
$ #94750