Skip to content

Add Rillet integration export pages#94920

Merged
lakchote merged 42 commits into
Expensify:mainfrom
s77rt:Rillet-integration-export
Jul 9, 2026
Merged

Add Rillet integration export pages#94920
lakchote merged 42 commits into
Expensify:mainfrom
s77rt:Rillet-integration-export

Conversation

@s77rt

@s77rt s77rt commented Jun 30, 2026

Copy link
Copy Markdown
Member

Explanation of Change

Fixed Issues

$ #94848
PROPOSAL:

Tests

Test 1

  1. Create a workspace and enable accounting feature
  2. Go to Accounting
  3. Connect Rillet integration
  4. Click on Export
  5. Verify the export load correctly
  6. Verify each option row that it takes you to a different page and verify you can change the set values
Screen.Recording.2026-07-03.at.4.20.22.PM.mov

Test 2

  1. Create report and add some expenses both reimbursable and non-reimbursable
  2. Submit report
  3. Approve report
  4. Export report to Rillet
  5. Verify report is exported
  • Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@s77rt s77rt marked this pull request as ready for review July 1, 2026 02:37
@s77rt s77rt requested review from a team as code owners July 1, 2026 02:37
@melvin-bot melvin-bot Bot requested review from thelullabyy and trjExpensify and removed request for a team July 1, 2026 02:38
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/libs/PolicyUtils.ts 77.13% <ø> (-0.09%) ⬇️
src/libs/ReportActionsUtils.ts 78.41% <0.00%> (ø)
src/pages/workspace/accounting/utils.tsx 0.00% <0.00%> (ø)
...pace/accounting/rillet/import/RilletImportPage.tsx 0.00% <0.00%> (ø)
src/ROUTES.ts 20.62% <0.00%> (-0.10%) ⬇️
... and 7 more
... and 11 files with indirect coverage changes

@s77rt

s77rt commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

@truph01 Can you please test exporting reports too (test exporting both reimbursable and non-reimbursable expenses)

Comment thread src/libs/ReportActionsUtils.ts Outdated
@s77rt

s77rt commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Looks we have lint issues on main, will merge main later to see if they get fixed by that time

@truph01

truph01 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@s77rt I'm encountering this error while trying to export:

Screenshot 2026-07-08 at 10 03 02

Could you help take a look?

@s77rt

s77rt commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@truph01 You need to add your email as a customer and/or vendor in Rillet (same as other integrations)

@s77rt

s77rt commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@lakchote BUG: After disconnecting RIllet and connecting again, I found that the exporter is not set. It should be set to the one who created the connection (same as other integrations)

Screenshot 2026-07-08 at 7 15 44 AM

@truph01

truph01 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@s77rt After adding the email as vendor then trying to export again, I encountered another issue:

Screenshot 2026-07-08 at 14 10 24

@lakchote

lakchote commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@s77rt opened the Integration-Server fix here: https://github.com/Expensify/Integration-Server/pull/9116

It defaults the Rillet exporter to the connecting user after a submitted API key validates, including first connect/reconnect, while preserving any existing exporter.

@s77rt

s77rt commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@truph01 Use a valid merchant (list is in Rillet) e.g. Amazon

@lakchote

lakchote commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@s77rt opened the Integration-Server fix here: Expensify/Integration-Server#9116

It defaults the Rillet exporter to the connecting user after a submitted API key validates, including first connect/reconnect, while preserving any existing exporter.

PR has been merged, now waiting for deploy

@truph01

truph01 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@truph01 Can you please test exporting reports too (test exporting both reimbursable and non-reimbursable expenses)

@s77rt It works well:

Screenshot 2026-07-08 at 22 19 47

@s77rt

s77rt commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

@lakchote Looks we are good to merge this one

@lakchote

lakchote commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@truph01 no more issues found? If so, please approve the PR

@melvin-bot melvin-bot Bot requested a review from lakchote July 9, 2026 13:10
@truph01

truph01 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@lakchote I approved

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakchote lakchote merged commit 43c8ebb into Expensify:main Jul 9, 2026
36 checks passed
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants