Make Concierge suggested followup buttons wrap horizontally - #94923
Make Concierge suggested followup buttons wrap horizontally#94923MelvinBot wants to merge 3 commits into
Conversation
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot we should still allow the buttons to wrap to multiple lines if they are wider than the viewport, like main currently does. The rest of the changes look good though. |
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
|
Done — pushed The horizontal wrapping layout let buttons wrap to new lines, but a single button wider than the viewport would still overflow off-screen, because React Native flex items default to
Ran prettier, |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot this still isn't working as expected. I need button labels to break to multiple lines when the button is wider than the viewport width. |
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot this still isn't working as expected. I need button labels to break to multiple lines when the button is wider than the viewport width. |
|
Before I push another change, I want to flag something about the build you're likely testing, because I think the wrap fix may not actually be in it. The fix that makes an over-wide label wrap is in
Both adhoc builds posted above were compiled from Could you retest on the latest?
If it still doesn't wrap on the latest, drop a screenshot + which platform you're on. The width chain is bounded all the way down (the message column uses |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Just came back, but are we still wanting to test it? If so, I might just do a local Claude riff. Looks like the original issue was closed |
|
We tested it with the adhoc builds above! And I think we all generally felt kinda "meh" - don't hate it, don't love it. How are you feeling? |
|
Getting this so can't test, but if y'all don't love it, then lets leave it. I don't feel strongly from the mocks. Didn't feel much when I made them either. What we have kinda works. |

Explanation of Change
Currently the Concierge AI suggested followup (suggested response) buttons are stacked vertically, one per line, taking up a lot of vertical space.
This change makes those buttons "float" in a wrapping horizontal layout, as agreed in the issue discussion:
How it works:
ActionableItemButtons.tsx: thehorizontallayout now appliesflexWrapin addition toflexRow, so buttons wrap instead of overflowing. The existinggap2(8px) style already applies to both axes in React Native, giving the 8px horizontal and vertical gaps. Left alignment is the flexbox default (justifyContent: flex-start).ChatActionableButtons.tsx: suggested followups now use thehorizontallayout. The layout decision was changed fromisPhrasalConciergeOptionstoisConciergeOptions, so numbered Concierge category/description option lists stay vertical while only the suggested followups switch to the new wrapping layout. The pill styling/text props remain tied toisPhrasalConciergeOptions, so the followup buttons keep their chip appearance.FollowupListSkeleton.tsx: the loading skeleton now matches the new wrapping horizontal layout.This is purely a presentation/styling change — the underlying suggestion data model is unchanged.
Fixed Issues
$ #92441
PROPOSAL: #92441 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
Same as Tests.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari