Skip to content

[Home Page] Update the "Getting started" slot for the Track expenses for my business intent#95057

Merged
pecanoro merged 6 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/getting-started-my-business
Jul 8, 2026
Merged

[Home Page] Update the "Getting started" slot for the Track expenses for my business intent#95057
pecanoro merged 6 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/getting-started-my-business

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Adds a Link company card step to the Home "Getting started" slot (below Customize accounting categories) for the Track expenses for my business intent. It navigates to the workspace Company Cards page and auto-completes once a company card feed is connected.
  • The Customize accounting categories and Link company card steps now follow their More features toggles: disabling Categories or Company cards hides the matching step and re-enabling restores it, keeping the remaining steps' order.

Fixed Issues

$ #93097
PROPOSAL:

Tests

  1. Sign in with a new account and complete onboarding by selecting the Track expenses for my business intent, ending on a paid group workspace where you are an admin.
  2. Open the Home page and confirm the "Getting started" slot shows, in order: Create a workspace (completed), Customize accounting categories, Link company card, Invite your accountant.
  3. Tap Link company card and verify it navigates to the workspace Company Cards page (/company-cards).
  4. Connect a company card feed, return to Home, and verify the Link company card step is now marked as completed.
  5. Open the workspace More features menu and disable Company cards; return to Home and verify the Link company card step is hidden while the other steps keep their order. Re-enable Company cards and verify the step reappears.
  6. Repeat step 5 for Categories and verify the Customize accounting categories step hides and reappears the same way.
  • Verify that no errors appear in the JS console

Offline tests

  1. Complete onboarding with the Track expenses for my business intent so the "Getting started" slot is visible.
  2. Turn off your network connection.
  3. Open the Home page and verify the Link company card step still renders with its correct label, order, and completion state based on the last known workspace data.

QA Steps

  1. Sign in with a new account, complete onboarding selecting Track expenses for my business, and open the Home page.
  2. Verify the "Getting started" slot lists Link company card directly below Customize accounting categories, and that tapping it opens the workspace Company Cards page.
  3. Connect a company card feed and confirm the Link company card step becomes completed; then toggle Company cards and Categories off/on in More features and confirm the matching steps hide and reappear.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-01.at.16.29.07.mov

Surface the company card setup task below Customize accounting categories
for the Track expenses for my business intent, auto-completing it when the
workspace has a connected feed. Both the categories and company card steps
now mirror their More features toggles, hiding when disabled and reappearing
when re-enabled.
@adamgrzybowski adamgrzybowski marked this pull request as ready for review July 1, 2026 14:53
@adamgrzybowski adamgrzybowski requested review from a team as code owners July 1, 2026 14:53
@melvin-bot melvin-bot Bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team July 1, 2026 14:53
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia Could we get someone to actually test adding a card? I don't have any card, so I haven't tested it

@JmillsExpensify JmillsExpensify requested review from flaviadefaria and removed request for JmillsExpensify July 1, 2026 15:37
@JmillsExpensify

Copy link
Copy Markdown
Contributor

Switched @flaviadefaria for review since this is her issue.

@adamgrzybowski adamgrzybowski changed the title Update the "Getting started" slot for the Track expenses for my business intent [Home Page] Update the "Getting started" slot for the Track expenses for my business intent Jul 1, 2026
Comment thread src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts Outdated
Comment thread src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts Outdated
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach logic modified. Let's move forward

Comment thread src/pages/home/GettingStartedSection/GettingStartedRow.tsx
Steps are now hidden when their feature is disabled, so the enable-on-tap
fields were unused dead code re-added by a main merge.
@ZhenjaHorbach

ZhenjaHorbach commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-07-08.09.57.02.mov
Android: mWeb Chrome
2026-07-08.09.52.13.mov
iOS: HybridApp
2026-07-08.09.59.17.mov
iOS: mWeb Safari
2026-07-08.09.57.02.mov
MacOS: Chrome / Safari
2026-07-08.09.52.13.mov

@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #93097 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot melvin-bot Bot requested a review from pecanoro July 8, 2026 08:10
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

CC: @grgia

@grgia

grgia commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@flaviadefaria would you like to review before merge?

@flaviadefaria

Copy link
Copy Markdown
Contributor

Looking at the recording, I'm not able to verify that the new Link company card step is correctly dismissed.

The step should automatically be marked as completed when the workspace has a successful connection.

@ZhenjaHorbach @grgia, is this something you've been able to verify?

@ZhenjaHorbach

ZhenjaHorbach commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

We reused the same logic as for Manage my team's expenses
So everything is good!

2026-07-08.13.34.24.mov

@flaviadefaria flaviadefaria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's merge it!

@pecanoro pecanoro merged commit 8dbb015 into Expensify:main Jul 8, 2026
37 of 38 checks passed
@OSBotify

OSBotify commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🚧 pecanoro has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site changes required ✅

This PR changes user-visible behavior of the Home Getting started slot for the track and budget my expenses intent, which is documented on the help site, so a docs update is needed.

What changed in this PR (user-facing):

  • Adds a Link company card step to the Getting started checklist (below Customize accounting categories) for the track and budget my expenses intent.
  • The Customize accounting categories and Link company card steps now follow their workspace More features toggles (Categories / Company cards) — disabling a feature hides the matching step, re-enabling restores it.

Affected help article: Expensify-Home-Overview.md — the "How the Getting started section works on Home" section previously listed only creating a workspace, customizing accounting categories, and inviting an accountant for this intent, omitting the company card step.

Draft help site PR: #95686

@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants