[Home Page] Update the "Getting started" slot for the Track expenses for my business intent#95057
Conversation
Surface the company card setup task below Customize accounting categories for the Track expenses for my business intent, auto-completing it when the workspace has a connected feed. Both the categories and company card steps now mirror their More features toggles, hiding when disabled and reappearing when re-enabled.
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@grgia Could we get someone to actually test adding a card? I don't have any card, so I haven't tested it |
|
Switched @flaviadefaria for review since this is her issue. |
Track expenses for my business intentTrack expenses for my business intent
|
@ZhenjaHorbach logic modified. Let's move forward |
Steps are now hidden when their feature is disabled, so the enable-on-tap fields were unused dead code re-added by a main merge.
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-07-08.09.57.02.movAndroid: mWeb Chrome2026-07-08.09.52.13.moviOS: HybridApp2026-07-08.09.59.17.moviOS: mWeb Safari2026-07-08.09.57.02.movMacOS: Chrome / Safari2026-07-08.09.52.13.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #93097 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
CC: @grgia |
|
@flaviadefaria would you like to review before merge? |
|
Looking at the recording, I'm not able to verify that the new
@ZhenjaHorbach @grgia, is this something you've been able to verify? |
|
We reused the same logic as for 2026-07-08.13.34.24.mov |
flaviadefaria
left a comment
There was a problem hiding this comment.
Awesome, let's merge it!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.4.32-0 🚀
|
Help site changes required ✅This PR changes user-visible behavior of the Home Getting started slot for the track and budget my expenses intent, which is documented on the help site, so a docs update is needed. What changed in this PR (user-facing):
Affected help article: Draft help site PR: #95686 @adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Link company cardstep to the Home "Getting started" slot (belowCustomize accounting categories) for theTrack expenses for my businessintent. It navigates to the workspace Company Cards page and auto-completes once a company card feed is connected.Customize accounting categoriesandLink company cardsteps now follow theirMore featurestoggles: disablingCategoriesorCompany cardshides the matching step and re-enabling restores it, keeping the remaining steps' order.Fixed Issues
$ #93097
PROPOSAL:
Tests
Track expenses for my businessintent, ending on a paid group workspace where you are an admin.Create a workspace(completed),Customize accounting categories,Link company card,Invite your accountant.Link company cardand verify it navigates to the workspace Company Cards page (/company-cards).Link company cardstep is now marked as completed.More featuresmenu and disableCompany cards; return to Home and verify theLink company cardstep is hidden while the other steps keep their order. Re-enableCompany cardsand verify the step reappears.Categoriesand verify theCustomize accounting categoriesstep hides and reappears the same way.Offline tests
Track expenses for my businessintent so the "Getting started" slot is visible.Link company cardstep still renders with its correct label, order, and completion state based on the last known workspace data.QA Steps
Track expenses for my business, and open the Home page.Link company carddirectly belowCustomize accounting categories, and that tapping it opens the workspace Company Cards page.Link company cardstep becomes completed; then toggleCompany cardsandCategoriesoff/on inMore featuresand confirm the matching steps hide and reappear.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-01.at.16.29.07.mov