Fix legacy unreported expenses missing "Move to report" option in NewDot by mollfpr · Pull Request #95068 · Expensify/App

mollfpr · 2026-07-01T15:57:41Z

Explanation of Change

Legacy or imported unreported expenses don't have an IOU report action because they predate the NewDot money-request flow. In canEditFieldOfMoneyRequest, the REPORT field eligibility check bails out early at the isMoneyRequestAction(reportAction) guard before reaching the existing logic that allows unreported expenses to be moved. This caused "Move to report" to never appear in Search's bulk actions for these expenses.

The fix adds an early-return path before that guard: if the field being edited is REPORT, there is no reportAction, and the transaction is unreported, we skip the action guard entirely and return the result of the per-diem policy check — the same check already used for regular unreported expenses. I also extracted that per-diem check into a canUnreportedPerDiemBeMoved helper to avoid duplicating the logic.

Fixed Issues

$ #93799
PROPOSAL:

Tests

Prerequisite:

Account with workspace
Open OldDot and go to Settings → Account → Wallet
Import personal bank/card
Select Discover Bank and use the expensidemo credentials
Select any account
Disable reimbursable and complete the import
Go to the expense page and open the imported expense
Change the expense report to none

Open NewDot and go to Spend → Expenses
Select the unreported legacy expense using the checkbox
Click "1 selected" to open the bulk actions menu
Verify that "Move to report" is visible from the options

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Prerequisite:

Account with workspace
Open OldDot and go to Settings → Account → Wallet
Import personal bank/card
Select Discover Bank and use the expensidemo credentials
Select any account
Disable reimbursable and complete the import
Go to the expense page and open the imported expense
Change the expense report to none

Open NewDot and go to Spend → Expenses
Select the unreported legacy expense using the checkbox
Click "1 selected" to open the bulk actions menu

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.Jul.2.2026.mp4

…nreported-expenses-move-to-report

…entation

…nreported-expenses-move-to-report

mollfpr · 2026-07-02T15:25:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec65af7229

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-07-02T15:42:01Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-02T15:42:06Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2026-07-02T15:47:43Z

Ohh no Melvin pulls 2 C+ 😓

Let's go with @bernhardoj since they got assigned first. 🙏

trjExpensify

👍

bernhardoj · 2026-07-03T09:30:26Z

    return true;
 }

+function canUnreportedPerDiemBeMoved(transaction: OnyxEntry<Transaction>, policies: OnyxCollection<Policy>): boolean {


I think we should rename this to canUnreportedBeMoved or something similar because the logic inside the function isn't limited to per diem.

The function assumes the transaction is a per diem, but inside it, we check first whether it's per diem or not.

Nice suggestion! Updated!

bernhardoj · 2026-07-03T09:49:18Z

@mollfpr I've imported the Discover Bank card, but I don't see any imported expenses.

mollfpr · 2026-07-03T16:22:54Z

@bernhardoj Could you try again, delete the previous, and add an import by selecting the new account? Also, attach the requestID if it's still not showing the expense.

…nreported-expenses-move-to-report

…sReport" This reverts commit d17a4fb.

bernhardoj · 2026-07-04T01:29:45Z

@mollfpr Still not showing. Where do I get the requestID?

Oh, here you go: "a15a5f2c2a42fd95-SJC"

…nreported-expenses-move-to-report

mollfpr · 2026-07-07T08:18:18Z

@bernhardoj It seems the import is gated by the staging flag. Could you try again against the BE prod?

Also try to use this account Tracey Southgate - 8755.

bernhardoj · 2026-07-08T10:03:04Z

That works.

But I can see the "Move to report" option even without this PR 🤔.

…nreported-expenses-move-to-report

mollfpr · 2026-07-09T07:21:52Z

@bernhardoj I tested on production, and it's still not showing the "Move to report".

Screen.Recording.Jul.9.2026.mp4

You should not open the expense, or it will create an IOU action, and the isUnreportedLegacyTransaction path will be passed.

…nreported-expenses-move-to-report

bernhardoj · 2026-07-09T10:10:20Z

Ok, yeah, I can reproduce it now (I'm pretty sure didn't open the expense on ND, I open it on OD tho to unreport the expense)

bernhardoj · 2026-07-09T10:14:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-07-09T10:50:19Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote

LGTM

OSBotify · 2026-07-09T13:58:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-09T13:58:55Z

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T14:19:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95068.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8fa661f049a-3ded924-45913a17ee4f50472e6f778a4b6e4b35b2cd6d08/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8fa661f-3ded924-060e6da5d4ced56a2f15ac08a064d4f485845238/index.html

Web 🕸️
https://95068.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:18:38Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:22:55Z

🤖 Help site review: no docs changes required.

This PR is a bug fix that restores existing, already-documented behavior. It adds an early-return path in canEditFieldOfMoneyRequest so that legacy/imported unreported expenses (which predate the NewDot money-request flow and have no IOU report action) once again show Move to report in the Spend page bulk actions menu. It introduces no new feature, UI label, tab, or setting.

The help site already describes this behavior correctly:

Getting-Started-with-the-Spend-Page.md documents Move to report as a bulk action and how to move unreported expenses between reports.

Because the fix simply makes actual behavior match what the docs already say (rather than changing documented behavior), there is nothing to update under docs/articles. No draft PR was created.

@mollfpr, please confirm you agree that no help site changes are required here. If you feel the docs should be expanded to call out that imported/legacy unreported expenses can also be moved to a report, let me know and I'll open a draft PR.

mvtglobally · 2026-07-12T17:59:54Z

@bernhardoj @mollfpr @trjExpensify We are unable to use Discover test credentials to QA this PR as no expenses match required criteria. Is there an alternative way?

95068.mp4

mollfpr · 2026-07-13T00:53:58Z

@mvtglobally it seems the export got gated by staging, could you try setup the expenses in OldDot production?

IuliiaHerets · 2026-07-13T07:51:01Z

@mollfpr Fail with the original KI in this way.
No "Move to report" option when bulk selecting

95068_prod.mp4

mollfpr · 2026-07-13T07:54:05Z

@IuliiaHerets okay the import is works, now open the NewDot in staging to test the "Move to report" option with the same account.

IuliiaHerets · 2026-07-13T09:11:29Z

@mollfpr Pass in Staging with the same account for Web

95068_pass.mp4

mollfpr added 4 commits July 1, 2026 22:55

Extract canUnreportedPerDiemBeMoved helper in ReportUtils

d4b4ff8

Use canUnreportedPerDiemBeMoved in the existing unreported expense check

ce4a514

Allow legacy unreported expenses to be moved to a report

22e2670

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

256ffb4

…nreported-expenses-move-to-report

melvin-bot Bot assigned mollfpr Jul 1, 2026

mollfpr added 3 commits July 2, 2026 10:21

Add tests for legacy unreported expense move to report

bf3f4dd

Resolve merge conflict in ReportUtils

078ae75

Use isEmptyObject in canUnreportedPerDiemBeMoved to match main implem…

1774061

…entation

mollfpr changed the title ~~Mollfpr legacy unreported expenses move to report~~ Fix legacy unreported expenses missing "Move to report" option in NewDot Jul 2, 2026

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

ec65af7

…nreported-expenses-move-to-report

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts

Normalize empty reportID before skipping in changeTransactionsReport

d17a4fb

mollfpr marked this pull request as ready for review July 2, 2026 15:41

mollfpr requested review from a team as code owners July 2, 2026 15:41

melvin-bot Bot requested review from bernhardoj and trjExpensify July 2, 2026 15:42

melvin-bot Bot requested review from a team and shubham1206agra and removed request for a team July 2, 2026 15:42

mollfpr removed the request for review from shubham1206agra July 2, 2026 15:47

trjExpensify previously approved these changes Jul 2, 2026

View reviewed changes

bernhardoj reviewed Jul 3, 2026

View reviewed changes

mollfpr dismissed trjExpensify’s stale review via 23f9e88 July 3, 2026 16:23

mollfpr added 2 commits July 3, 2026 23:23

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

89bd0c0

…nreported-expenses-move-to-report

Revert "Normalize empty reportID before skipping in changeTransaction…

86900b6

…sReport" This reverts commit d17a4fb.

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

7eed646

…nreported-expenses-move-to-report

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

7cbe6cf

…nreported-expenses-move-to-report

Merge branch 'main' of github.com:Expensify/App into mollfpr-legacy-u…

7394295

…nreported-expenses-move-to-report

bernhardoj approved these changes Jul 9, 2026

View reviewed changes

melvin-bot Bot requested a review from lakchote July 9, 2026 10:50

lakchote approved these changes Jul 9, 2026

View reviewed changes

lakchote merged commit 8fa661f into main Jul 9, 2026
43 checks passed

lakchote deleted the mollfpr-legacy-unreported-expenses-move-to-report branch July 9, 2026 13:51

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

82 tasks

Uh oh!

Conversation

mollfpr commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

mollfpr commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 2, 2026

Uh oh!

melvin-bot Bot commented Jul 2, 2026

Uh oh!

mollfpr commented Jul 2, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

mollfpr Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jul 3, 2026

Uh oh!

mollfpr commented Jul 3, 2026

Uh oh!

bernhardoj commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Jul 8, 2026

Uh oh!

mollfpr commented Jul 9, 2026

Uh oh!

bernhardoj commented Jul 9, 2026

Uh oh!

bernhardoj commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

mvtglobally commented Jul 12, 2026

Uh oh!

mollfpr commented Jul 13, 2026

Uh oh!

IuliiaHerets commented Jul 13, 2026

Uh oh!

mollfpr commented Jul 13, 2026

Uh oh!

IuliiaHerets commented Jul 13, 2026

mollfpr commented Jul 1, 2026 •

edited

Loading

bernhardoj commented Jul 4, 2026 •

edited

Loading

mollfpr commented Jul 7, 2026 •

edited

Loading

bernhardoj commented Jul 9, 2026 •

edited

Loading