Skip to content

Increase spacing between Concierge messages and their follow-up buttons#95239

Merged
Beamanator merged 3 commits into
Expensify:mainfrom
KioCoan:fixConciergeChatButtonSpacing
Jul 7, 2026
Merged

Increase spacing between Concierge messages and their follow-up buttons#95239
Beamanator merged 3 commits into
Expensify:mainfrom
KioCoan:fixConciergeChatButtonSpacing

Conversation

@KioCoan

@KioCoan KioCoan commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Concierge messages that include follow-up suggestion buttons rendered the buttons only 8px (mt2) below the message text, the same as the 8px gap between the buttons themselves (gap2). With no larger gap separating the message from the action group, the buttons read as part of the message and feel cramped against the text.

This PR increases the message-to-buttons gap to 16px (mt4) for the Concierge phrasal / follow-up case, so it's double the inter-button gap and the buttons are clearly distinguished as a separate action group.

  • ActionableItemButtons gains an optional wrapperStyle prop that is applied to the buttons container, so callers can override the default mt2 top margin.
  • ChatActionableButtons passes styles.mt4 as wrapperStyle only when isPhrasalConciergeOptions (Concierge category/description options and follow-ups). This is intentionally scoped: the shared ActionableItemButtons is also used by fraud-alert, mention, join-request, confirm, track-expense and add-payment-card whispers, and those are left unchanged at mt2.
  • FollowupListSkeleton is bumped mt2mt4 so the loading placeholder sits at the same 16px gap and there's no vertical jump when the real buttons load in.

The email rendering half of the linked issue (buttons were squared instead of pill-shaped, and the same spacing) is handled in a companion Web-Expensify PR.

Fixed Issues

#94715

Tests

  1. Open the Concierge chat (or tap + → Start chat and select Concierge).
  2. Send a message that prompts a reply with suggestions, e.g. What kinds of things can I ask Concierge to do?
  3. Wait for Concierge to reply with a message that includes follow-up suggestion buttons.
  4. Verify there is a clear gap (16px) between the message text and the first follow-up button that is noticeably larger than the (8px) gap between the buttons themselves.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Open the Concierge chat (or tap + → Start chat and select Concierge).
  2. Send a message that prompts a reply with suggestions, e.g. What kinds of things can I ask Concierge to do?
  3. Wait for Concierge to reply with a message that includes follow-up suggestion buttons.
  4. Verify there is a clear gap (16px) between the message text and the first follow-up button that is noticeably larger than the (8px) gap between the buttons themselves.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Before (8px) After (16px)
CLEAN-old-8px CLEAN-new-16px

@KioCoan KioCoan marked this pull request as ready for review July 2, 2026 23:18
@KioCoan KioCoan requested review from a team as code owners July 2, 2026 23:18
@melvin-bot melvin-bot Bot requested review from trjExpensify and removed request for a team July 2, 2026 23:18
@KioCoan KioCoan requested a review from Beamanator July 2, 2026 23:18
@melvin-bot melvin-bot Bot removed the request for review from a team July 2, 2026 23:19
@melvin-bot

melvin-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Beamanator

Copy link
Copy Markdown
Contributor

@KioCoan looks like a few checks are failing 🙏

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC: @Expensify/design if anyone wants to take a look in Jon's absence. 👍

@dannymcclain

Copy link
Copy Markdown
Contributor

LGTM2 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Samesies here 👍

@Beamanator

Copy link
Copy Markdown
Contributor

lots of checks still failing 😢

@KioCoan

KioCoan commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@Beamanator I merged main and most checks are passing. I'm not entirely sure about what is going on with Jest Unit tho. Seems to be stuck.

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I turned it off and on again killed it and started it again, then it all passed 😬

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ponents/ReportActionItem/ActionableItemButtons.tsx 100.00% <100.00%> (ø)
...ox/report/actionContents/ChatActionableButtons.tsx 80.00% <100.00%> (+0.25%) ⬆️
...mponents/ReportActionItem/FollowupListSkeleton.tsx 25.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

@Beamanator

Beamanator commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Beamanator Beamanator merged commit bce5b1f into Expensify:main Jul 7, 2026
48 of 53 checks passed
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@KioCoan KioCoan deleted the fixConciergeChatButtonSpacing branch July 7, 2026 02:11
@OSBotify

OSBotify commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.29-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

I reviewed the changes in this PR and no updates are needed to Expensify's help site files under docs/articles.

Why: This PR is a purely visual/styling change — it increases the gap between a Concierge message and its follow-up suggestion buttons from 8px (mt2) to 16px (mt4), adds an optional wrapperStyle prop, and nudges the loading skeleton to match. There is no change to any feature, workflow, setting, tab, label, or button copy that the help site documents. Help site articles describe product behavior and how-to steps, not pixel-level spacing, so there's nothing to reflect here.

I also searched docs/articles for Concierge follow-up/suggestion button content — the only Concierge matches are incidental "contact Concierge" references unrelated to this spacing change.

No draft PR was created since no documentation updates are warranted.

@KioCoan, please confirm you agree no help site changes are needed here. If you believe an article should be updated, let me know which behavior it should reflect and I'll open a draft PR.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — no changes required.

I reviewed the changes in this PR. It's a purely visual spacing adjustment — increasing the gap between a Concierge message and its follow-up suggestion buttons from 8px to 16px (plus a matching bump to the loading skeleton). No user-facing feature, tab, setting, label, button name, or workflow changes.

Expensify's help site articles under docs/articles document what features do and how to use them — they don't describe pixel-level spacing or visual polish. I searched the articles for Concierge and follow-up/suggestion button content: the only matches are incidental references to Concierge as a support channel, none of which describe the spacing this PR touches.

Conclusion: No draft PR was created because no help site documentation update is warranted for this change.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants