Increase spacing between Concierge messages and their follow-up buttons#95239
Conversation
|
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@KioCoan looks like a few checks are failing 🙏 |
trjExpensify
left a comment
There was a problem hiding this comment.
LGTM. CC: @Expensify/design if anyone wants to take a look in Jon's absence. 👍
|
LGTM2 👍 |
|
Samesies here 👍 |
|
lots of checks still failing 😢 |
|
@Beamanator I merged main and most checks are passing. I'm not entirely sure about what is going on with Jest Unit tho. Seems to be stuck. |
Beamanator
left a comment
There was a problem hiding this comment.
I turned it off and on again killed it and started it again, then it all passed 😬
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.29-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and no updates are needed to Expensify's help site files under Why: This PR is a purely visual/styling change — it increases the gap between a Concierge message and its follow-up suggestion buttons from 8px ( I also searched No draft PR was created since no documentation updates are warranted. @KioCoan, please confirm you agree no help site changes are needed here. If you believe an article should be updated, let me know which behavior it should reflect and I'll open a draft PR. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.31-0 🚀
|
|
🤖 Help site review — no changes required. I reviewed the changes in this PR. It's a purely visual spacing adjustment — increasing the gap between a Concierge message and its follow-up suggestion buttons from 8px to 16px (plus a matching bump to the loading skeleton). No user-facing feature, tab, setting, label, button name, or workflow changes. Expensify's help site articles under Conclusion: No draft PR was created because no help site documentation update is warranted for this change. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Concierge messages that include follow-up suggestion buttons rendered the buttons only 8px (
mt2) below the message text, the same as the 8px gap between the buttons themselves (gap2). With no larger gap separating the message from the action group, the buttons read as part of the message and feel cramped against the text.This PR increases the message-to-buttons gap to 16px (
mt4) for the Concierge phrasal / follow-up case, so it's double the inter-button gap and the buttons are clearly distinguished as a separate action group.ActionableItemButtonsgains an optionalwrapperStyleprop that is applied to the buttons container, so callers can override the defaultmt2top margin.ChatActionableButtonspassesstyles.mt4aswrapperStyleonly whenisPhrasalConciergeOptions(Concierge category/description options and follow-ups). This is intentionally scoped: the sharedActionableItemButtonsis also used by fraud-alert, mention, join-request, confirm, track-expense and add-payment-card whispers, and those are left unchanged atmt2.FollowupListSkeletonis bumpedmt2→mt4so the loading placeholder sits at the same 16px gap and there's no vertical jump when the real buttons load in.The email rendering half of the linked issue (buttons were squared instead of pill-shaped, and the same spacing) is handled in a companion Web-Expensify PR.
Fixed Issues
#94715
Tests
What kinds of things can I ask Concierge to do?Offline tests
N/A
QA Steps
What kinds of things can I ask Concierge to do?PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari