Skip to content

83835 migrate workspace receipt partners expensify cards v2#95253

Merged
mjasikowski merged 11 commits into
Expensify:mainfrom
huult:83835-migrate-workspace-receipt-partners-expensify-cards-v2
Jul 9, 2026
Merged

83835 migrate workspace receipt partners expensify cards v2#95253
mjasikowski merged 11 commits into
Expensify:mainfrom
huult:83835-migrate-workspace-receipt-partners-expensify-cards-v2

Conversation

@huult

@huult huult commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #83835
PROPOSAL:

Tests

Same QA step

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

WORKSPACE_RECEIPT_PARTNERS_INVITE
WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT

Preconditions:

  • A Uber business account is already signed in.
  • The Receipt Partners feature is enabled.
  1. Open the Expensify app.
  2. Go to Workspace → Receipt Partners.
  3. Click Connect, select the Uber account to connect, and return to the Expensify app.
  4. Verify that the Send Invite page opens and that you can navigate back normally.
  5. Return to the Receipt Partners page.
  6. Open Manage Invites.
  7. Verify that the Manage Invites page opens and that you can navigate back normally.

WORKSPACE_EXPENSIFY_CARD_DETAILS

Preconditions:

  • The workspace has at least one Expensify Card.
  1. Open the Expensify app.
  2. Go to Workspace → Expensify Card.
  3. Open any Expensify Card.
  4. Verify that the Expensify Card Details page opens and that you can navigate back normally.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

WORKSPACE_RECEIPT_PARTNERS_INVITE
WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT

Screen.Recording.2026-07-03.at.10.08.56.mov

WORKSPACE_EXPENSIFY_CARD_DETAILS

Screen.Recording.2026-07-03.at.10.14.21.mov

@huult huult requested review from a team as code owners July 3, 2026 03:14
@melvin-bot melvin-bot Bot requested review from heyjennahay and suneox July 3, 2026 03:14
@melvin-bot

melvin-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed request for a team July 3, 2026 03:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c265e2abe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ROUTES.ts
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

@suneox

suneox commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Manual test cases base on current code change

DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS — Expensify Card details (workspace flow)
Case 1.1 — Entry: tap a card row from the Expensify Card list

Target: src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx:154 — PR: Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS.getRoute(cardID))).

Precondition: Admin of workspace <W> with Expensify Card feature enabled and ≥1 active card in the list.

const policyID = '<W>';
Onyx.merge(`policy_${policyID}`, {
    areExpensifyCardsEnabled: true,
    type: 'corporate',
    role: 'admin',
});
// Cannot set via Onyx: cards list is DERIVED from backend — test account must have ≥1 issued Expensify card.

Steps:

  1. Open the app and log in as admin of workspace <W> (with ≥1 Expensify card).
  2. LHN → Workspaces → select workspace <W>.
  3. Open Expensify Card (workspace nav / More features).
  4. Verify the card list shows ≥1 row.
  5. Tap any card row.
  6. Verify the Expensify Card details page opens (header "Expensify Card", Card name / Limit fields, etc.).
  7. Verify URL = /workspaces/<W>/expensify-card/card-details/<C>.
  8. Tap Back → verify return to the Expensify Card list (/workspaces/<W>/expensify-card); the card-details/... suffix is stripped.
  9. No console errors / "Hmm… it's not here" page.

Expected: Correct card details page; new URL shape; Back strips suffix to Expensify Card list.

Case 1.2 — Entry: tap Expensify card from Member details (suffix on member URL)

Target: src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx:256 — PR: createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS.getRoute(cardID)) (no explicit backTo; mirrors WORKSPACE_COMPANY_CARD_DETAILS pattern).

Precondition: Member <M> has ≥1 assigned card with bank === 'ExpensifyCard'. Admin access.

const policyID = "<W>";
const accountID = <M>;
Onyx.merge(`policy_${policyID}`, { type: "corporate", role: "admin" });
// Cannot set via Onyx: memberCards[] is DERIVED — need a real member with an assigned Expensify card.

Steps:

  1. Open the app → log in as admin of <W>.
  2. LHN → Workspaces<W>Members.
  3. Tap a member with Assigned cards (≥1 Expensify card).
  4. Tap the Expensify card row.
  5. Verify Card details opens; URL = /workspaces/<W>/members/<M>/card-details/<C> (suffix on member path, not /expensify-card/...).
  6. Tap Back → verify return to Member details (/workspaces/<W>/members/<M>), not the Expensify Card list.
  7. Refresh the card-details URL from step 5 → verify stack restores correctly.

Expected: Back returns to member details; member-path + suffix URL is correct.

Case 1.3 — Nested: Edit card name from details (DYNAMIC_EXPENSIFY_CARD_DETAILS entryScreen)

Target: WorkspaceExpensifyCardDetailsPage.tsx:358 — PR updates EXPENSIFY_CARD_NAME.entryScreensDYNAMIC_EXPENSIFY_CARD_DETAILS.

Precondition: On card details page (Case 1.1 or 1.2). User has canWriteExpensifyCard.

Steps:

  1. From card details, tap Card name.
  2. Verify edit name page opens; URL adds edit/name suffix.
  3. Tap Back (or Save) → verify return to card details (.../card-details/<C>).

Expected: Edit name opens/closes correctly on the new base; entryScreen rename does not break back.

Case 1.4 — Nested: Edit limit type from details

Target: WorkspaceExpensifyCardDetailsPage.tsx:391.

Precondition: Same as Case 1.3.

Steps:

  1. From card details → tap Limit Type.
  2. Verify edit limit type page opens (edit/limit-type suffix).
  3. Tap Back → verify return to card details.

Expected: Nested edit/limit-type works; Back returns to details.

Case 1.5 — Nested: Edit card limit from details

Target: WorkspaceExpensifyCardDetailsPage.tsx:401.

Precondition: Same as Case 1.3.

Steps:

  1. From card details → tap Card limit.
  2. Verify edit limit page opens (edit/limit suffix).
  3. Tap Back → verify return to card details.

Expected: Nested edit/limit works; Back returns to details.

Case 1.6 — Refresh / deep-link on new card-details URL (list path)

Precondition: URL from Case 1.1: /workspaces/<W>/expensify-card/card-details/<C>.

Steps:

  1. Paste URL into address bar → Enter (logged in).
  2. Verify card details renders for card <C>.
  3. Tap Back → verify return to Expensify Card list.

Expected: Deep-link + refresh restore the correct stack.

Case 1.7 — Old URL card details → redirect to new path

Precondition: Old bookmark URL /workspaces/<W>/expensify-card/<C>.

Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W>/expensify-card/<C> → Enter.
  2. Verify Card details opens for the correct card (redirect/open at /workspaces/<W>/expensify-card/card-details/<C>).
  3. Tap Back → verify return to Expensify Card list.

Expected: Old bookmark/deeplink still opens card details via OldRoutes.ts redirect.

Case 1.8 — Old nested edit URL → redirect to card-details + edit suffix

Precondition: Old URL /workspaces/<W>/expensify-card/<C>/edit/name (or edit/limit, edit/limit-type).

Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W>/expensify-card/<C>/edit/name → Enter.
  2. Verify redirect/open at /workspaces/<W>/expensify-card/card-details/<C>/edit/name and edit name page renders.
  3. Tap Back → verify return to card details.

Expected: Legacy nested edit paths redirect correctly.

Case 1.9 — OldRoutes does not false-positive on sibling routes

Precondition: Workspace with Expensify Card feature enabled.

Steps:

  1. Paste .../workspaces/<W>/expensify-card/settings → verify Card settings opens (no redirect to card-details).
  2. Paste .../expensify-card/choose-bank-account → verify bank account picker opens.
  3. Paste .../expensify-card/issue-new → verify issue-new flow opens.

Expected: Sibling routes keep their original URLs.


DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE — Uber invite after Receipt Partners connect
Case 2.1 — Auto-navigate to invite after Uber connect (useEffect)

Target: WorkspaceReceiptPartnersPage.tsx:104 — PR: createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE.getRoute('uber')).

Precondition: Receipt partners feature enabled; Uber not yet connected; admin with canWriteMoreFeatures. On Receipt Partners page when connecting.

Steps:

  1. Open app → log in as admin of <W> without Uber connected (Receipt partners feature ON).
  2. LHN → Workspaces<W>Receipt partners.
  3. Tap Connect (Uber row) → complete Uber OAuth / credentials flow.
  4. After successful connect, verify app auto-navigates to Send invites page.
  5. Verify URL contains /workspaces/<W>/receipt-partners/uber/invite.
  6. Tap Back → verify return to Receipt partners (/workspaces/<W>/receipt-partners).

Expected: Auto-navigate after connect; Back strips suffix to Receipt partners.

Case 2.2 — Back from Send invites + All set screen (PR: dismissModal → goBack)

Precondition: Uber connected; on invite page (Case 2.1 or deeplink Case 2.3).

Steps:

  1. On Send invites, select members → tap Invite.
  2. On All set screen: tap Back → verify goBack(backPath) returns to Receipt partners (changed from dismissModal()).
  3. On All set, tap Confirm → verify also returns to Receipt partners via goBack(backPath).
  4. On Send invites (before sending): tap Back → verify return to Receipt partners.

Expected: Both Back and Confirm on All set return to Receipt partners via dynamic back path.

Case 2.3 — Refresh / deep-link invite URL

Precondition: Uber connected.

Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W>/receipt-partners/uber/invite → Enter.
  2. Verify Send invites page opens.
  3. Tap Back → Receipt partners.

Expected: Deep-link restores invite page correctly.


DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT — Manage invites (All / Linked / Outstanding tabs)
Case 3.1 — Entry: tap Manage invites from Receipt Partners

Target: WorkspaceReceiptPartnersPage.tsx:392 — PR: createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT.getRoute('uber')).

Precondition: Uber connected; canWriteMoreFeatures; Manage invites menu visible.

Steps:

  1. Open app → log in as admin; Uber connected.
  2. LHN → Workspaces<W>Receipt partners.
  3. Tap Manage invites (mail icon).
  4. Verify Manage invites page opens with tabs All, Linked, Outstanding.
  5. Verify URL = /workspaces/<W>/receipt-partners/uber/invite/edit.
  6. Tap Back → verify return to Receipt partners.

Expected: Manage invites opens correctly; Back returns to Receipt partners (changed from dismissModal()).

Case 3.2 — Tab navigation (All → Linked → Outstanding)

Precondition: On Manage invites page (Case 3.1 step 4).

Steps:

  1. Tap Linked tab → verify URL segment ReceiptPartnersLinkedTab.
  2. Tap Outstanding tab → verify segment ReceiptPartnersOutstandingTab.
  3. Tap All tab → verify segment ReceiptPartnersAllTab.
  4. Each tab: verify list content loads; no "not here" page.

Expected: Tab URLs unchanged (refactor to CONST.TAB.RECEIPT_PARTNERS.* preserves public URL shape).

Case 3.3 — Refresh URL with tab suffix

Precondition: Linked tab URL from Case 3.2.

Steps:

  1. Paste https://dev.new.expensify.com:8082/workspaces/<W>/receipt-partners/uber/invite/edit/ReceiptPartnersLinkedTab → Enter.
  2. Verify Manage invites opens on Linked tab.
  3. Tap Back → Receipt partners.

Expected: Refresh restores the correct tab.

Case 3.4 — Read-only admin: Manage invites hidden

Precondition: User without canWriteMoreFeatures (auditor / read-only).

Steps:

  1. Log in as read-only member; Uber connected.
  2. Open Receipt partners → verify Manage invites is not shown.
  3. Paste manage-invites deeplink directly → verify Access denied / NotFound.

Expected: Read-only user cannot access manage invites flow.

@suneox

suneox commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

Manual test cases — PR #95253 · Issue #83835 (BT-107)

Migrate Workspace - Receipt Partners + Expensify Cards · author huult
PR: #95253 · Issue: #83835

DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS — Expensify Card details (workspace flow)
Case 1.1 — Entry: tap a card row from the Expensify Card list 1 1-1-before-card-list-root 1 1-2-entry-card-details 1 1-3-after-back-card-list-root
Case 1.2 — Entry: tap Expensify card from Member details (suffix on member URL) 1 2-1-before-member-details-cards 1 2-2-entry-card-details-member-suffix 1 2-3-after-back-member-details
Case 1.3 — Nested: Edit card name from details (DYNAMIC_EXPENSIFY_CARD_DETAILS entryScreen) 1 3-1-before-card-details 1 3-2-entry-edit-card-name 1 3-3-after-back-card-details
Case 1.4 — Nested: Edit limit type from details 1 4-1-before-card-details 1 4-2-entry-edit-limit-type 1 4-3-after-back-card-details
Case 1.5 — Nested: Edit card limit from details 1 5-1-before-card-details 1 5-2-entry-edit-card-limit 1 5-3-after-back-card-details
Case 1.6 — Refresh / deep-link on new card-details URL (list path) 1 6-1-before-card-list 1 6-2-entry-card-details-deeplink 1 6-3-after-back-card-list
Case 1.7 — Old URL card details → redirect to new path 1 7-1-before-card-details-oldurl 1 7-2-entry-card-details-redirected 1 7-3-after-back-card-list
Case 1.8 — Old nested edit URL → redirect to card-details + edit suffix 1 8-1-before-edit-name-oldurl 1 8-2-entry-edit-name-redirected 1 8-3-after-back-card-details
Case 1.9 — OldRoutes does not false-positive on sibling routes 1 9-1-before-card-list 1 9-2-entry-choose-bank-account-no-redirect 1 9-2-entry-issue-new-no-redirect 1 9-2-entry-settings-no-redirect

DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE — Uber invite after Receipt Partners connect
Case 2.1 — Auto-navigate to invite after Uber connect (useEffect) 2 1-1-before-receipt-partners-not-connected 2 1-2-entry-invite-auto-navigate 2 1-3-after-back-receipt-partners
Case 2.2 — Back from Send invites + All set screen (PR: dismissModal → goBack) 2 2-1-before-send-invites 2 2-2-entry-all-set-screen 2 2-3-after-back-receipt-partners
Case 2.3 — Refresh / deep-link invite URL 2 3-1-before-receipt-partners-list 2 3-2-entry-invite-deeplink 2 3-3-after-back-receipt-partners

DYNAMIC_ROUTES.WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT — Manage invites (All / Linked / Outstanding tabs)
Case 3.1 — Entry: tap Manage invites from Receipt Partners 3 1-1-before-receipt-partners-list 3 1-2-entry-manage-invites-default 3 1-3-after-back-receipt-partners-list
Case 3.2 — Tab navigation (All → Linked → Outstanding) 3 2-1-before-manage-invites-default 3 2-2-entry-tab-all 3 2-2-entry-tab-linked 3 2-2-entry-tab-outstanding
Case 3.3 — Refresh URL with tab suffix 3 3-1-before-receipt-partners-list 3 3-2-entry-linked-tab-deeplink 3 3-3-after-back-receipt-partners
Case 3.4 — Read-only admin: Manage invites hidden 3 4-1-before-admin-manage-invites-visible 3 4-2-entry-auditor-manage-invites-hidden

@suneox

suneox commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@huult All test cases passed. However, there is still an ESLint failure in DynamicEditInviteReceiptPartnerPolicyPage.tsx that needs to be fixed.

@huult

huult commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@suneox it's done

@melvin-bot melvin-bot Bot requested a review from mjasikowski July 8, 2026 16:43
@huult

huult commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@mjasikowski all yours

@mjasikowski mjasikowski merged commit fd39bff into Expensify:main Jul 9, 2026
35 checks passed
@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required

I reviewed the changes in this PR against Expensify's help site content under App/docs/articles, applying HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

Conclusion: No help site (HelpDot) changes are required, so I did not open a draft docs PR.

Why: This PR is a purely internal navigation/route-structure migration (the "dynamic routes" v2 pattern). It:

  • Renames screens/route constants (e.g. EXPENSIFY_CARD_DETAILSDYNAMIC_EXPENSIFY_CARD_DETAILS, RECEIPT_PARTNERS_INVITEDYNAMIC_RECEIPT_PARTNERS_INVITE) and renames the corresponding page components.
  • Restructures internal URL paths and adds OldRoutes.ts redirects so existing deep links keep working.
  • Contains no changes to src/languages/* copy, no new/renamed user-facing features, tabs, settings labels, or buttons, and no changes under docs/.

The QA steps confirm the goal is behavior parity (pages open and navigate back "normally"), i.e. nothing the end user sees changes. Help articles describe product behavior and UI, which are unaffected here.

If a future PR actually changes a user-facing flow, label, or feature in Receipt Partners or Expensify Card, that would be the point to update the corresponding help articles.

@huult, since no user-facing behavior changed, there is no linked help site PR to review. If you believe a docs update is nonetheless warranted (e.g. a UI/label change I may have missed), reply here with the specifics and I'll open a draft HelpDot PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #95892 was identified to be related to this PR.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #95968 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants