83835 migrate workspace receipt partners expensify cards v2#95253
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c265e2abe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…pace-receipt-partners-expensify-cards-v2
…pace-receipt-partners-expensify-cards-v2
…pace-receipt-partners-expensify-cards-v2
Manual test cases base on current code change
|
…pace-receipt-partners-expensify-cards-v2
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariManual test cases — PR #95253 · Issue #83835 (BT-107)
|
|
@huult All test cases passed. However, there is still an ESLint failure in |
…pace-receipt-partners-expensify-cards-v2
|
@suneox it's done |
|
@mjasikowski all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.33-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Expensify's help site content under Conclusion: No help site (HelpDot) changes are required, so I did not open a draft docs PR. Why: This PR is a purely internal navigation/route-structure migration (the "dynamic routes" v2 pattern). It:
The QA steps confirm the goal is behavior parity (pages open and navigate back "normally"), i.e. nothing the end user sees changes. Help articles describe product behavior and UI, which are unaffected here. If a future PR actually changes a user-facing flow, label, or feature in Receipt Partners or Expensify Card, that would be the point to update the corresponding help articles. @huult, since no user-facing behavior changed, there is no linked help site PR to review. If you believe a docs update is nonetheless warranted (e.g. a UI/label change I may have missed), reply here with the specifics and I'll open a draft |
|
Deploy Blocker #95892 was identified to be related to this PR. |
|
Deploy Blocker #95968 was identified to be related to this PR. |

















































Explanation of Change
Fixed Issues
$ #83835
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
WORKSPACE_RECEIPT_PARTNERS_INVITE
WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT
Preconditions:
WORKSPACE_EXPENSIFY_CARD_DETAILS
Preconditions:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
WORKSPACE_RECEIPT_PARTNERS_INVITE
WORKSPACE_RECEIPT_PARTNERS_INVITE_EDIT
Screen.Recording.2026-07-03.at.10.08.56.mov
WORKSPACE_EXPENSIFY_CARD_DETAILS
Screen.Recording.2026-07-03.at.10.14.21.mov