Fix supportal SAML redirect by hungvu193 · Pull Request #95270 · Expensify/App

hungvu193 · 2026-07-03T09:59:18Z

Explanation of Change

Currently, if a user logs in with SAML, we always redirect them to login page without checking if that's supportal session or not:

App/src/libs/Reauthentication.ts

Lines 178 to 183 in fec6b33

    
           if (account?.isSAMLRequired) { 
        
               Log.info(`[Reauthenticate] Redirecting to Sign In because SAML is required`); 
        
               setIsAuthenticating(false); 
        
               redirectToSignIn(undefined, true); 
        
               return false; 
        
           }

In this PR, we fix that by adding a condition to allow supportal session to skip login with SAML account.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/655776
PROPOSAL: N/A

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

As an Expensify employee with Supportal access, open Concierge or /_support/
Support-login into a customer account on a domain with SAML required (e.g. envato.com)
Confirm Classic/OldDot works while supportal-ed in
Click New Expensify (or open /_support/supportLoginNewDot)
Verify that you're landing in NewDot as the customer

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-07-04.at.13.06.43.mov

melvin-bot · 2026-07-04T06:13:27Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2026-07-04T06:14:16Z

cc @mountiny

I'm not sure if C+ can setup SAML and supportal

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4e1b4117f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny · 2026-07-05T16:19:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

mountiny

I dont think they can, I think this looks nice and safe and we can test in staging with internalQA

github-actions · 2026-07-05T16:22:58Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-07-05T16:24:41Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-07-05T16:25:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-05T16:28:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95270.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ef9e301e548-9f3daf7-2aee42f68a70ba689eabf0e76b5cd9a6e40d425c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ef9e301-9f3daf7-172bcd8e564fc53b546bd067f93588db8249eb22/index.html

Web 🕸️
https://95270.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2026-07-06T15:30:47Z

This was not Emergency the actions were green

OSBotify · 2026-07-06T15:47:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-06T15:50:34Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles, and no updates are needed.

Why: This PR is an internal-only fix. It adds a condition so that Supportal sessions (the Expensify employee support-login tool) skip the customer's SAML redirect in Reauthentication.ts and SignInPage.tsx. It does not change any customer-facing SAML/SSO login behavior.

Supportal is an internal tool and is not documented anywhere in App/docs/articles (no matches for "supportal").
The customer-facing SAML SSO articles (e.g. Set-Up-SAML-SSO.md, Troubleshoot-SAML-SSO-Login.md, Login-Troubleshooting.md) describe how customers set up and log in with SAML — that flow is unchanged by this PR.

Since the change is scoped entirely to the internal support-session code path, there is nothing to add or correct in the help site, so I did not open a docs PR.

@hungvu193, please confirm you agree that no help site changes are required. If you think a customer-facing article should be updated, let me know and I'll open a draft help site PR.

mountiny · 2026-07-07T13:59:27Z

Tested and worked well

OSBotify · 2026-07-07T17:55:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fix supportal SAML redirect

c4e1b41

melvin-bot Bot assigned hungvu193 Jul 3, 2026

hungvu193 marked this pull request as ready for review July 4, 2026 06:13

hungvu193 requested review from a team as code owners July 4, 2026 06:13

melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify July 4, 2026 06:13

melvin-bot Bot removed request for a team July 4, 2026 06:13

hungvu193 changed the title ~~fix supportal SAML redirect~~ Fix supportal SAML redirect Jul 4, 2026

github-actions Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/pages/signin/SignInPage.tsx Outdated

github-actions Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/pages/signin/SignInPage.tsx

chatgpt-codex-connector Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/pages/signin/SignInPage.tsx

hungvu193 added 4 commits July 4, 2026 13:25

create util to reuse

74f32c1

Fix AI review comment

2e398c7

merge main

f9a7b52

Fix prettier

9b5136f

mountiny removed the request for review from Pujan92 July 5, 2026 16:18

mountiny added the InternalQA This pull request required internal QA label Jul 5, 2026

mountiny approved these changes Jul 5, 2026

View reviewed changes

mountiny merged commit ef9e301 into Expensify:main Jul 5, 2026
33 of 34 checks passed

melvin-bot Bot added the Emergency label Jul 5, 2026

OSBotify mentioned this pull request Jul 6, 2026

Deploy Checklist: New Expensify 2026-07-06 #95398

Closed

46 tasks

mountiny removed the Emergency label Jul 6, 2026

	if (account?.isSAMLRequired) {
	Log.info(`[Reauthenticate] Redirecting to Sign In because SAML is required`);
	setIsAuthenticating(false);
	redirectToSignIn(undefined, true);
	return false;
	}

Uh oh!

Conversation

hungvu193 commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 4, 2026

Uh oh!

hungvu193 commented Jul 4, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mountiny commented Jul 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

melvin-bot Bot commented Jul 5, 2026

Uh oh!

OSBotify commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

mountiny commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

MelvinBot commented Jul 6, 2026

Uh oh!

mountiny commented Jul 7, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hungvu193 commented Jul 3, 2026 •

edited

Loading