[NoQA] Optimize CardUtils card filtering to avoid copying large card lists by VickyStash · Pull Request #95272 · Expensify/App

VickyStash · 2026-07-03T11:22:57Z

Explanation of Change

Refactors the workspace card-filtering helpers in CardUtils.ts to reduce peak memory usage when a card feed holds a large number of cards.

What this PR does:

Adds two shared iteration helpers that bake in the cardList-skip rule and iterate the card map in place (no intermediate copy):
- hasAssignedCardMatching(cardsList, predicate) — short-circuiting boolean scan (replaces the {cardList, ...rest} + Object.values().some() pattern).
- forEachAssignedCard(cardsList, callback) — side-effect/collect iteration (replaces {cardList, ...rest} + Object.values() when building a result).
filterAllInactiveCards now accepts the full WorkspaceCardsList and filters it in a single pass, skipping cardList internally (or passing it through when the new includeCardList flag is set), writing surviving cards by reference into one result object — no filterObject copy. The per-card "keep" rule is extracted into a reusable isActiveCard(card, includeDeactivated) predicate.
filterInactiveCards / filterInactiveCardsForWorkspace delegate straight to filterAllInactiveCards instead of rest-spreading + re-merging.
getAllCardsForWorkspace filters each matching feed straight into the accumulator, dropping the per-feed intermediate copy.
getCardsByCardholderName and getFilteredCardList collect via forEachAssignedCard instead of copying the map first.
isSmartLimitEnabled, hasPendingExpensifyCardAction, hasVirtualExpensifyCardMissingPersonalDetails, isCardAlreadyAssigned, and the hasIssuedExpensifyCardSelector selector use hasAssignedCardMatching (keeping their early-exit behavior).
Adds CONST.COMPANY_CARD.CARD_LIST for the cardList key literal so the skip is spelled consistently.

No behavior change — the same cards are kept/dropped/matched as before; only the allocation pattern changed.

Fixed Issues

$ #93916
PROPOSAL:

Tests

Verify that no errors appear in the JS console

No behavior change, we just need to confirm all works the same way as before.

Company cards

Open a workspace → Company cards
If you don't have cards -> setup feed and add cards
Verify the card list renders same way as on prod.
Open any card, see details displayed as usual.

Expensify card

Open a workspace → Expensify Card
If you don't have any cards issue some.
Verify the card list renders same way as on prod.
Open any card, see details dispaly as usual.

Offline tests

Same, as in Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in Tests section

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

ExpensifyCards.mp4

CompanyCards.mp4

NewCardIssue.mp4

codecov · 2026-07-03T11:27:44Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.81% <ø> (ø)`
src/selectors/Card.ts	`89.74% <100.00%> (-0.26%)`	⬇️
src/libs/CardUtils.ts	`82.92% <91.66%> (+0.58%)`	⬆️
... and 36 files with indirect coverage changes

# Conflicts: # src/libs/CardUtils.ts

github-actions · 2026-07-06T21:13:09Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

VickyStash · 2026-07-07T16:09:54Z

@codex review

chatgpt-codex-connector · 2026-07-07T16:13:47Z

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 87e3454ece

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

# Conflicts: # src/libs/CardUtils.ts

VickyStash · 2026-07-08T09:55:58Z

@codex review

chatgpt-codex-connector · 2026-07-08T10:01:01Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: dc6453fc56

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-07-08T10:27:47Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-07-08T10:47:37Z

Can you add unit tests for these?

Added in c6744a6

eh2077 · 2026-07-08T11:41:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-08.at.9.25.15.PM.mov

eh2077

looks good! the refactoring brings better memory efficiency and the functionality remains unchanged.

OSBotify · 2026-07-08T14:37:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T14:51:32Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-08T15:03:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95272.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0ff2d8b53c2-ee2dd9f-fe62a3b0bdfcf3a4f1694d87ced58ce9237f78b8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0ff2d8b-ee2dd9f-f3d05acb0f666b450fc30a1f5f64d1d3a6dbd5dd/index.html

Web 🕸️
https://95272.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:06:02Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:07:51Z

🤖 Help site review: no changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles, and no documentation updates are required.

Why: This is a purely internal code refactor with no user-facing impact:

src/libs/CardUtils.ts — refactors card-filtering helpers (hasAssignedCardMatching, forEachAssignedCard, filterAllInactiveCards, etc.) to iterate the card map in place and avoid intermediate copies, reducing peak memory usage.
src/CONST/index.ts — adds an internal CARD_LIST key literal.
src/selectors/Card.ts — updates a selector to use the new helper.
tests/unit/CardUtilsTest.ts — adds unit tests.

The PR is titled [NoQA] and its description explicitly states "No behavior change — the same cards are kept/dropped/matched as before; only the allocation pattern changed." The help site documents user-facing product behavior (company cards, Expensify Card, workspaces, etc.), and none of that behavior changes here — the card lists render and function exactly as before.

Since there are no user-facing changes, I did not create a draft help site PR.

OSBotify · 2026-07-10T13:43:05Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

VickyStash added 2 commits July 3, 2026 11:57

Minor improvements

f82ddb4

Reduce memory usage when filtering large workspace card lists

415a0f6

melvin-bot Bot assigned VickyStash Jul 3, 2026

Merge branch 'main' into VickyStash/refactor/company-cards-optimizations

87e3454

# Conflicts: # src/libs/CardUtils.ts

This comment has been minimized.

Sign in to view

VickyStash added 4 commits July 8, 2026 10:07

Merge branch 'main' into VickyStash/refactor/company-cards-optimizations

ae11825

# Conflicts: # src/libs/CardUtils.ts

Remove rest-spread card copies

f5053b7

Add forEachAssignedCard util function

6b21ad0

Minor clean up

dc6453f

VickyStash marked this pull request as ready for review July 8, 2026 10:27

VickyStash requested review from a team as code owners July 8, 2026 10:27

melvin-bot Bot requested review from JmillsExpensify and eh2077 and removed request for a team July 8, 2026 10:27

melvin-bot Bot removed the request for review from a team July 8, 2026 10:27

mountiny requested changes Jul 8, 2026

View reviewed changes

VickyStash changed the title ~~Optimize CardUtils card filtering to avoid copying large card lists~~ [NoQA] Optimize CardUtils card filtering to avoid copying large card lists Jul 8, 2026

Add unit tests

c6744a6

eh2077 approved these changes Jul 8, 2026

View reviewed changes

Comment thread src/libs/CardUtils.ts Outdated

melvin-bot Bot requested a review from mountiny July 8, 2026 13:35

Minor improvement

134f21d

mountiny approved these changes Jul 8, 2026

View reviewed changes

mountiny merged commit 0ff2d8b into Expensify:main Jul 8, 2026
35 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] [$250] NewDot web tab crashes silently (renderer OOM kill) under high memory / large Onyx dataset #93916

Open

4 tasks

Uh oh!

Conversation

VickyStash commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

This comment has been minimized.

VickyStash commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

VickyStash commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

melvin-bot Bot commented Jul 8, 2026

Uh oh!

mountiny Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Jul 3, 2026 •

edited

Loading

codecov Bot commented Jul 3, 2026 •

edited by github-actions Bot

Loading

eh2077 commented Jul 8, 2026 •

edited

Loading