Skip to content

[Payment due @ahmedGaber93] [No QA] Docs updates for E/A#94511 attendee columns sortable in report view#95295

Merged
sakluger merged 1 commit into
mainfrom
docs-attendee-sort-report-view
Jul 8, 2026
Merged

[Payment due @ahmedGaber93] [No QA] Docs updates for E/A#94511 attendee columns sortable in report view#95295
sakluger merged 1 commit into
mainfrom
docs-attendee-sort-report-view

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Docs follow-up for #94511, which makes the Attendees and Per attendee columns sortable in the single expense report view (previously they were only sortable in Search / Reports > Expenses).

The help article Adding Attendees previously described sorting by these columns only in search results. This PR updates the How to view attendees on a report section to note that, once the Attendees and Per attendee columns are shown in a report, you can click either column header to sort the report's expenses by that column. The article description was also broadened to mention sorting in a report as well as in search results.

Related PR

Fixed Issues

N/A — documentation-only follow-up.


@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

…view

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 3, 2026
@ahmedGaber93

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR Ready for review.

@MelvinBot MelvinBot marked this pull request as ready for review July 3, 2026 17:08
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

IyMgSGVscERvdCBEb2N1bWVudGF0aW9uIFJldmlldw==

@ahmedGaber93 ahmedGaber93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In #94124, we display those columns on the report page, so documenting those steps to explain how to display them on the report page looks good.

@melvin-bot melvin-bot Bot changed the title Docs updates for E/A#94511 attendee columns sortable in report view [Payment due @ahmedGaber93] Docs updates for E/A#94511 attendee columns sortable in report view Jul 3, 2026
@melvin-bot

melvin-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🎯 @ahmedGaber93, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, well-scoped documentation follow-up to #94511. It adds one paragraph under the existing How to view attendees on a report section explaining that the Attendees and Per attendee columns can be shown in a report and clicked to sort the report's expenses, and broadens the article description to mention sorting in a report as well as in search results. The change is accurate, focused, and consistent with the surrounding content.

Scores Summary

  • Readability: 9/10 - Clear, concise, action-oriented sentences; instructions flow logically and are easy to scan.
  • AI Readiness: 9/10 - Content sits under a valid task-based How to view attendees on a report heading, uses full feature/column names, and the broadened description improves search intent matching. No heading-hierarchy issues introduced.
  • Style Compliance: 8/10 - UI labels (Columns, Attendees, Per attendee) are correctly bolded and in Sentence case. One minor terminology inconsistency (see below).

Key Findings

  • Positive: The addition is tightly scoped to a single workflow, correctly bolds all UI labels, and reuses the existing task-based section rather than introducing a new heading.
  • Positive: The description update accurately reflects the new sortable-in-report behavior and matches likely search phrasing.
  • Minor: The new sentence instructs users to select Per attendee, while the existing search-results steps in the same section (step 3) say Per attendee amount. If the report column label and the search filter label genuinely differ, that is fine, but if they should match, align them to the exact UI text to avoid ambiguity.

Recommendations

  • Verify the exact in-product label for the report column and confirm whether it is Per attendee or Per attendee amount, then make the two references consistent (or intentionally distinct if the UI differs).
  • No structural, metadata, or heading changes required.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Adding-Attendees.md - Approve with one minor label-consistency check.

Overall recommendation: Approve (address the minor Per attendee vs Per attendee amount label consistency as a nice-to-have).

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott changed the title [Payment due @ahmedGaber93] Docs updates for E/A#94511 attendee columns sortable in report view [Payment due @ahmedGaber93] [No QA] Docs updates for E/A#94511 attendee columns sortable in report view Jul 6, 2026
@stephanieelliott stephanieelliott requested a review from a team July 7, 2026 21:21
@melvin-bot

melvin-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sakluger

@melvin-bot melvin-bot Bot requested review from sakluger and removed request for a team July 7, 2026 21:21
@melvin-bot

melvin-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

@sakluger Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@sakluger sakluger merged commit 3dcf9c9 into main Jul 8, 2026
20 checks passed
@sakluger sakluger deleted the docs-attendee-sort-report-view branch July 8, 2026 21:34
@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants