Show the travel card icon for other members' travel expenses by allgandalf · Pull Request #95320 · Expensify/App

allgandalf · 2026-07-04T09:40:03Z

Explanation of Change

The travel card icon only showed for your own travel expenses. TypeCell derived it from isTravelCard(card), and card comes from your own card list (cardList in Onyx), so another member's travel card resolved to undefined and fell back to the generic Expensify Card icon. The card name column worked for everyone because that string is resolved on the backend and ships on the transaction.

The backend now sends feedCountry on the transaction, so this keys the icon on transaction.feedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_US and keeps isTravelCard(card) as a fallback for old cached transactions that predate the field. The icon fix lives in TypeCell, so it covers every surface that renders it (search, report view, unreported expenses, duplicate/merge, recently added). Also keyed the card name column on feedCountry so another member's travel expense shows the localized name, not just the fixed backend string.

Depends on the backend change that adds feedCountry to the flat search response.

Fixed Issues

$ #95078
PROPOSAL:

Tests

On a travel billing enabled workspace, sign in as an admin
Go to Search and open the Expenses view
Find a travel card expense that belongs to another member of the workspace (not one of your own expenses)
Verify it shows the travel card icon (card with a plane), the same icon your own travel expenses show
Verify the Card column for that expense shows the travel invoicing name
Verify your own travel expenses and regular Expensify Card expenses still show the correct icons

Verify that no errors appear in the JS console

Offline tests

Load the Expenses search once while online so the results are cached
Turn off the network connection
Verify another member's travel expense still shows the travel card icon and the travel invoicing name (the icon and name derive from feedCountry on the cached transaction, no network call)

QA Steps

On a travel billing enabled workspace, sign in as an admin
Go to Search and open the Expenses view
Find a travel card expense that belongs to another member of the workspace
Verify it shows the travel card icon (card with a plane), the same as your own travel expenses
Verify the Card column shows the travel invoicing name
Verify regular Expensify Card and personal card expenses still show the correct icons

Verify that no errors appear in the JS console

PR Author Checklist

… other members

…ed-country # Conflicts: # src/components/TransactionItemRow/DataCells/TypeCell.tsx

melvin-bot · 2026-07-09T11:56:40Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2026-07-09T11:58:18Z

@blimpich @rlinoz can you please help QA this with your production data

codecov · 2026-07-09T14:17:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...mponents/TransactionItemRow/DataCells/TypeCell.tsx	`77.35% <100.00%> (ø)`
src/components/TransactionItemRow/index.tsx	`83.05% <100.00%> (ø)`
src/libs/CardUtils.ts	`82.96% <100.00%> (+0.04%)`	⬆️
src/libs/DebugUtils.ts	`68.82% <100.00%> (+0.06%)`	⬆️
... and 29 files with indirect coverage changes

github-actions · 2026-07-09T15:54:53Z

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

blimpich · 2026-07-09T16:17:44Z

Works! Nice job!

rlinoz · 2026-07-09T16:21:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-07-09T16:27:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-09T18:19:03Z

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T18:38:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95320.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-097c26f8de5-54ebcb2-bb03a9a097ae6971890bb609205dcc99c2ae9d35/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-097c26f-54ebcb2-2fe837f51686cdd50045ab0ac2131f31c870dc92/index.html

Web 🕸️
https://95320.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:19:05Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:22:23Z

🤖 No help site changes required — I did not create a docs PR.

Why: This PR is an internal icon/name-rendering bug fix. It makes the travel card icon (and the localized "Travel invoicing" card-name column) show correctly for another member's travel expenses in Search by keying on the new transaction.feedCountry field instead of the viewer's own cardList. Nothing user-facing changes in terms of features, settings, tab names, buttons, or workflows — the icon simply renders correctly where it previously fell back to the generic Expensify Card icon.

I reviewed docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md, and searched docs/articles/ — there are no help articles that document the travel card icon or the "Travel invoicing" label, so there is nothing to update. Help-site articles document behaviors and workflows, and a visual bug fix like this doesn't introduce or alter any documented behavior.

If you believe a specific article should cover travel card expenses in Search and want me to draft one, reply with the article path (or a description of what it should say) and I'll create the draft PR.

@allgandalf, please confirm you agree no help site changes are needed here. If you'd like docs coverage anyway, let me know and I'll open a draft PR.

mvtglobally · 2026-07-13T02:00:53Z

@blimpich @rlinoz
After toggling Travel invoicing on, add a bank account and book travel with the Travel card ,the Travel expense does not appear, it keeps the Processing state on the Travel page. We also tried alternative way: invite a member and use that member to book in the normal way using the CCard in the TC; it works, it shows the Expense Cash icon, not the Travel icon. How can we book with the Travel card to execute this PR?

travel_invoice.mp4

IuliiaHerets · 2026-07-13T07:33:36Z

Hi @allgandalf. We're trying to follow the QA steps, but we're unable to create a Travel card expense to verify the expected behavior.

We enabled Travel invoicing, added a bank account, and booked travel with the Travel card, but the expense never appeared—it stayed in the Processing state on the Travel page. We also tried booking travel from another workspace member's account, but that created a regular expense with the Cash icon instead of a Travel icon.

Could you clarify the correct workflow for creating a Travel card expense for this test? Are there any additional setup steps or requirements that aren't included in the QA steps?

Or can you check this internally?

cc @rlinoz @blimpich

travel_invoice.mp4

allgandalf · 2026-07-13T09:44:57Z

@blimpich @rlinoz can any of you please QA this internally, we already tested on @blimpich live data, so this should be all good

rlinoz · 2026-07-13T13:35:23Z

I think we are good

Screen.Recording.2026-07-13.at.10.34.53.mov

blimpich · 2026-07-13T16:22:14Z

I can also verify this works on staging 👍

allgandalf added 5 commits July 4, 2026 14:48

Add feedCountry to the Transaction type

290bb71

Derive travel card from the transaction feedCountry with a card fallback

e9ec204

Key the travel card icon on the transaction feedCountry

929b6a8

Pass feedCountry to the card name column so travel names localize for…

680cb96

… other members

Add tests for feedCountry-based travel card detection

bf75259

melvin-bot Bot assigned allgandalf Jul 4, 2026

Merge branch 'Expensify:main' into travel-card-icon-feed-country

7889654

allgandalf mentioned this pull request Jul 9, 2026

Travel Card Icon is wrong when an admin is looking at spend view #95078

Open

Merge remote-tracking branch 'upstream/main' into travel-card-icon-fe…

c93984a

…ed-country # Conflicts: # src/components/TransactionItemRow/DataCells/TypeCell.tsx

allgandalf requested review from blimpich and rlinoz July 9, 2026 11:55

allgandalf marked this pull request as ready for review July 9, 2026 11:56

allgandalf requested review from a team as code owners July 9, 2026 11:56

melvin-bot Bot requested review from ChavdaSachin and JmillsExpensify and removed request for a team July 9, 2026 11:56

melvin-bot Bot removed the request for review from a team July 9, 2026 11:56

allgandalf removed request for ChavdaSachin and JmillsExpensify July 9, 2026 11:56

Handle feedCountry in the Transaction debug property validator

d5aa319

blimpich added the Ready To Build label Jul 9, 2026

This comment has been minimized.

Sign in to view

blimpich approved these changes Jul 9, 2026

View reviewed changes

rlinoz approved these changes Jul 9, 2026

View reviewed changes

rlinoz merged commit 097c26f into Expensify:main Jul 9, 2026
34 of 35 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

82 tasks

Uh oh!

Conversation

allgandalf commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

allgandalf commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

This comment has been minimized.

blimpich commented Jul 9, 2026

Uh oh!

rlinoz commented Jul 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

mvtglobally commented Jul 13, 2026

Uh oh!

IuliiaHerets commented Jul 13, 2026

Uh oh!

allgandalf commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rlinoz commented Jul 13, 2026

Uh oh!

blimpich commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

allgandalf commented Jul 4, 2026 •

edited

Loading

codecov Bot commented Jul 9, 2026 •

edited by github-actions Bot

Loading

allgandalf commented Jul 13, 2026 •

edited

Loading