Skip to content

Fix Sage Intacct default vendor toggle crash when vendors list is empty#95345

Merged
stitesExpensify merged 2 commits into
mainfrom
fix/sentry-app-h08-sage-intacct-vendor-toggle
Jul 6, 2026
Merged

Fix Sage Intacct default vendor toggle crash when vendors list is empty#95345
stitesExpensify merged 2 commits into
mainfrom
fix/sentry-app-h08-sage-intacct-vendor-toggle

Conversation

@mountiny

@mountiny mountiny commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixes a production crash when toggling the Sage Intacct "Default vendor" switch while the synced vendors list is empty. Optional chaining previously stopped at vendors?.[0], so accessing .id on an undefined first element threw. Applied the same defensive pattern used in QBO export pages to both reimbursable and non-reimbursable Sage Intacct export settings.

Fixed Issues

$ #95342
PROPOSAL:

Tests

  1. Open a workspace connected to Sage Intacct with no vendors in the connection data (or before vendor sync completes).
  2. Navigate to Accounting → Sage Intacct → Export → Reimbursable expenses.
  3. Toggle Default vendor ON and verify no JS console error appears.
  4. Navigate to Non-reimbursable expenses export settings and repeat step 3.
  5. Verify that no errors appear in the JS console.

Offline tests

Same as tests — toggle works offline with cached policy data; no network required for the guard itself.

QA Steps

  1. Open a Control workspace with Sage Intacct connected.
  2. Navigate to Accounting → Sage Intacct → Export → Reimbursable expenses.
  3. Toggle Default vendor ON when no vendors are available in the dropdown/list.
  4. Confirm the toggle enables without a crash and no error appears in the JS console.
  5. Repeat on Non-reimbursable expenses export page.
  6. Verify that no errors appear in the JS console.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny @cursoragent
Fix Sage Intacct default vendor toggle when vendors list is empty
fa79294 
Optional-chain through vendors[0]?.id on both reimbursable and
non-reimbursable export pages to prevent a crash when enabling the
default vendor toggle with an empty vendors array.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mountiny mountiny requested review from a team as code owners July 5, 2026 19:56
@melvin-bot melvin-bot Bot requested review from a team, QichenZhu and heyjennahay and removed request for a team July 5, 2026 19:56
@melvin-bot

melvin-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 5, 2026 19:56
This was referenced Jul 5, 2026
Open
Open
@codecov

codecov Bot commented Jul 5, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
.../export/SageIntacctNonReimbursableExpensesPage.tsx 0.00% <0.00%> (ø)
...cct/export/SageIntacctReimbursableExpensesPage.tsx 0.00% <0.00%> (ø)
... and 79 files with indirect coverage changes

@QichenZhu

QichenZhu commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
    https://expensify.slack.com/archives/C049HHMV9SM/p1783323431995659
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen_recording_20260706_185817.webm
Android: mWeb Chrome
Screen_recording_20260706_191036.webm
iOS: HybridApp
Screen.Recording.2026-07-06.at.6.10.03.PM.mov
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-07-06.at.19.08.17.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-06.at.6.49.36.PM.mov

@QichenZhu

QichenZhu commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Author checklist

Explanation of Change

Fixes a production crash when enabling the Sage Intacct "Default vendor" switch while the synced vendors list is empty.

Fixed Issues

$ #95342
PROPOSAL:

Tests

  1. Open a workspace connected to Sage Intacct with no vendors in the connection data (or newly connect to Sage Intacct and perform the below steps quickly before vendor sync completes).
  2. Navigate to Accounting → Sage Intacct → Export → Export out-of-pocket expenses as/Export company card expenses as.
  3. Switch on Default vendor and verify the app doesn't crash and no JS console error appears.

Offline tests

Cannot perform the test offline.

QA Steps

Same as Tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
    https://expensify.slack.com/archives/C049HHMV9SM/p1783323431995659
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_recording_20260706_185817.webm
Android: mWeb Chrome
Screen_recording_20260706_191036.webm
iOS: Native
Screen.Recording.2026-07-06.at.6.10.03.PM.mov
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-07-06.at.19.08.17.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-06.at.6.49.36.PM.mov

QichenZhu
QichenZhu approved these changes Jul 6, 2026
View reviewed changes

@QichenZhu QichenZhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tap the switch when the list is empty, it's still OFF, but you can access the vendor list. It's much better than a crash, so NAB.

Before After
Screen.Recording.2026-07-06.at.6.20.45.PM.mov
Screen.Recording.2026-07-06.at.6.10.03.PM.mov

Also, ESLint is failing.

@melvin-bot melvin-bot Bot requested a review from stitesExpensify July 6, 2026 07:45
@melvin-bot

melvin-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny @cursoragent
Remove empty-string default on Sage Intacct vendor ID
287c972 
Optional chaining on vendors[0]?.id already prevents the crash;
no-default-id-values disallows ?? '' on string IDs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@stitesExpensify stitesExpensify merged commit cde5012 into main Jul 6, 2026
40 of 43 checks passed
@stitesExpensify stitesExpensify deleted the fix/sentry-app-h08-sage-intacct-vendor-toggle branch July 6, 2026 18:29
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95345.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cde5012031c-163e75a-09c9c5b4ef34a5e22121d06788e6c9a4035d3ec2/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cde5012-163e75a-13b87723a63404f874decf6c092a99976786c786/index.html
Android iOS
Web 🕸️
https://95345.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Jul 7, 2026
Closed
77 tasks
@OSBotify

OSBotify commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.29-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required.

This PR is a purely internal defensive crash fix — it adds optional chaining (vendors?.[0]?.id) so toggling Default vendor with an empty synced vendors list no longer throws. There is no change to any user-facing behavior, feature, UI label, button, tab, or flow, so nothing in the help site needs updating.

I reviewed the existing Sage Intacct help articles (App/docs/articles/new-expensify/connections/sage-intacct/ and the Expensify Classic equivalents) and none of them document the internal behavior this fix touches. The documented setup and export configuration steps remain accurate.

No draft PR was created since no documentation updates are needed.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Help site review — no changes required

I reviewed the changes in this PR against the help site content under App/docs/articles.

Conclusion: No help site updates are needed.

This PR is a defensive crash fix — it adds an optional-chaining operator (vendors?.[0]?.id instead of vendors?.[0].id) on both the Sage Intacct reimbursable and non-reimbursable export pages so that toggling Default vendor no longer throws when the synced vendors list is empty. It introduces no new feature, no UI label change, no new setting, and no change to any documented user-facing workflow. The Sage Intacct export behavior described in the help site remains accurate.

Because there is no behavior or terminology change for users, no draft docs PR was created — there is nothing to document.

@mountiny, if you believe a help site change is still warranted here, let me know and I'll draft one. Otherwise, no linked help site PR is needed for this change.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes
@heyjennahay heyjennahay Awaiting requested review from heyjennahay
@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify
+1 more reviewer
@QichenZhu QichenZhu QichenZhu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mountiny mountiny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mountiny @QichenZhu @OSBotify @MelvinBot @stitesExpensify