[No QA] fix: checkout Mobile-Expensify PR before calling Setup Node action#95386
Merged
mountiny merged 1 commit intoJul 6, 2026
Merged
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
approved these changes
Jul 6, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
46 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.28-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR fixes and reworks how the
Remote Build iOSandRemote Build Androidworkflows resolve and check out a specificMobile-Expensifysubmodule ref for hybrid ad-hoc builds.The fix (primary change)
Previously the "Checkout specific Mobile-Expensify PR" step ran after the
Setup Nodecomposite action.Setup Noderelies on theMobile-Expensifysubmodule contents (dotenv merging, dependency install, etc.), so checking out the target PR afterwards meant Node was set up against the wrong ref. This PR moves theMobile-Expensifycheckout so it runs beforeSetup Node.This aligns the ad-hoc build workflows with the URL-based resolution used elsewhere and makes it possible to trigger a hybrid build directly from an App PR link.
Fixed Issues
$ #95387
PROPOSAL:
Tests
Remote Build iOS(andRemote Build Android) workflow viaworkflow_dispatchwith anapp_pull_request_urlpointing at an App PR whose description contains aMOBILE-EXPENSIFY:link.Resolve Mobile-Expensify refjob runs first and resolves the expectedMOBILE_EXPENSIFY_REF/ PR number.buildjob checks out the resolvedMobile-Expensifyref before theSetup Nodestep runs (check the "Checkout Mobile-Expensify to specified branch or commit" log line appears before "Setup Node").mobile_expensify_pull_request_urldirectly and verify it overrides the ref resolved from the App PR description.Offline tests
N/A — CI workflow change only.
QA Steps
[No QA]
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — CI workflow change only.
Android: mWeb Chrome
N/A — CI workflow change only.
iOS: Native
N/A — CI workflow change only.
iOS: mWeb Safari
N/A — CI workflow change only.
MacOS: Chrome / Safari
N/A — CI workflow change only.