Fix "Let's go" migrate welcome button redirects to Inbox instead of Spend page after completing the demo by jmusial · Pull Request #95399 · Expensify/App

jmusial · 2026-07-06T15:25:06Z

Explanation of Change

Fixed Issues

$ #95228
PROPOSAL:

Tests

Open app
In console paste

Onyx.merge('nvp_tryNewDot', {
    nudgeMigration: { timestamp: new Date(), cohort: 'test' }
});

Onyx.merge('nvp_dismissedProductTraining', { migratedUserWelcomeModal: null });

Click the "Let's go" button (if you watch the video it should behave the same)
Observe the page the user is redirected to Spend

Offline tests

same as tests

QA Steps

Log in as a Migrated user
Click on the 2-minute demo on the modal
Watch the demo until completion
Navigate back to New Expensify
Click the "Let's go" button
Observe the page the user is redirected to Spend

PR Author Checklist

Screenshots/Videos

iOS: Native

Screen.Recording.2026-07-06.at.19.09.32.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-06.at.19.08.59.mov

jmusial · 2026-07-06T15:25:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d8eabd9f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-06T15:31:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MigratedUserWelcomeModal.tsx	`0.00% <0.00%> (ø)`
... and 74 files with indirect coverage changes

jmusial · 2026-07-06T17:10:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46b57ae644

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-06T17:14:26Z

    };

-    useBeforeRemove(handleDismiss);
+    useBeforeRemove(persistDismissal);


Route back dismissals to Spend

When this modal is removed by React Navigation directly (for example Android system back, browser back, or any GO_BACK/DISMISS_MODAL path that does not invoke handleClose), this beforeRemove listener is the only code that runs. It now only persists the dismissal, so those paths still pop back to the modal's base route (often Inbox) instead of scheduling the Spend search navigation that previously ran from beforeRemove. Consider sharing the Spend redirect with all dismissal paths or making every allowed dismissal go through the same close handler.

Useful? React with 👍 / 👎.

I think this is ok when user dismisses the modal on purpose @trjExpensify ?

Yeah, I think so too. 👍

melvin-bot · 2026-07-06T17:16:55Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

07.07.2026_01.55.13_REC.mp4

🎀 👀 🎀 C+ reviewed

melvin-bot · 2026-07-06T20:25:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #95228 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

jmusial · 2026-07-06T20:27:05Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #95228 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

cc. @mountiny

parasharrajat · 2026-07-06T20:36:38Z

Closing the modal by backdrop click also takes the user to spend. I think it is expected.

cc: @jmusial @mountiny Do you agree?

jmusial · 2026-07-07T07:33:40Z

Closing the modal by backdrop click also takes the user to spend. I think it is expected.

cc: @jmusial @mountiny Do you agree?

That was the plan, I can change it if needed

Beamanator · 2026-07-07T17:44:28Z

@mountiny are you being summoned to review here or shall I? 😅

jmusial · 2026-07-08T10:50:49Z

@Beamanator it's a regression from a #93815 and he was approver there, tagged for visibility.

flaviadefaria · 2026-07-08T14:53:21Z

It looks like the regression also affects when the user clicks the "Let's go" button and when they click outside the modal. Perhaps we should fix it all here? In all cases, they are kept in the Inbox page instead of being routed to the Spend page.

Beamanator

Looking good here!

OSBotify · 2026-07-08T15:26:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T15:51:59Z

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-08T16:05:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95399.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1276413760b-ee2dd9f-fe62a3b0bdfcf3a4f1694d87ced58ce9237f78b8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1276413-ee2dd9f-f3d05acb0f666b450fc30a1f5f64d1d3a6dbd5dd/index.html

Web 🕸️
https://95399.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:06:23Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:08:47Z

🤖 No help site changes required.

This PR is a purely internal navigation fix: it changes where the migrated-user welcome modal sends the user. The "Let's go" / close action now redirects to the Spend page (canned expense-report search) after the transition, instead of falling through to the Inbox, and the dismissal-persistence logic was refactored into persistDismissal. See src/components/MigratedUserWelcomeModal.tsx.

I reviewed App/docs/articles against the change:

No help article documents the welcome modal's post-demo redirect destination, so there's no user-facing behavior described in the docs that this fix contradicts.
The related "getting started"/transition articles only link out to the interactive Storylane tours (e.g. How-to-Access-Expensify-Training.md, Navigating-New-Expensify.md); none reference which screen the modal lands on.

Because this is a bug fix restoring intended behavior (not a new/changed user-facing feature or copy), no draft docs PR was created — there's no linked help site PR to review.

@jmusial, if you believe a help site article should document this flow, let me know and I'll create a draft PR. Otherwise no docs action is needed here.

OSBotify · 2026-07-10T13:43:26Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix migrated user modal redirect

1d8eabd

melvin-bot Bot assigned jmusial Jul 6, 2026

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread src/components/MigratedUserWelcomeModal.tsx Outdated

jmusial added 2 commits July 6, 2026 18:55

fix browser back issue

9e9cbcd

remove reundant ref

46b57ae

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

jmusial marked this pull request as ready for review July 6, 2026 17:16

jmusial requested review from a team as code owners July 6, 2026 17:16

melvin-bot Bot requested review from parasharrajat and removed request for a team July 6, 2026 17:16

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 6, 2026 17:17

jmusial mentioned this pull request Jul 6, 2026

[Due for payment 2026-07-17] [$250] "Let's go" migrate welcome button redirects to Inbox instead of Spend page after completing the demo #95228

Open

7 tasks

parasharrajat approved these changes Jul 6, 2026

View reviewed changes

melvin-bot Bot requested a review from Beamanator July 6, 2026 20:26

Beamanator approved these changes Jul 8, 2026

View reviewed changes

Beamanator merged commit 1276413 into Expensify:main Jul 8, 2026
38 of 42 checks passed

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

Uh oh!

Conversation

jmusial commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented Jul 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jul 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Jul 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 6, 2026

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

melvin-bot Bot commented Jul 6, 2026

Uh oh!

jmusial commented Jul 6, 2026

Uh oh!

parasharrajat commented Jul 6, 2026

Uh oh!

jmusial commented Jul 7, 2026

Uh oh!

Beamanator commented Jul 7, 2026

Uh oh!

jmusial commented Jul 8, 2026

Uh oh!

flaviadefaria commented Jul 8, 2026

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jmusial commented Jul 6, 2026 •

edited

Loading

codecov Bot commented Jul 6, 2026 •

edited by github-actions Bot

Loading