Fix: domain groups crash#95484
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.29-0 🚀
|
|
🤖 No help site changes required. This PR is a pure crash fix — it adds a missing There is no user-facing behavior change, no new/renamed feature, and no changed UI labels, steps, settings, or workflows. The documented behavior of domain groups (e.g. Create-and-Manage-Domain-Groups.md) is unchanged — the fix simply restores the intended, already-documented behavior. Nothing under @marufsharifi, since no docs changes are needed there is no help site PR to review. If you believe a docs update is warranted, let me know what behavior changed and I'll draft one. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.31-0 🚀
|
|
🤖 Help site review — no changes required I reviewed the changes in this PR. This is a pure code-level bug fix: it adds a missing There is no user-facing behavior change, no new feature, and no new/renamed UI element, setting, tab, or button introduced by this change — it only restores the existing screen from crashing. Because the help site documents product behavior and flows (not internal React imports), nothing under Since no documentation update is warranted, I did not create a draft help site PR. @marufsharifi, if you disagree and believe a specific help article should be updated for this change, let me know which one and I'll create the draft help site PR. Otherwise, no help site PR is needed here for you to review. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Same as QA Steps.
Offline tests
Same as QA Steps.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari