Prevent empty values for mandatory fields in CSV Card Import by Gonals · Pull Request #95488 · Expensify/App

Gonals · 2026-07-07T12:50:58Z

Explanation of Change

Fixed Issues

$ #93704
PROPOSAL:

Tests

Go to Workspace > Company Cards > Add cards > USA > Import from file and import a file with an empty column. You can use this one:
Expensify_usd.xlsx
Map the mandatory fields.
Confirm it doesn't let you map a column with empty fields:

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-07-07T12:55:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...e/companyCards/addNew/CompanyCardsImportedPage.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

melvin-bot · 2026-07-07T13:07:58Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2026-07-07T13:10:12Z

+            return errors;
+        }
+
+        const columnWithEmptyValues = requiredColumns.find((requiredColumn) => {


@Gonals, I think we should throw an error only if all values in the column are empty. Otherwise, the check will become too rigid.

I disagree. These fields are mandatory. No transactions should be missing them

Since no one responded in Slack thread. Let's proceed with this as it is.

shubham1206agra · 2026-07-08T12:49:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

melvin-bot · 2026-07-08T12:52:51Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-07-08T20:40:20Z

🚧 youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-08T20:45:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T20:49:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95488.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e7536fe68e8-af7837c-0bcbdefb8be20baf0ecf6048cd7a7ee9de0f28ad/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e7536fe-af7837c-088b7f64fc54efc914a619ca03252a95333703c0/index.html

Web 🕸️
https://95488.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-09T11:06:56Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-09T11:09:49Z

🤖 I reviewed the changes in this PR against the help site articles under docs/articles.

Yes, a help site update is warranted. This PR adds a new user-facing validation to the Import transactions from file flow: mapping a required field (Card Number, Date, Amount, or Merchant) to a spreadsheet column that contains empty values now shows an error (Oops! The field ("…") contains one or more empty values.) and blocks the import.

The Import Company Card Transactions From a Spreadsheet article already documents the related "map the same column twice" error but didn't cover empty-value validation, so I added a short FAQ entry to match.

Draft PR: #95688 (labeled HelpDot, assigned to you)

What I checked

Scanned docs/articles/new-expensify/connect-credit-cards and the classic equivalents for CSV/spreadsheet card import content.
Only the company card import page (CompanyCardsImportedPage.tsx) was changed, so I scoped the docs update to the company card spreadsheet article and left the personal card article untouched.
Applied HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md: the addition is a task/question-based ## FAQ heading and uses the field labels exactly as they already appear in the article.

@Gonals, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-07-10T13:43:59Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Gonals added 2 commits July 7, 2026 14:39

Add better validation

8d60e76

Merge branch 'main' into alberto-emptyCols

5870949

Gonals self-assigned this Jul 7, 2026

Gonals marked this pull request as ready for review July 7, 2026 13:07

Gonals requested review from a team as code owners July 7, 2026 13:07

melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team July 7, 2026 13:07

Gonals changed the title ~~Prevent empty values for mandatory fields in Card Import~~ Prevent empty values for mandatory fields in CSV Card Import Jul 7, 2026

shubham1206agra reviewed Jul 7, 2026

View reviewed changes

shubham1206agra approved these changes Jul 8, 2026

View reviewed changes

melvin-bot Bot requested a review from youssef-lr July 8, 2026 12:52

youssef-lr approved these changes Jul 8, 2026

View reviewed changes

youssef-lr merged commit e7536fe into main Jul 8, 2026
50 of 52 checks passed

youssef-lr deleted the alberto-emptyCols branch July 8, 2026 20:38

OSBotify mentioned this pull request Jul 9, 2026

Deploy Checklist: New Expensify 2026-07-09 #95677

Closed

94 tasks

MelvinBot mentioned this pull request Jul 9, 2026

[No QA] Docs updates for E/A#95488 empty value validation for CSV card import #95688

Draft

melvin-bot Bot mentioned this pull request Jul 10, 2026

[Due for payment 2026-07-17] [$250] CSV card feed import succeeds but no cards are created (no validation for missing required fields) #93704

Open

7 tasks

Uh oh!

Conversation

Gonals commented Jul 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

shubham1206agra Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Gonals Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Jul 8, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

OSBotify commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

MelvinBot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jul 7, 2026 •

edited by github-actions Bot

Loading