Force Control upgrade for both branches of the member-import gate#95614
Draft
iwiznia wants to merge 4 commits into
Draft
Force Control upgrade for both branches of the member-import gate#95614iwiznia wants to merge 4 commits into
iwiznia wants to merge 4 commits into
Conversation
A Submit workspace importing members with Control-only columns (submitTo/ approveTo/etc.) routed through the approvals upgrade feature, which has no requiredPlan, so upgradeSubmit defaulted to Collect (team). The workspace never became Control, so isControlPolicy stayed false and the Upgrade page reopened on every re-import. Pass upgradePlanType=corporate from the gate so both the controlPolicyRoles and approvals branches upgrade to Control, without mutating the shared approvals feature (also used by workflows entry points). Add tests covering both branches.
The page renders through ScreenWrapper and useIsFocusedRef, which call useNavigation/useFocusEffect/usePreventRemove. Without a NavigationContainer these threw "Couldn't find a navigation object" at render. Stub the navigation hooks so the page mounts and the import gate can be exercised.
Add getActiveRouteWithoutParams/getTopmostReportId to the Navigation mock (ScreenWrapper reads them) and useRoute to the react-navigation mock (the transient NotFoundPage render calls it). Both gate tests now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #94859
Explanation of Change
Fixed Issues
$#92943
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari