[Split #94595] Batch E - Remove useOnyx deps from MR views and confirmation

[fabioh8010]

Explanation of Change

Part of the useOnyx dependencies-argument removal (#94595), Batch E of the split: Money Request views, confirmation & expense flows. Drops the deprecated 3rd useOnyx argument; selectors kept stable (inline/compiler-memoized, useCallback in the React-Compiler-bailout file BaseKYCWall). Includes small selector refactors in MoneyRequestView and InvoiceSenderField to keep selector identity stable. No intended behavior change. The main wrapper still accepts the arg, so this batch is independent.

Fixed Issues

$ #95578
PROPOSAL: N/A

Tests

1. Open MoneyRequestView and edit fields; open the receipt view; verify amounts/merchant/participants render the same.
2. Split-expense edit page, reject-expense page, invoice sender field, and report field selector — verify participants/policies/amounts resolve correctly.
3. Verify screens render the same data as before, with no excessive re-rendering / infinite loops.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/KYCWall/BaseKYCWall.tsx	28.97% <100.00%> (+1.65%)	⬆️
...stConfirmationList/sections/InvoiceSenderField.tsx	92.30% <100.00%> (+0.30%)	⬆️
...eyRequestConfirmationList/sections/ReportField.tsx	85.10% <100.00%> (ø)
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	69.47% <100.00%> (-0.25%)	⬇️
...c/components/ReportActionItem/MoneyRequestView.tsx	74.19% <100.00%> (ø)
src/pages/AddExistingExpense.tsx	0.00% <0.00%> (ø)
src/pages/RejectExpenseReportPage.tsx	0.00% <0.00%> (ø)
src/pages/iou/SplitExpenseEditPage.tsx	0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[VickyStash]

Steps:

- KYCWall

1. Open the expense where you should pay and continue with the payment
2. Verify it works as expected.

video

kyc_payment.mp4

- InvoiceSenderField

1. FAB -> Send invoice
2. Proceed with the send invoice flow
3. On the confirmation screen, verify Sender fields look correct
4. Try to change the sender, verify it works

video

invoice_sender.mp4

- ReportField

1. Open Workspace Expenses chat with several expense reports available
2. Start Expense creation
3. On confirmation page verify report field looks as expected
4. Try to change report and see it works

video

report_field.mp4

- MoneyRequestReceiptView, MoneyRequestView

1. Open expense with several transaction
2. Open transaction thread
3. Verify header show correct info
4. Switch to next thread using arrows
5. Verify it looks as expected

video

tr_view.mp4

- AddExistingExpense

1. In the Expense report, press Add expense -> Add existing expense
2. See transactions list display correctly

video

add_existing_expense.mp4

- RejectExpenseReportPage

1. Open submitted expense report (as approver/admin).
2. Report header more menu (⋮) → Reject.
3. Proceed with rejection, see it works

video

reject.mp4

- SplitExpenseEditPage

1. Open expense report
2. Report header more menu (⋮) → Split.
3. Tap on any row to view it -> you land on the SplitExpenseEditPage page
4. Updates description, verify it works

video

split_edit.mp4

[melvin-bot]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hoangzinh]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-21.at.18.36.57.mp4

[hoangzinh]

🚢

[joekaufmanexpensify]

No product review needed

[mountiny]

Thanks

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95619.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b1ccbd86e64-7656fc8-cd239a83389a593672e29f7f12c4fb7a5140662d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b1ccbd8-7656fc8-4a5cbd9eca5521c1ec8b13c7be3bbbeb0d1090e3/index.html

Web 🕸️
https://95619.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 I reviewed the changes in this PR against the help site content under App/docs/articles.

No help site changes are required.

This PR is an internal, non-user-facing refactor: Batch E of the useOnyx dependencies-argument removal (#94595). Every change is React/Onyx hook plumbing — dropping the deprecated 3rd useOnyx argument and keeping selector identity stable via inline/useCallback memoization in files like BaseKYCWall, MoneyRequestView, InvoiceSenderField, ReportField, MoneyRequestReceiptView, SplitExpenseEditPage, RejectExpenseReportPage, and AddExistingExpense.

There is no change to any user-facing feature, UI label, button, tab, setting, workflow, or product behavior — the PR description itself notes "No intended behavior change." The help articles document how users interact with features (money requests, split expenses, invoices, etc.), and none of that surface area is affected here.

Since no documentation updates are warranted, I did not create a draft docs PR.