[CP Staging] Fix overlap styles for table filter bar#95632
Conversation
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-07-08.22-50-54.mp4Monosnap.screencast.2026-07-08.22-52-31.mp4 |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP Staging] Fix overlap styles for table filter bar (cherry picked from commit 29bb19f) (cherry-picked to staging by roryabraham)
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.29-2 🚀
|
|
🤖 Help site review — no docs changes required. This PR is a purely visual CSS fix. It adjusts spacing/alignment so a long filter chip no longer overlaps the Filters button on the workspace Members page:
There is no change to product behavior, feature names, tab names, settings labels, or user-facing copy — nothing that the help site under @JS00001, no help site PR was created since no docs update is needed. If you believe a help article should still be updated, let me know and I'll open a draft PR. |
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.31-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against the help site files under This PR is a pure CSS/layout fix — it adjusts styling on the table filter bar (
Since the Members filter functionality itself is unchanged and only its visual layout was corrected, none of the help site articles need to be updated. No draft docs PR was created. @JS00001, if you believe there's a behavioral or feature change here that I missed and that should be documented, let me know and I'll create the docs PR. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.32-0 🚀
|
|
🤖 Help site review: no changes required (re-confirmed) I re-reviewed this PR's changes against the help site files under No help site articles need updating, so no draft docs PR was created. @JS00001, if you think there's a behavioral or feature change here that should be documented, let me know and I'll create the docs PR. |
Explanation of Change
Fixes filters overlapping when a filter chip is long in the workspace members page
Fixed Issues
$ #95629
Tests
Create a Control workspace.
Go to workspace settings > Members.
Click Filters.
Select all roles and click Apply.
Resize the screen slowly and ensure the role quick filter doesnt overlap with the 'filters' button
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
Reviewer Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-07-08.at.12.21.41.PM.mov