[No QA] Update help docs for Release 4: Add new Payments Admin role#95747
Conversation
Co-authored-by: Sasha Kluger <sakluger@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
…ness-Bank-Account.md
…ss-Bank-Account.md
…ss-Bank-Account.md
|
@stephanieelliott ready for your review! This feature went live today, so we can merge immediately after approval. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 426eccc997
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Who can share a business bank account | ||
|
|
||
| - Only **Workspace Admins** can share a business bank account. | ||
| - **Workspace Admins** and **Payments Admins** can share a business bank account. |
There was a problem hiding this comment.
Don't document bank sharing for Payments Admins
For Wallet sharing, the Share action is only exposed when hasEligibleActiveAdminFromWorkspaces is true, and that helper calls getActiveAdminWorkspaces/getAdminEmployees, which both require CONST.POLICY.ROLE.ADMIN; the share recipient list is built from the same admin-only helper in ShareBankAccount. In a workspace where the user or intended recipient is only paymentsAdmin, this article now tells them they can share/receive a bank account even though the UI won't offer that path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@JmillsExpensify or @flodnv - Can a Payments Admin share a VBA with other Workspace/Payments Admins?
There was a problem hiding this comment.
I think it should be allowed, right @JmillsExpensify ? cc @ShridharGoel
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
…ness-Bank-Account.md
|
A preview of your ExpensifyHelp changes have been deployed to https://704b6837.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.33-0 🚀
|
Details
Help site updates for Release 4: Add new Payments Admin role of the Scoped Admin Roles and Read-Only Auditor Access project.
The new Payments Admin role has edit access to Workflows > Payments (business bank accounts, preferred payer, and payment methods), read-only access to Overview and Members, and all other workspace editor pages hidden. Payment permissions themselves are unchanged — paying a report still depends on the relevant bank account being shared with the payer.
Articles updated
new-expensify/workspaces/Managing-Workspace-Members.md— added Payments Admin to the workspace roles list and to the member role filter.new-expensify/workspaces/Workspace-Workflows.md— noted that Payments Admins can configure the Payments section and set up a payment account.new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md— added Payments Admins to who can connect a business bank account to a workspace.new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md— added Payments Admins to who can share/receive a shared business bank account.Related Issues
$ https://github.com/Expensify/Expensify/issues/627792
Tests / QA