Skip to content

[No QA] Update help docs for Release 4: Add new Payments Admin role#95747

Merged
stephanieelliott merged 5 commits into
mainfrom
claude-release4-paymentsAdmin
Jul 10, 2026
Merged

[No QA] Update help docs for Release 4: Add new Payments Admin role#95747
stephanieelliott merged 5 commits into
mainfrom
claude-release4-paymentsAdmin

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Details

Help site updates for Release 4: Add new Payments Admin role of the Scoped Admin Roles and Read-Only Auditor Access project.

The new Payments Admin role has edit access to Workflows > Payments (business bank accounts, preferred payer, and payment methods), read-only access to Overview and Members, and all other workspace editor pages hidden. Payment permissions themselves are unchanged — paying a report still depends on the relevant bank account being shared with the payer.

Articles updated

  • new-expensify/workspaces/Managing-Workspace-Members.md — added Payments Admin to the workspace roles list and to the member role filter.
  • new-expensify/workspaces/Workspace-Workflows.md — noted that Payments Admins can configure the Payments section and set up a payment account.
  • new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md — added Payments Admins to who can connect a business bank account to a workspace.
  • new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md — added Payments Admins to who can share/receive a shared business bank account.

Related Issues

$ https://github.com/Expensify/Expensify/issues/627792

Tests / QA

  • Verify the updated articles render correctly on the help site.
  • Confirm role names, tab names, and settings labels match the current Expensify UI.

Co-authored-by: Sasha Kluger <sakluger@users.noreply.github.com>
@github-actions github-actions Bot changed the title Update help docs for Release 4: Add new Payments Admin role [No QA] Update help docs for Release 4: Add new Payments Admin role Jul 9, 2026
@OSBotify

This comment has been minimized.

Comment thread docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md Outdated
Comment thread docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md Outdated
@sakluger sakluger marked this pull request as ready for review July 9, 2026 21:14
@sakluger

sakluger commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott ready for your review! This feature went live today, so we can merge immediately after approval.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 426eccc997

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Who can share a business bank account

- Only **Workspace Admins** can share a business bank account.
- **Workspace Admins** and **Payments Admins** can share a business bank account.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't document bank sharing for Payments Admins

For Wallet sharing, the Share action is only exposed when hasEligibleActiveAdminFromWorkspaces is true, and that helper calls getActiveAdminWorkspaces/getAdminEmployees, which both require CONST.POLICY.ROLE.ADMIN; the share recipient list is built from the same admin-only helper in ShareBankAccount. In a workspace where the user or intended recipient is only paymentsAdmin, this article now tells them they can share/receive a bank account even though the UI won't offer that path.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JmillsExpensify or @flodnv - Can a Payments Admin share a VBA with other Workspace/Payments Admins?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be allowed, right @JmillsExpensify ? cc @ShridharGoel

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR introduces the new Payments Admin role across four existing help articles for Release 4. The changes are targeted, consistent in intent, and correctly extend role eligibility for connecting, sharing, and managing business bank accounts and Workflows payment settings. The edits integrate cleanly into the existing structure and metadata (including internalScope and keywords), which are updated appropriately.

Scores Summary

  • Readability: 9/10 - Additions are clear, concise, and consistent with surrounding sentence structure. Role descriptions match the pattern of existing roles (People Admin, Card Admin).
  • AI Readiness: 9/10 - internalScope and keywords metadata were correctly updated to include the new role, improving retrieval. Task-based headings and single-workflow scope are preserved. No new headings introduced, so no hierarchy risk.
  • Style Compliance: 7/10 - Mostly compliant with exact UI terminology and bold formatting for sections and roles. One terminology inconsistency needs fixing (see below).

Key Findings

  • Terminology inconsistency (must fix): In Connect-a-Business-Bank-Account.md, the body sentence uses Payment Admin (singular) - 'if you are a Workspace Admin or a Payment Admin' - while the internalScope, the Who can list, and every other file use Payments Admin (plural). Per HELPSITE_NAMING_CONVENTIONS.md (exact UI text, no variation), align this to Payments Admin.
  • Positive: The new Payments Admin role description in Managing-Workspace-Members.md is thorough and precisely scoped (permissions, read-only areas, Control-only limitation), matching the established role-entry pattern.
  • Positive: Workspace-Workflows.md note and payment-account section were updated cleanly to reflect that Payments Admins can configure the Payments section, with Submissions correctly retained as Workspace Admin only.
  • Positive: The member role filter and Share-a-Business-Bank-Account.md FAQ and notes were consistently updated; generalizing to 'multiple admins' and 'eligible admin' reads well and avoids overstating.

Recommendations

  • Priority: Correct 'Payment Admin' to 'Payments Admin' in the intro paragraph of Connect-a-Business-Bank-Account.md for exact UI-term consistency.
  • Optional: Confirm bold formatting on the new role name in the Connect article body matches the treatment used elsewhere (roles are referenced in bold in the Members and Workflows articles).

Files Reviewed

  • Connect-a-Business-Bank-Account.md - Good; one singular/plural terminology fix needed.
  • Share-a-Business-Bank-Account.md - Clean and consistent.
  • Managing-Workspace-Members.md - Excellent role description; compliant.
  • Workspace-Workflows.md - Clear and accurate.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott merged commit 43ddbfb into main Jul 10, 2026
16 checks passed
@stephanieelliott stephanieelliott deleted the claude-release4-paymentsAdmin branch July 10, 2026 02:41
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants