Add agent template picker structure

[shubham1206agra]

Explanation of Change

Fixed Issues

$ #94394

Tests

1. Open App
2. Go to Settings > Agents.
3. Click on New Agent.
4. Verify that the new menu opens with pre-defined templates.
5. Click on Add on any option.
6. Verify that the Add agent form opens pre-filled with prompt.
7. Click on Create and verify that the agent with same prompt created.
8. Click on New Agent again.
9. Click on Build custom agent option.
10. Verify that the Add agent form opens pre-filled with default prompt.

• Verify that no errors appear in the JS console

Offline tests

1. Open App
2. Go to Settings > Agents.
3. Click on New Agent.
4. Verify that empty view opens with no option.
5. Click on Build custom agent option.
6. Verify that the Add agent form opens pre-filled with default prompt.

QA Steps

Same as Tests

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-07-23.at.9.09.31.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-07-23.at.9.01.12.PM.mov

iOS: Native

Screen.Recording.2026-07-23.at.9.04.27.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-07-23.at.8.53.21.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-23.at.7.59.51.PM.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	100.00% <ø> (ø)
src/ROUTES.ts	21.52% <100.00%> (-0.03%)	⬇️
src/SCREENS.ts	100.00% <ø> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
src/libs/ExportOnyxState/common.ts	80.35% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	66.66% <ø> (ø)
src/pages/settings/Agents/AgentsPage.tsx	79.77% <100.00%> (+0.22%)	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	6.49% <0.00%> (-0.01%)	⬇️
src/pages/settings/Agents/NewAgentPage.tsx	98.50% <98.50%> (ø)
... and 3 more
... and 51 files with indirect coverage changes

[shawnborton]

Let us know when this is ready for a test build!

[shubham1206agra]

@shawnborton, go ahead with the design check if you want right now.

[github-actions]

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[shawnborton]

Wow this is feeling really nice!

[shawnborton]

What's the gap between these two lines? I think we want 2px:

[shubham1206agra]

What's the gap between these two lines? I think we want 2px:

@shawnborton It's 0 right now

[shubham1206agra]

@shawnborton Here's gap: 2 setup

[shubham1206agra]

@shawnborton Here's gap: 4 setup

[shawnborton]

Let's do 2 and make @dubielzyk-expensify 's heart sing.

[yuwenmemon]

@shubham1206agra any update here?

[shubham1206agra]

@shawnborton Go ahead and again run the adhoc build for test

[github-actions]

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95991.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b53811fb318-3ea9733-77ee5f4f07cb51ee899aac6163a3651a4991c11a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b53811f-3ea9733-a06d1d73475d86b2932b2ddf903b24c1e3fdb716/index.html

Web 🕸️
https://95991.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Weird, on this branch I see a bunch of blank rows in my agents table:

On staging I see this:

I previously had a bunch of old agents that I deleted, in case that's helpful.

[shubham1206agra]

@shawnborton I haven't changed anything on this page. Lemme check anyway

[shubham1206agra]

@MelvinBot Help me with this #95991 (comment)

[MelvinBot]

Those blank rows aren't caused by this PR — they're stale local Onyx data from the agents you previously deleted, not a code regression.

This PR doesn't touch the agents-table row-building logic at all. The only change to AgentsPage.tsx is repointing the "New agent" button from SETTINGS_AGENTS_ADD to SETTINGS_AGENTS_NEW. The rows are still built the same way as on staging, from the sharedNVP_agentPrompt_* collection.

Why blank rows appear: a row is rendered for every sharedNVP_agentPrompt_<accountID> key whose matching personalDetailsList[accountID] still exists (AgentsPage.tsx:82-107). The row is only skipped when personalDetails is missing entirely — if it exists but has an empty displayName/login, you get a blank row. When you delete an agent, cleanup relies on the DELETE_AGENT success response clearing both the prompt key and the personal-details entry (Agent.ts deleteAgent). OPEN_AGENTS_PAGE only merges in what the server returns — it never prunes local keys — so any orphaned sharedNVP_agentPrompt_* entries from earlier deletes (e.g. deleted offline, or from a build predating the current cleanup logic) linger locally and render blank. Staging shows them correctly because it's a different/cleaner dataset.

To confirm: clear local storage (sign out and back in, or wipe Onyx) on this branch and reload — the blank rows should disappear. If they persist on a clean state, that would point to a pre-existing bug (deletion cleanup or OPEN_AGENTS_PAGE not pruning stale keys) that's independent of this PR and worth a separate issue.

Templates (AGENT_TEMPLATES) added in this PR are only consumed by the new-agent picker, not the agents table, so they can't be the source of these rows.

[shawnborton]

Okay cool, feel free to ignore then! cc @NicolasBonet @yuwenmemon @puneetlath to review above though as a heads up

[NicolasBonet]

@MelvinBot can you create a ticket for that bug and assign it to me?

[MelvinBot]

Done — created and assigned it to you: #96889

It captures the root cause from the analysis above (orphaned sharedNVP_agentPrompt_* entries from deleted agents that OPEN_AGENTS_PAGE never prunes, rendering as blank rows), repro steps, and two candidate fixes. This bug is independent of PR #95991, so it can be tackled separately.

[melvin-bot]

@shawnborton @dannymcclain @dubielzyk-expensify @gijoe0295 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b53811fb31

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".