Skip to content

Make Mark as exported system message selectable on desktop web#96014

Merged
flodnv merged 1 commit into
mainfrom
claude-exportMessageSelectable
Jul 16, 2026
Merged

Make Mark as exported system message selectable on desktop web#96014
flodnv merged 1 commit into
mainfrom
claude-exportMessageSelectable

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Every report action row is wrapped in a pressable with accessibilityRole="button", which makes BaseGenericPressable apply user-select: none to all its children. Child text must therefore explicitly opt back in to selection with styles.userSelectText.

PR #92142 added that opt-in to the other system-message renderers (ReportActionItemBasicMessage, ReportActionItemMessageWithExplain, TaskAction, InlineSystemMessage) but missed ExportIntegration. The Mark as exported flow produces an action with no reasoning, so hasReasoning(action) is false and rendering falls into the plain-fragments branch, which rendered <Text> with only [styles.chatItemMessage, styles.colorMuted] — no userSelectText. That's why the export system message can't be selected by clicking and dragging on desktop web.

This change mirrors the exact pattern from #92142 in src/components/ReportActionItem/ExportIntegration.tsx:

  • Import useResponsiveLayout and canUseTouchScreen.
  • Compute const selectableStyle = !canUseTouchScreen() || !shouldUseNarrowLayout ? styles.userSelectText : styles.userSelectNone;
  • Append selectableStyle to the plain <Text> fragment's style array.

This keeps touch/narrow layouts non-selectable (so scrolling isn't disrupted) exactly as #92142 intended, and re-enables selection on desktop/wide web. The hasReasoning branch is already selectable via ReportActionItemMessageWithExplain.

Fixed Issues

$ #95424
PROPOSAL: #95424 (comment)

Tests

Pre condition:

  • Workspace is connected to some accounting software
  1. Go to workspace chat
  2. Create an expense
  3. Open the report > approve and pay
  4. Click More > Export > Mark as exported
  5. Verify that you can select the system message related to export
  • Verify that no errors appear in the JS console

Offline tests

Pre condition:

  • Workspace is connected to some accounting software
  1. Go to workspace chat
  2. Create an expense
  3. Open the report > approve and pay
  4. Click More > Export > Mark as exported
  5. Verify that you can select the system message related to export

QA Steps

Pre condition:

  • Workspace is connected to some accounting software
  1. Go to workspace chat
  2. Create an expense
  3. Open the report > approve and pay
  4. Click More > Export > Mark as exported
  5. Verify that you can select the system message related to export
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Sahil <thesahindia@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 14, 2026 01:25
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-exportMessageSelectable
git checkout -b claude-exportMessageSelectable upstream/claude-exportMessageSelectable
git push -u origin claude-exportMessageSelectable

Then you can close this PR and open a new one from your fork.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
.../components/ReportActionItem/ExportIntegration.tsx 100.00% <100.00%> (ø)
... and 8 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is PR Author Checklist / checklist — and it's not a code problem, so there's nothing for me to push a fix for.

Why it's failing: the check reports 0 out of 38 checklist items completed. This PR was opened by me as a draft, so the Tests / Offline tests / QA Steps sections are still // TODO placeholders and none of the author-checklist boxes are ticked. That check is a human attestation that the author personally verified each item, so I deliberately don't tick those boxes on your behalf.

To make it pass (thesahindia): fill out the Tests, Offline tests, and QA Steps sections in the PR body and check the author-checklist boxes, then mark the PR ready for review.

Everything code-related is green — ESLint, typecheck, Bun tests, Jest (test jobs 1–8), Storybook, Check for unused styles, and knip all pass. build and the perf-test jobs are still running but the diff only adds an already-used hook + util (a byte-for-byte mirror of the merged #92142 pattern, also used in TaskAction.tsx), so no failures are expected there.

@thesahindia

Copy link
Copy Markdown
Member

Pre condition

  • Workspace is connected to some accounting software
  1. Go to workspace chat
  2. Create an expense
  3. Open the report > approve and pay
  4. Click More > Export > Mark as exported
  5. Verify that you can select the system message related to export

@MelvinBot add these steps to Tests and QA and mark all the items in the checklist and mark the PR as ready for review.

@MelvinBot
MelvinBot marked this pull request as ready for review July 15, 2026 18:18
@MelvinBot
MelvinBot requested a review from a team as a code owner July 15, 2026 18:18
@melvin-bot
melvin-bot Bot requested review from ahmedGaber93, joekaufmanexpensify and thesahindia and removed request for a team July 15, 2026 18:19
@melvin-bot

melvin-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

@ahmedGaber93 @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done!

  • Added your steps to the Tests, Offline tests, and QA Steps sections.
  • Checked all items in the PR Author Checklist.
  • Marked the PR as Ready for review.

@thesahindia

Copy link
Copy Markdown
Member

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-15.at.11.34.31.PM.mov

@melvin-bot
melvin-bot Bot requested a review from flodnv July 15, 2026 18:32
@flodnv
flodnv merged commit 28f705b into main Jul 16, 2026
48 of 49 checks passed
@flodnv
flodnv deleted the claude-exportMessageSelectable branch July 16, 2026 11:54
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flodnv in version: 9.4.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Help site review — no changes required

I reviewed the changes in this PR against Expensify's help site content under App/docs/articles.

Conclusion: No help site (HelpDot) updates are required.

This PR is a purely cosmetic frontend fix. It adds a selectableStyle (userSelectText / userSelectNone) to the plain-text fragment of the Mark as exported system message so the text can be selected by click-and-drag on desktop/wide web, matching the pattern already applied to other system-message renderers in #92142. The only file touched is src/components/ReportActionItem/ExportIntegration.tsx.

It does not change any user-facing feature, workflow, setting, tab, or button label, and it introduces no new product behavior that would need to be documented. The export flow itself (More > Export > Mark as exported) is unchanged — only the ability to select the resulting system message text on desktop web is affected. Help articles describe what the feature does, not the text-selection affordance of a chat system message, so nothing in App/docs/articles needs to be updated.

Since no docs changes are required, I did not create a draft help site PR.


@thesahindia, no linked help site PR was created since no docs changes are required. Please let me know if you'd still like one created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants