refactor: extract queue-derived pending-request state into PendingRequests module by BartekObudzinski · Pull Request #96040 · Expensify/App

BartekObudzinski · 2026-07-14T10:21:12Z

Explanation of Change

Loading indicators that read from a stored boolean flag can get stuck on forever if the write that clears the flag is lost, for example when the app closes or reloads in the gap between a request finishing and the flag being cleared. The LoadingBar avoids this today by deriving its visibility straight from the request queue instead: a request is always removed from the queue when it resolves, so there is no separate flag that can go stale.

This PR extracts that pattern into src/libs/PendingRequests, a module that answers "is a request of this kind currently in flight?" by reading the two Onyx keys behind the queue (PERSISTED_REQUESTS and PERSISTED_ONGOING_REQUESTS). It defines three command groups (app load, report load scoped by reportID, and the LoadingBar's own command set) and exposes one hook per group: useIsAppLoadPending(), useIsReportLoadPending(reportID), and useIsLoadingBarPending(). No new Onyx writes or connections are added.

useLoadingBarVisibility is refactored to call useIsLoadingBarPending() instead of keeping its own copy of the selectors. The behavior is unchanged, including the asymmetric offline filter (a persisted request initiated while offline does not count as pending, but the ongoing request always does).

The other two hooks are not consumed yet. They exist so later PRs can move loading and skeleton gates that currently rely on stored flags onto the same queue-derived pattern, one call site at a time.

Fixed Issues

$ #96060
PROPOSAL:

Tests

Online, open any report (or pull to refresh) so an OpenApp/ReconnectApp/OpenReport/ReadNewestAction request fires. Verify the thin LoadingBar under the header appears while the request is in flight and disappears once it resolves, exactly as on main.
Go offline and send a message in any report so a write command queues without sending. Verify the LoadingBar stays hidden for the queued request.
Come back online with that request still queued. Verify the LoadingBar appears while the request is actively sending, then disappears.

Verify that no errors appear in the JS console

Offline tests

Go offline and trigger a command from the LoadingBar set (e.g. send a message so a write command queues). Verify the LoadingBar stays hidden while the request sits in the offline queue.
Come back online. Verify the LoadingBar appears once the queued request starts actively sending and disappears when it resolves.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… onto it

…quests-module

…ctors

…quests-module

adhorodyski

I think it's not really NIT but the naming could be improved for the pending stuff module.

melvin-bot · 2026-07-14T13:15:20Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BartekObudzinski · 2026-07-14T13:15:24Z

@codex review

chatgpt-codex-connector · 2026-07-14T13:20:22Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 5acc642697

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…quests-module

…moization parity across compilers

joekaufmanexpensify · 2026-07-15T17:05:05Z

No product review needed.

adhorodyski · 2026-07-16T08:51:03Z

-
-    return !!hasRelevantPersistedRequests || !!hasRelevantOngoingRequest;
-}
+export default useLoadingBarVisibility;


I would not reexport, but either put the implementation (that uses internals) directly there OR use the module itself. This file seems redundant then.

Good call. Removed the re-export file and pointed the four consumers straight at the module (import {useLoadingBarVisibility} from '@hooks/useInFlightRequests'). Putting the implementation back in its own file is what reintroduced the compiler memoization divergence, so keeping it in the module is the way.

adhorodyski

NIT only, this is fine I think

…t from the module directly

…quests-module # Conflicts: # Mobile-Expensify

…branch

…quests-module

DylanDylann · 2026-07-16T10:19:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-07-16.at.17.17.05.mov

mountiny

Thanks

github-actions · 2026-07-16T11:23:58Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-16T11:29:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96040.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-16b63370424-84c49dd-5a021d4fe9ae75735fc026dfacf05fe588cf13ca/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-16b6337-84c49dd-f065827895cb9a08ccfa6514c3f5a916c67a361d/index.html

Web 🕸️
https://96040.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-16T11:30:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-16T23:50:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-16T23:53:30Z

🤖 I reviewed the changes in this PR against Expensify's help site content under App/docs/articles.

No help site changes are required.

This PR is a purely internal code refactor. It extracts the queue-derived pending-request logic into a new useInFlightRequests hooks module and re-points existing loading-bar consumers at it. Per the PR description, the LoadingBar's behavior is explicitly unchanged (including the asymmetric offline filter), and the two new hooks (useIsReportLoadPending, useIsAppLoadPending) aren't consumed yet.

There are no user-facing changes here — no new UI, settings, feature names, tab labels, or buttons, and no change to any documented behavior. The help site articles document customer-facing product functionality, so nothing in App/docs/articles describes this internal loading-state plumbing. As a result, there is nothing to create a draft docs PR for.

If a later PR in this series surfaces a user-visible behavior change, that would be the point to revisit the help site.

BartekObudzinski added 3 commits July 14, 2026 11:32

refactor: add PendingRequests module and move useLoadingBarVisibility…

eab9a4f

… onto it

Merge remote-tracking branch 'upstream/main' into refactor/pending-re…

d81bb89

…quests-module

refactor: drop manual selector cache, let React Compiler memoize sele…

f027822

…ctors

melvin-bot Bot assigned BartekObudzinski Jul 14, 2026

BartekObudzinski added 2 commits July 14, 2026 13:16

fix: harden PendingRequests scope-key typing and test setup

3fc3efb

Merge remote-tracking branch 'upstream/main' into refactor/pending-re…

9412dc4

…quests-module

adhorodyski reviewed Jul 14, 2026

View reviewed changes

Comment thread src/hooks/useInFlightRequests.ts

adhorodyski reviewed Jul 14, 2026

View reviewed changes

Comment thread src/hooks/useInFlightRequests.ts

adhorodyski suggested changes Jul 14, 2026

View reviewed changes

refactor: move PendingRequests hooks to src/hooks/useInFlightRequests

5acc642

mountiny mentioned this pull request Jul 14, 2026

refactor: extract queue-derived pending-request state into PendingRequests module #96060

Open

BartekObudzinski marked this pull request as ready for review July 14, 2026 13:15

BartekObudzinski requested review from a team as code owners July 14, 2026 13:15

melvin-bot Bot requested a review from DylanDylann July 14, 2026 13:15

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 14, 2026 13:15

BartekObudzinski requested a review from adhorodyski July 14, 2026 13:19

BartekObudzinski added 4 commits July 15, 2026 08:01

Merge remote-tracking branch 'upstream/main' into refactor/pending-re…

43d30eb

…quests-module

fix: move useLoadingBarVisibility into useInFlightRequests to keep me…

717b620

…moization parity across compilers

fix: keep the request-queue engine inert in useInFlightRequests tests

d188cc8

fix: satisfy consistent-type-imports in the network state mock

49422b1

joekaufmanexpensify removed their request for review July 15, 2026 17:05

DylanDylann reviewed Jul 15, 2026

View reviewed changes

Comment thread src/hooks/useInFlightRequests.ts

adhorodyski reviewed Jul 16, 2026

View reviewed changes

Comment thread tests/unit/useInFlightRequestsTest.ts

adhorodyski approved these changes Jul 16, 2026

View reviewed changes

BartekObudzinski added 6 commits July 16, 2026 11:34

refactor: drop the redundant useLoadingBarVisibility re-export, impor…

b466c5f

…t from the module directly

Merge remote-tracking branch 'upstream/main' into refactor/pending-re…

0564de3

…quests-module # Conflicts: # Mobile-Expensify

chore: restore .mcp.json to main (unrelated local config)

3a3e115

chore: stop tracking local webpack dev certs

0dff5a5

chore: drop unrelated local CLAUDE.md edits and sync-main skill from …

23b50a7

…branch

Merge remote-tracking branch 'upstream/main' into refactor/pending-re…

420baf3

…quests-module

DylanDylann approved these changes Jul 16, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 16, 2026 10:56

mountiny approved these changes Jul 16, 2026

View reviewed changes

mountiny merged commit 16b6337 into Expensify:main Jul 16, 2026
35 checks passed

OSBotify mentioned this pull request Jul 16, 2026

Deploy Checklist: New Expensify 2026-07-16 #96356

Open

52 tasks

Uh oh!

Conversation

BartekObudzinski commented Jul 14, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

adhorodyski left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 14, 2026

Uh oh!

BartekObudzinski commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 14, 2026

Uh oh!

joekaufmanexpensify commented Jul 15, 2026

Uh oh!

Uh oh!

adhorodyski Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adhorodyski left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

BartekObudzinski commented Jul 14, 2026 •

edited by mountiny

Loading