[CP Staging] Revert "Open validation RHP directly for pending USD bank accounts"#96182
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
MonilBhavsar
changed the title
|
@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…ankAccountValidationNavigation [CP Staging] Revert "Open validation RHP directly for pending USD bank accounts" (cherry picked from commit 80be0e7) (cherry-picked to staging by Beamanator)
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.34-11 🚀
|
|
🤖 I reviewed the changes and checked the help site files under No help site changes are required — no draft PR created. This PR reverts #94707, which was a purely internal navigation/routing change: it controlled whether tapping a PENDING USD business bank account jumped straight to the "Validate your bank account" RHP or opened the standard bank account setup entry point first. This revert restores the prior navigation behavior. The relevant help article, Validate a Business Bank Account, documents the user-facing flow only — go to Account > Wallet, click the bank account with the Action required badge, enter the test transaction amounts, and click Validate. Those documented steps hold true both before and after this revert; the change only affects which screen the app opens internally, not any documented feature name, tab, label, or user flow. What I checked
|
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.34-14 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles under Why: This PR reverts The most relevant article, Validate a Business Bank Account, describes the flow at the level users care about — go to Account > Wallet, click the bank account with the Action required badge, enter the three test-transaction amounts, and click Validate. That flow and its outcome are unaffected by this revert; only an intermediate navigation screen changed. No other article documents this specific navigation shortcut. Since no changes are needed, I did not create a draft help site PR. @MonilBhavsar, please confirm you agree no help site updates are needed here. If you believe an article should be updated to reflect the current navigation behavior, let me know and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.35-1 🚀
|
|
🤖 Re-reviewed — my conclusion is unchanged: no help site changes are required. This PR reverts @MonilBhavsar, please confirm you agree no help site updates are needed here. If you'd like an article updated to reflect the current navigation behavior, let me know and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.4.35-6 🚀
|
4 participants
$ #96130
Reverts #94707