🍒 Cherry pick PR #96168 to staging 🍒#96226
Conversation
(cherry picked from commit 09b1d3c) (cherry-picked to staging by jasperhuangg)
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…c-closure-bailout Fix FlashList max-update-depth crashes from OXC React Compiler bailouts (cherry picked from commit 5952b09) (cherry-picked to staging by jasperhuangg) Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-13 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR (a cherry-pick of #96168). This is a purely internal engineering change — it restores dual Babel/OXC React Compiler auto-memoization to fix "Maximum update depth exceeded" crashes on FlashList-heavy screens, by:
There are no user-facing feature changes, new settings, renamed tabs/labels, or behavioral changes. Nothing here is documented in If you believe a specific user-facing behavior changed that I missed, reply with the detail and I'll take another look. |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-14 🚀
|
|
🤖 No help site changes required (confirming my earlier review). This PR is a cherry-pick of #96168 — a purely internal React Compiler (Babel/OXC) memoization fix that resolves "Maximum update depth exceeded" crashes on FlashList-heavy screens. It contains no user-facing feature changes, new settings, renamed tabs/labels, or behavioral changes, so nothing in If a specific user-facing behavior changed that I missed, reply with the detail and I'll re-review. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.4.34-14 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR (a cherry-pick of #96168). This is a purely internal engineering change — it restores dual Babel/OXC React Compiler auto-memoization to fix "Maximum update depth exceeded" crashes on FlashList-heavy screens, by:
There are no user-facing feature changes, new settings, renamed tabs/labels, or behavioral changes. Nothing here is documented in If you believe a specific user-facing behavior changed that I missed, reply with the detail and I'll take another look. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
🍒 Cherry pick #96168 to staging 🍒
This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:
Then manually resolve conflicts, and commit the change with
git cherry-pick --continue. Lastly, please run:This last part is important. It will help us keep track of who triggered this CP, and will ensure that version bumps are tracked correctly. Once all that's done, push your changes with
git push origin cherry-pick-staging-96168-29454712293-1, and then open this PR for review.Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.
Important
This PR should ideally be merged by a member of the mobile-deployers team. If it is merged by someone who is not a deployer, the staging deploy triggered by the merge will fail and will need to be manually re-triggered (not just retried) via the deploy workflow.
Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari