fix: Fix on LHN while no error in chat when paid offline the deleted IOU then turn online

[nkdengineer]

Explanation of Change

fix: Fix on LHN while no error in chat when paid offline the deleted IOU then turn online

Fixed Issues

$ #93934
PROPOSAL: #93934 (comment)

Tests

1. User A at the main device create a chat with user B which not have a existing conversation
2. User A send a message
3. User B at second device receive the message and send an expense
4. User A receive the IOU and disable the internet connection
5. User B at second device delete the IOU
6. User A tap on the IOU and mark as paid
7. User A tap back button to return LHN
8. User A enable the internet connection
9. User A observe the chat on LHN
10. Verify that no Fix label is on userB's chat LHN

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-07-16.at.14.45.56.mov

Android: mWeb Chrome

Screen.Recording.2026-07-16.at.14.38.41.mov

iOS: Native

Screen.Recording.2026-07-16.at.14.43.06.mov

iOS: mWeb Safari

Screen.Recording.2026-07-16.at.14.39.54.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-16.at.14.34.35.mov

[melvin-bot]

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cfe6511c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Guard missing parent actions before skipping propagation

For child reports whose parentReportActionID is absent or whose parent action has not been loaded, parentReportAction is undefined; ReportActionsUtils.isDeletedAction(undefined) returns true because it treats the missing message as the legacy empty deleted shape. In those cases this continue suppresses error propagation even though there is no deleted preview action, so an errored IOU/expense child can stop marking the parent chat with the Fix indicator.

Useful? React with 👍 / 👎.

[huult]

@nkdengineer could you check this comment?

[nkdengineer]

I think it's not a real case. When a report is loaded, the parent report is also loaded as well. Besides, if we still propagation error when the parent report is not available, if we open the parent report we can see the fix label without the action to fix in offline.

[joekaufmanexpensify]

Fine for product.

[huult]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-21.at.19.17.19.mov

Android: mWeb Chrome

Screen.Recording.2026-07-21.at.19.20.49.mov

iOS: HybridApp

Screen.Recording.2026-07-21.at.19.23.31.mov

iOS: mWeb Safari

Screen.Recording.2026-07-21.at.19.25.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-21.at.19.10.40.mov

[huult]

@nkdengineer Please review the Codex comment and merge main to fix the conflict

[huult]

@nkdengineer #96258 (comment) bump

[huult]

LGTM.

[github-actions]

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96258.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-448d87dbae2-eb0ca01-3033d38005eb4e9ea39679f3be0f13d2470189c5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-448d87d-eb0ca01-ffcc1b51fb28325839dfa86acb494c5cc9000125/index.html

Web 🕸️
https://96258.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 Help site review: no changes required.

This PR is an internal bug fix to the report-attributes derived-value logic. It stops a stale Fix (red brick road) indicator from showing on a DM row in the LHN when the underlying IOU's parent action was deleted (e.g. another user deleted the request while an optimistic pay was queued offline).

It corrects erroneous UI behavior — it does not add or change any user-facing feature, setting, tab, button, or workflow that Expensify's help site (docs/articles) documents. A scan of the help articles for the related concepts (LHN, "Fix"/brick-road error indicators) turned up only unrelated pages (company-card feed troubleshooting and NetSuite export errors).

Because there are no documentable behavior changes, I did not create a draft help site PR.

If you believe this behavior is (or should be) documented somewhere I missed, reply with the article and I'll open a docs PR.

[IuliiaHerets]

Hi @nkdengineer. QA team failed this PR with an original issue

cc @Beamanator @joekaufmanexpensify

1784712579893.93934_-_WEB.mp4

[huult]

@IuliiaHerets Could you test this PR on version 9.4.42-0?

[IuliiaHerets]

@huult, we used the 9.4.42-0 build, the same on Native apps

1784725041409.Sbpd2261_1_.mp4

[huult]

Screen.Recording.2026-07-22.at.20.30.58.mov

@IuliiaHerets I can't reproduce this issue on version 9.4.42-0

[IuliiaHerets]

@huult I'll ask team to retest

[IuliiaHerets]

@huult, QA team could still see one additional User B chat with the Fix label in the LHN

Screen.Recording.2026-07-22.at.8.39.47.PM.mov

[nkdengineer]

@huult I think this is the transaction thread report which is failed to create in offline when we open the expense report with only one transaction. So it's intentional as the failureData add this error not our bug. The label on main chat doesn't display which mean it's fixed