[NoQA] Fix main CI failures: seatbelt, personalDetailsList, and PolicyMemberTest

config/eslint/eslint.seatbelt.tsv

@@ -65,7 +65,7 @@
 "../../src/Expensify.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/GlobalModals.tsx"	"no-restricted-syntax"	2
 "../../src/ONYXKEYS.ts"	"no-restricted-syntax"	2
-"../../src/ROUTES.ts"	"@typescript-eslint/no-deprecated/getUrlWithBackToParam"	105
+"../../src/ROUTES.ts"	"@typescript-eslint/no-deprecated/getUrlWithBackToParam"	106
 "../../src/ROUTES.ts"	"@typescript-eslint/no-unsafe-type-assertion"	3
 "../../src/TIMEZONES.ts"	"@typescript-eslint/no-unsafe-type-assertion"	1
 "../../src/components/AccountingConnectionConfirmationModal.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	1

src/libs/actions/Policy/Member.ts

@@ -836,8 +836,19 @@ function buildAddMembersToWorkspaceOnyxData(
     const announceRoomChat = optimisticAnnounceChat.announceChatData;
 
     const doesPersonalDetailExistByAccountID: Record<number, boolean> = {};
+    const newPersonalDetailAccountIDs = new Set<number>();
+    for (const update of newPersonalDetailsOnyxData.optimisticData ?? []) {
+        if (update.key !== ONYXKEYS.PERSONAL_DETAILS_LIST) {
+            continue;
+        }
+
+        for (const accountID of Object.keys(update.value ?? {})) {
+            newPersonalDetailAccountIDs.add(Number(accountID));
+        }
+    }
+
     for (const accountID of accountIDs) {
-        doesPersonalDetailExistByAccountID[accountID] = !!personalDetailsList?.[accountID];
+        doesPersonalDetailExistByAccountID[accountID] = !newPersonalDetailAccountIDs.has(accountID);
     }
 
     // create onyx data for policy expense chats for each new member

src/libs/actions/Policy/Policy.ts

@@ -117,6 +117,7 @@ import type {
     InvitedEmailsToAccountIDs,
     LastPaymentMethod,
     LastPaymentMethodType,
+    PersonalDetailsList,
     Policy,
     PolicyCategories,
     PolicyCategory,

tests/actions/PolicyMemberTest.ts

@@ -1,4 +1,5 @@
 import DateUtils from '@libs/DateUtils';
+import {getPersonalDetailsOnyxDataForOptimisticUsers} from '@libs/PersonalDetailsUtils';
 
 import CONST from '@src/CONST';
 import OnyxUpdateManager from '@src/libs/actions/OnyxUpdateManager';
@@ -404,7 +405,7 @@ describe('actions/PolicyMember', () => {
             await mockFetch?.resume?.();
         });
 
-        it('uses the explicit personal details list to decide new-member success-data participants instead of the deprecated copy', () => {
+        it('uses new personal details onyx data to decide new-member success-data participants instead of the deprecated copy', () => {
             const policyID = '1';
             const policy = {...createRandomPolicy(Number(policyID))};
 
@@ -413,16 +414,14 @@ describe('actions/PolicyMember', () => {
             const absentMemberEmail = 'absent@example.com';
             const absentMemberAccountID = 8765;
 
-            // The personal details list knows the "present" member but not the "absent" one.
-            const personalDetailsList = {[presentMemberAccountID]: {accountID: presentMemberAccountID, login: presentMemberEmail}};
+            const newPersonalDetailsOnyxData = getPersonalDetailsOnyxDataForOptimisticUsers([absentMemberEmail], [absentMemberAccountID], TestHelper.formatPhoneNumber);
 
             const {membersChats} = Member.buildAddMembersToWorkspaceOnyxData(
                 {[presentMemberEmail]: presentMemberAccountID, [absentMemberEmail]: absentMemberAccountID},
+                newPersonalDetailsOnyxData,
                 policy,
                 [],
                 CONST.POLICY.ROLE.USER,
-                TestHelper.formatPhoneNumber,
-                personalDetailsList,
                 currentUser,
                 undefined,
             );