[No QA] Clarify shipit emoji must be the last comment before closing#96533
Merged
Conversation
melvin-bot
Bot
requested review from
ChavdaSachin
and removed request for
a team
July 21, 2026 00:59
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@FitseTLT @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
luacmartins
approved these changes
Jul 21, 2026
Contributor
lol |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.42-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@luacmartins please review
Explanation of Change
The reopened-checklist comment tells people the checklist has unchecked items or is missing the
emoji, but the issue is still reopened.
:shipit:approval, but doesn't say the emoji has to be the last comment. Thus, stupid people like me get confused when they see that they have added theFixed Issues
From #96356
Tests
.github/workflows/finishReleaseCycle.ymland confirm the added parenthetical renders correctly as GitHub markdown.Offline tests
N/A — workflow-only copy change, no app runtime behavior involved.
QA Steps
N/A — this comment is posted by a GitHub Actions workflow, not something QA can exercise on staging/production.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — this PR only changes a comment string in a GitHub Actions workflow, not any app UI.