Skip to content

[No QA] Clarify shipit emoji must be the last comment before closing#96533

Merged
luacmartins merged 1 commit into
mainfrom
yuwen-96356-shipit-last-comment
Jul 21, 2026
Merged

[No QA] Clarify shipit emoji must be the last comment before closing#96533
luacmartins merged 1 commit into
mainfrom
yuwen-96356-shipit-last-comment

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@luacmartins please review

Explanation of Change

The reopened-checklist comment tells people the checklist has unchecked items or is missing the :shipit: approval, but doesn't say the emoji has to be the last comment. Thus, stupid people like me get confused when they see that they have added the :shipit: emoji, but the issue is still reopened.

Fixed Issues

From #96356

Tests

  1. View the diff in .github/workflows/finishReleaseCycle.yml and confirm the added parenthetical renders correctly as GitHub markdown.
  • Verify that no errors appear in the JS console

Offline tests

N/A — workflow-only copy change, no app runtime behavior involved.

QA Steps

N/A — this comment is posted by a GitHub Actions workflow, not something QA can exercise on staging/production.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — this PR only changes a comment string in a GitHub Actions workflow, not any app UI.

@yuwenmemon
yuwenmemon requested a review from a team as a code owner July 21, 2026 00:59
@melvin-bot
melvin-bot Bot requested review from ChavdaSachin and removed request for a team July 21, 2026 00:59
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon
yuwenmemon requested a review from a team July 21, 2026 01:00
@melvin-bot
melvin-bot Bot requested review from FitseTLT and luacmartins July 21, 2026 01:00
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@FitseTLT @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 21, 2026 01:00
@luacmartins

Copy link
Copy Markdown
Contributor

Thus, stupid people like me get confused when they see that they have added the :shipit: emoji, but the issue is still reopened.

lol

@luacmartins
luacmartins merged commit 2373501 into main Jul 21, 2026
18 checks passed
@luacmartins
luacmartins deleted the yuwen-96356-shipit-last-comment branch July 21, 2026 15:24
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.42-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants