Fix submit via PDF cancelation#96602
Conversation
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Part of an existing initiative. LGTM
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-07-21.at.16.56.12.moviOS: mWeb SafariScreen.Recording.2026-07-21.at.16.58.01.movMacOS: Chrome / SafariScreen.Recording.2026-07-21.at.16.44.41.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.43-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under No help site changes are required, so no draft PR was created. This PR is a UI-behavior bug fix: it calls I searched @iwiznia, since no help site changes are required, there is no linked help site PR to review. If you believe this behavior should be documented, let me know and I'll draft one. |
Explanation of Change
This cancels the animation too so button always reverts back
Fixed Issues
$#96552
PROPOSAL:
Tests
Offline tests
No
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari