[Experimental] Remove left-nav icons from Spend, Account, and Workspace Editor menus

[MelvinBot]

Explanation of Change

⚠️ Experimental PR — opened at the request of dannymcclain to preview a design change. Not tied to an approved issue/proposal.

This removes the left-side icons from the menu rows in three left-hand navigation menus, keeping the text labels intact:

1. Spend page (Search sidebar) — SearchTypeMenuWide no longer passes an icon to each SearchTypeMenuItem, and the now-unused lazy-icon lookup was removed.
2. Account / Settings page — SettingsMenuItem no longer passes icon/iconType to MenuItem.
3. Individual Workspace Editor page — WorkspaceInitialPage no longer passes icon to each HighlightableMenuItem.

Only the left-hand-nav leaf rows are affected; right-side chevrons/accessory icons and the workspace avatar are untouched. Each change is scoped to a component used solely by the respective menu, so no other screens are impacted.

Note: on the Spend sidebar, when collapsed the rows previously showed only icons — with icons removed the collapsed state has no glyphs. Flagging in case the collapsed behavior needs a follow-up decision.

Fixed Issues

$
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

🚧 dannymcclain has triggered a test Expensify/App build. You can view the workflow run here.

[MelvinBot]

I looked into the checks. There's no failing check that a code push can fix — nothing to change here.

The one red check is PR Author Checklist / checklist, which fails with:

You completed 0 out of 38 checklist items with 38 unfinished items

That check just verifies the boxes in the PR Author Checklist section of the PR body are ticked. It's a human step — I can't complete it by pushing code. Go through the checklist in the description and check the items off (this is an experimental preview PR, so most are quick), and that check will pass on the next run.

Everything else is green or still running, and I don't expect any real failures:

• ESLint, Oxfmt, Bun tests, Storybook, all completed test (job N) shards, and every build (…) that has finished are ✅.
• Still pending are typecheck, build (Debug, true), and the perf-test jobs — these are just slow-starting standard jobs, not failures.

I sanity-checked the only change that could plausibly trip typecheck — icon={undefined} on SearchTypeMenuItem — and it's fine: the prop is typed icon: IconAsset | undefined, so undefined is valid. The other two changes only remove props, which is type-safe. So typecheck should pass once it runs.

TL;DR: No code fix needed. Tick the PR Author Checklist boxes in the description to clear the only red check.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96689.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-93365db510a-7656fc8-cd239a83389a593672e29f7f12c4fb7a5140662d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-93365db-7656fc8-4a5cbd9eca5521c1ec8b13c7be3bbbeb0d1090e3/index.html

Web 🕸️
https://96689.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀